From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755009AbZBZTnx (ORCPT ); Thu, 26 Feb 2009 14:43:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752898AbZBZTnl (ORCPT ); Thu, 26 Feb 2009 14:43:41 -0500 Received: from acsinet11.oracle.com ([141.146.126.233]:46122 "EHLO acsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752841AbZBZTnk (ORCPT ); Thu, 26 Feb 2009 14:43:40 -0500 Cc: Jay Vosburgh , David Miller , arvidjaar@mail.ru, vladislav.yasevich@hp.com, tytso@mit.edu, Valdis.Kletnieks@vt.edu, rjw@sisk.pl, netdev@vger.kernel.org, bonding-devel@lists.sourceforge.net, jamagallon@ono.com, linux-kernel@vger.kernel.org Message-Id: From: Chuck Lever To: Brian Haley In-Reply-To: <49A6ED6D.3090508@hp.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: [PATCH v2] bonding: move IPv6 support into a separate kernel module Date: Thu, 26 Feb 2009 14:41:36 -0500 References: <49A5ADB3.2010709@hp.com> <28797.1235599858@death.nxdomain.ibm.com> <20090225.141430.166906161.davem@davemloft.net> <49A6C6ED.3070801@hp.com> <22876.1235672073@death.nxdomain.ibm.com> <49A6ED6D.3090508@hp.com> X-Mailer: Apple Mail (2.930.3) X-Source-IP: acsmt706.oracle.com [141.146.40.84] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.49A6F077.0176:SCFSTAT928724,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Feb 26, 2009, at Feb 26, 2009, 2:28 PM, Brian Haley wrote: > Jay Vosburgh wrote: >>>>> I've been fooling with the disable_ipv6 sysctl, and one issue is >>>>> that, at least on the distro I'm testing on (SLES), it's not >>>>> picked up >>>>> from /etc/sysctl.conf at boot time (presumably because ipv6 >>>>> isn't loaded >>>>> yet, although I haven't really checked). >>>> Correct, that's the problem. >>>> >>>> We could create a blocker bitmap. Two sysctls, "block_af" and >>>> "unblock_af". You write the AF_foo value for the protocol there >>>> and >>>> it sets or clears the assosciated bit in the internal blocker >>>> bitmap. >>>> >>>> Things like sys_socket() et al. key off of this. >>> I'm open to suggestions at this point in time, I just don't see >>> how this >>> will solve the bonding problem since it still wouldn't load, right? >> It would permit users to load ipv6 (thus allowing bonding to >> load), but prevent ipv6 from actually doing anything. (because >> sys_socket, e.g., won't open an ipv6 socket if block_af includes >> ipv6). > > Right, but it doesn't help someone that changed /etc/modprobe.conf > to have "install ipv6 /bin/true" - they'll have to stop doing that. > > I think changing ipv6 to support a disable_ipv6 module parameter > like Vlad suggested would work, as long as we're not worried about > someone opening an AF_INET6 socket - even if they do they won't get > anywhere. In this case, if IPV6ONLY is set on an AF_INET6 listener, it should still get AF_INET traffic, correct? > That, along with the patch below to actually not add the addresses, > would work (sorry in advance for using an attachment). I'll get > started on that... > > -Brian > > > -- > > The disable_ipv6 knob was meant to be used for the kernel to disable > IPv6 on an interface when DAD failed for the link-local address > based on the MAC, but we should also be able to administratively > disable it on an interface, or the entire system. This patch fixes > the per-interface problem. > > Signed-off-by: Brian Haley > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index f8f76d6..90f2a81 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -603,6 +603,11 @@ ipv6_add_addr(struct inet6_dev *idev, const > struct in6_addr *addr, int pfxlen, > goto out2; > } > > + if (idev->cnf.disable_ipv6) { > + err = -EPERM; > + goto out2; > + } > + > write_lock(&addrconf_hash_lock); > > /* Ignore adding duplicate addresses on an interface */ -- Chuck Lever chuck[dot]lever[at]oracle[dot]com