From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009Ab3KON1L (ORCPT ); Fri, 15 Nov 2013 08:27:11 -0500 Received: from senator.holtmann.net ([87.106.208.187]:60104 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034Ab3KON1B convert rfc822-to-8bit (ORCPT ); Fri, 15 Nov 2013 08:27:01 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: [PATCH] Staging: btmtk_usb: Add hdev parameter to hdev->send driver callback From: Marcel Holtmann In-Reply-To: <20131115130820.GS5302@mwanda> Date: Fri, 15 Nov 2013 22:26:41 +0900 Cc: Geert Uytterhoeven , devel@driverdev.osuosl.org, Johan Hedberg , Greg Kroah-Hartman , Yu-Chen Cho , "linux-kernel@vger.kernel.org list" , "linux-bluetooth@vger.kernel.org development" Content-Transfer-Encoding: 8BIT Message-Id: References: <1384517231-1605-1-git-send-email-geert@linux-m68k.org> <20131115130820.GS5302@mwanda> To: Dan Carpenter X-Mailer: Apple Mail (2.1822) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, >> while this is patch is correct, I do not really care about staging drivers that actually bluntly violate my copyright. >> > > That's very cryptic. > > What is going on here? I googled it and I wasn't able to find what you > are talking about. Care to give us a hint and what you want us to do > here? the last time I checked, the majority of drivers/bluetooth/btusb.c has been written by myself. Now go and compare btusb.c to btmtk_usb.[ch]. > I have also added Johan Hedberg to the CC list because he also helped > break the build. Don't do that. Yes, we are doing exactly that. It is a staging driver. I could not care less if a staging drivers breaks the build or not. If anybody cares about this driver, then take the time to merge it upstream. It has never been submitted to linux-bluetooth mailing list. There are drivers that should have never been merged into staging. This is one of them. Look for yourself and explain to me why this driver is part of staging in the first place. Regards Marcel