From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 792B3C25B0E for ; Tue, 16 Aug 2022 21:06:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237135AbiHPVGD (ORCPT ); Tue, 16 Aug 2022 17:06:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237332AbiHPVGA (ORCPT ); Tue, 16 Aug 2022 17:06:00 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 822A978239 for ; Tue, 16 Aug 2022 14:05:58 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id p10so14029540wru.8 for ; Tue, 16 Aug 2022 14:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jrtc27.com; s=gmail.jrtc27.user; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc; bh=2f/85arcP0Ku1kgJpVBVLo1xiYoiCycNRFXo4qwF5Xo=; b=j7RxzFnx4NHVX9l/AUFSE1Ml0ekwRXfROWEusMchscf8rtR5xzICK5XqQg9YnaBef6 vas7FGeF58leFjCuB8JbsTZQErXoYTFytYrpPtfMRS5SjO3jzosSw4LFkOK4+S0kEnn4 A3qPH3JygQkCXgx0/19Rn4qpL3FwvyX1sEmBKk0leIkDA07Aas1KIRnzYICGSfwJmV6f N9YNnjYP7L+NG6sZNIHEzd9C/zb/VB1MnHqW1A5ZizhZ5w6YH0+C9g2xDalyRK5CkWeb aZ0XcFuaKpQYrTdJrxvIFqpQ5BEch3wm2afPlk4467jq2snOOaXSB0LuFTSZYQCP2oNo Jdgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc; bh=2f/85arcP0Ku1kgJpVBVLo1xiYoiCycNRFXo4qwF5Xo=; b=fSqKrfn7OPuP8Tsq8A2gEh5OcxpEA8E1m7Hglmgp27z2nu8i74jc9WwUSHsO+IsLmw jJf4IiOUaQjYezAihlTs4WhWwWYxub2ATuXC5yGZvmBAoAbDvHuHaTiQO/T9S5WlaVeO uldcsMvcjVWaOsTGmJHJfUbSxK+Vum3rBLzNmum4M3omQrhZgvbuFnYcjzq/M8RS7aDx pKwCTdVcAl3timUNF/TcQvH2QoGo9qOdGAfjp8S81H9qD/Egxh8rDiCnA71/d00wWoDY rDuv97Z4F/6iY1ZqF5UTbuNaSSqs9L+YZoc668zqm72s4MiC80GuxaeHVyCraCkzkfmJ +EIQ== X-Gm-Message-State: ACgBeo0PWR/cEWb1naBbKJKSdnV8Ue4hflqrVXgdDXJFi2uIVNXwN0mQ zya3BTsKnb9cZ7hlQvWKVrFEsw== X-Google-Smtp-Source: AA6agR58u8cM3dGXK/53eWyziPV3maDwklbC3ReiAvrslrsNxTN31+j/21RFXv2OwnjVFyzyeoSp5Q== X-Received: by 2002:adf:fb4c:0:b0:225:2033:b745 with SMTP id c12-20020adffb4c000000b002252033b745mr1296556wrs.447.1660683957068; Tue, 16 Aug 2022 14:05:57 -0700 (PDT) Received: from smtpclient.apple (global-5-141.n-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id x15-20020a5d490f000000b002205a5de337sm10889363wrq.102.2022.08.16.14.05.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Aug 2022 14:05:56 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [PATCH v2 1/6] dt-bindings: PCI: fu740-pci: fix missing clock-names From: Jessica Clarke In-Reply-To: <20220816182547.3454843-2-mail@conchuod.ie> Date: Tue, 16 Aug 2022 22:05:55 +0100 Cc: Daire McNamara , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Greentime Hu , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Conor Dooley , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20220816182547.3454843-1-mail@conchuod.ie> <20220816182547.3454843-2-mail@conchuod.ie> To: Conor Dooley X-Mailer: Apple Mail (2.3696.80.82.1.1) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16 Aug 2022, at 19:25, Conor Dooley wrote: >=20 > From: Conor Dooley >=20 > The commit b92225b034c0 ("dt-bindings: PCI: designware: Fix > 'unevaluatedProperties' warnings") removed the clock-names property as > a requirement and from the example as it triggered unevaluatedProperty > warnings. dtbs_check was not able to pick up on this at the time, but > now can: >=20 > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@e00000000: = Unevaluated properties are not allowed ('clock-names' was unexpected) > =46rom schema: = linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml >=20 > The property was already in use by the FU740 DTS and the clock must be > enabled. The Linux driver does not use this property, but outside of > the kernel this property may have users. Re-add the property and its > "clocks" dependency. Are you sure about this? I see a devm_clk_get("pcie_aux") that surely won't without the property. FreeBSD=E2=80=99s similarly relies on the = name, though it also has a fallback to the U-Boot pcieaux name (because the world is terrible and people can=E2=80=99t even agree on that) so it = works with the U-Boot-provided FDT (it would be nice if Linux had this as a goal, and people worked with U-Boot devs to get everything needed for newly-exposed devices merged back there so I don=E2=80=99t have to be = the one to notice and do it...). Jess > Fixes: b92225b034c0 ("dt-bindings: PCI: designware: Fix = 'unevaluatedProperties' warnings") > Fixes: 43cea116be0b ("dt-bindings: PCI: Add SiFive FU740 PCIe host = controller") > Signed-off-by: Conor Dooley > --- > v2022.08 of dt-schema is required. > --- > .../devicetree/bindings/pci/sifive,fu740-pcie.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git = a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml = b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml > index 195e6afeb169..c7a9a2dc0fa6 100644 > --- a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml > @@ -51,6 +51,12 @@ properties: > description: A phandle to the PCIe power up reset line. > maxItems: 1 >=20 > + clocks: > + maxItems: 1 > + > + clock-names: > + const: pcie_aux > + > pwren-gpios: > description: Should specify the GPIO for controlling the PCI bus = device power on. > maxItems: 1 > --=20 > 2.37.1 >=20 >=20 > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv