From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65657ECDE27 for ; Wed, 11 Sep 2019 06:04:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FA5121D7B for ; Wed, 11 Sep 2019 06:04:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="Yv1lhkJp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726645AbfIKGEF (ORCPT ); Wed, 11 Sep 2019 02:04:05 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]:15785 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfIKGEE (ORCPT ); Wed, 11 Sep 2019 02:04:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1568181843; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=gKGcUG8qBRx2NVt1aZm46erige0dfNoaq5CtNk5C3ZA=; b=Yv1lhkJpZ3dMY895yii5m9V3Vbgbbgo/fkzsxb7kAXzDOn7HEcglX7irku25fa2/7f l3cleRNING62ayRQh2p76wgFe2H8zYryr626PjlItQRE+tCTSG1W6tCxzgfx0EjnAqf4 w4DZbNT1UJTwdkKcsZvrY+GxeCNijArJVZlYBzfMVOmnidUPXuJpCEA4nTIIxRTZOLRU sP7o8QSybsEEmAqC03UcrN40Cg2TLltZmZ/ideTsdbxJ2rRiOTHr3NhP7hMdDgKvqL3q jQZ2IO9vt3QFNr5WAZTVwYI8w15uH97Tv+1zQw5DXBvi8kpdjyu2Z07/3wpj9oFyhfM1 lxDg== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGH/PgwDCvjo0=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 44.27.0 DYNA|AUTH) with ESMTPSA id u036f9v8B63n4Qy (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 11 Sep 2019 08:03:49 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [Letux-kernel] [RFC PATCH 0/3] Enable 1GHz support on omap36xx From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 11 Sep 2019 08:03:48 +0200 Cc: Tony Lindgren , =?utf-8?Q?Andr=C3=A9_Roth?= , Linux-OMAP , Discussions about the Letux Kernel , Linux Kernel Mailing List , Andreas Kemnade , Nishanth Menon Content-Transfer-Encoding: quoted-printable Message-Id: References: <0C1EF64E-B33C-4BFA-A7D3-471DD1B9EE86@goldelico.com> <515048DE-138D-4400-8168-F2B7D61F1005@goldelico.com> <7B3D1D77-3E8C-444F-90B9-6DF2641178B8@goldelico.com> <87420DBD-770F-4C32-9499-A3AEA5876E8A@goldelico.com> <20190909163236.GP52127@atomide.com> <3663B13C-1AAB-4BE3-8CAD-F821B70393FA@goldelico.com> <56482888-DBD3-4658-8DB9-FB57653B5AA8@goldelico.com> <2DC3 BCD1-BD61-4109-9AF3-04FBD980FFB8@goldelico.com> To: Adam Ford X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 11.09.2019 um 07:13 schrieb H. Nikolaus Schaller = : >=20 > Hi Adam, >=20 >> Am 11.09.2019 um 02:41 schrieb Adam Ford : >>>>>=20 >=20 >>>>> The error message looks as if we have to enable multi_regulator. >=20 >>>>=20 >>>> That will enable both vdd and vbb regulators from what I can tell = in the driver. >>>>=20 >>>>> And that may need to rename cpu0-supply to vdd-supply (unless the >>>>> names can be configured). >>>>=20 >>>> That is consistent with what I found. vdd-supply =3D <&vcc>; and >>>> vbb-supply =3D <&abb_mpu_iva>; >>>> I put them both under the cpu node. Unfortunately, when I did = that, >>>> my board crashed. >>>>=20 >>>> I am thinking it has something to do with the abb_mpu_iva driver >>>> because until this point, we've always operated at 800MHz or lower >>>> which all have the same behavior in abb_mpu_iva. >>>>=20 >>>> With the patch you posted for the regulator, without the update to >>>> cpufreq, and with debugging enabled, I received the following in >>>> dmesg: >>>>=20 >>>> [ 1.112518] ti_abb 483072f0.regulator-abb-mpu: Missing >>>> 'efuse-address' IO resource >>>> [ 1.112579] ti_abb 483072f0.regulator-abb-mpu: [0]v=3D1012500 = ABB=3D0 >>>> ef=3D0x0 rbb=3D0x0 fbb=3D0x0 vset=3D0x0 >>>> [ 1.112609] ti_abb 483072f0.regulator-abb-mpu: [1]v=3D1200000 = ABB=3D0 >>>> ef=3D0x0 rbb=3D0x0 fbb=3D0x0 vset=3D0x0 >>>> [ 1.112609] ti_abb 483072f0.regulator-abb-mpu: [2]v=3D1325000 = ABB=3D0 >>>> ef=3D0x0 rbb=3D0x0 fbb=3D0x0 vset=3D0x0 >>>> [ 1.112640] ti_abb 483072f0.regulator-abb-mpu: [3]v=3D1375000 = ABB=3D1 >>>> ef=3D0x0 rbb=3D0x0 fbb=3D0x0 vset=3D0x0 >>>> [ 1.112731] ti_abb 483072f0.regulator-abb-mpu: = ti_abb_init_timings: >>>> Clk_rate=3D13000000, sr2_cnt=3D0x00000032 >>>>=20 >>>=20 >>> Using an unmodified kernel, I changed the device tree to make the = abb >>> regulator power the cpu instead of vcc. After doing so, I was able = to >>> read the microvolt value, and it matched the processor's desired OPP >>> voltage, and the debug code showed the abb regulator was attempting = to >>> set the various index based on the needed voltage. I think the abb >>> driver is working correctly. >>>=20 >>> I think tomorrow, I will re-apply the patches and tweak it again to >>> support both vdd and vbb regulators. If it crashes again, I'll look >>> more closely at the logs to see if I can determine why. I think = it's >>> pretty close. I also need to go back and find the SmartReflex stuff >>> as well. >>>=20 >> Well, I couldn't give it up for the night, so I thought I'd show my = data dump >>=20 >> [ 9.807647] ------------[ cut here ]------------ >> [ 9.812469] WARNING: CPU: 0 PID: 68 at drivers/opp/core.c:630 >> dev_pm_opp_set_rate+0x3cc/0x480 >> [ 9.821044] Modules linked in: sha256_generic sha256_arm cfg80211 >> joydev mousedev evdev snd_soc_omap_twl4030(+) leds_gpio led_class >> panel_simple pwm_omap_dmtimer gpio_keys pwm_bl cpufreq_dt omap3_isp v >> ideobuf2_dma_contig videobuf2_memops videobuf2_v4l2 videobuf2_common >> bq27xxx_battery_hdq v4l2_fwnode snd_soc_omap_mcbsp bq27xxx_battery >> snd_soc_ti_sdma omap_wdt videodev mc omap_hdq wlcore_sdio wire cn ph >> y_twl4030_usb hwmon omap2430 musb_hdrc omap_mailbox twl4030_wdt >> watchdog udc_core rtc_twl snd_soc_twl4030 ohci_platform(+) >> snd_soc_core snd_pcm_dmaengine ohci_hcd snd_pcm ehci_omap(+) >> twl4030_pwrbutton sn >> d_timer twl4030_charger snd pwm_twl_led pwm_twl ehci_hcd industrialio >> soundcore twl4030_keypad matrix_keymap usbcore at24 tsc2004 >> tsc200x_core usb_common omap_ssi hsi omapdss omapdss_base drm >> drm_panel_or >> ientation_quirks cec >> [ 9.894470] CPU: 0 PID: 68 Comm: kworker/0:2 Not tainted >> 5.3.0-rc3-00785-gfdfc7f21c6b7-dirty #5 >> [ 9.903198] Hardware name: Generic OMAP36xx (Flattened Device = Tree) >> [ 9.909515] Workqueue: events dbs_work_handler >> [ 9.914031] [] (unwind_backtrace) from [] >> (show_stack+0x10/0x14) >> [ 9.921813] [] (show_stack) from [] >> (dump_stack+0xb4/0xd4) >> [ 9.929107] [] (dump_stack) from [] >> (__warn.part.3+0xa8/0xd4) >> [ 9.936614] [] (__warn.part.3) from [] >> (warn_slowpath_null+0x40/0x4c) >> [ 9.944854] [] (warn_slowpath_null) from [] >> (dev_pm_opp_set_rate+0x3cc/0x480) >> [ 9.953796] [] (dev_pm_opp_set_rate) from [] >> (set_target+0x30/0x58 [cpufreq_dt]) >> [ 9.963012] [] (set_target [cpufreq_dt]) from >> [] (__cpufreq_driver_target+0x188/0x514) >> [ 9.972717] [] (__cpufreq_driver_target) from >> [] (od_dbs_update+0x130/0x15c) >> [ 9.981567] [] (od_dbs_update) from [] >> (dbs_work_handler+0x28/0x58) >> [ 9.989624] [] (dbs_work_handler) from [] >> (process_one_work+0x20c/0x500) >> [ 9.998107] [] (process_one_work) from [] >> (worker_thread+0x2c/0x5bc) >> [ 10.006256] [] (worker_thread) from [] >> (kthread+0x134/0x148) >> [ 10.013702] [] (kthread) from [] >> (ret_from_fork+0x14/0x2c) >> [ 10.020965] Exception stack(0xde63bfb0 to 0xde63bff8) >> [ 10.026062] bfa0: 00000000 >> 00000000 00000000 00000000 >> [ 10.034271] bfc0: 00000000 00000000 00000000 00000000 00000000 >> 00000000 00000000 00000000 >> [ 10.042510] bfe0: 00000000 00000000 00000000 00000000 00000013 = 00000000 >> [ 10.049224] ---[ end trace cf0e15fa4bd57700 ]--- >> [ 10.053894] cpu cpu0: multiple regulators are not supported >> [ 10.059509] cpufreq: __target_index: Failed to change cpu = frequency: -22 >=20 > I have the same: >=20 > [ 4.701354] cpu cpu0: multiple regulators are not supported > [ 4.707794] cpufreq: __target_index: Failed to change cpu = frequency: -22 >=20 > Comes from within dev_pm_opp_set_rate(). >=20 > It appears that we also have to define opp_table->set_opp to make use > of _set_opp_custom(). And I am not sure which custom-opp-setter we = should > use. Maybe ti_opp_supply_set_opp() is ok. Or not. This appears to be set by dra7.dtsi through loading the "ti,omap5-opp-supply" compatible driver: = https://elixir.bootlin.com/linux/v5.3-rc8/source/arch/arm/boot/dts/dra7.dt= si#L699 Maybe we can use "ti,omap-opp-supply" here, which does not read additional eFuses? See also = https://www.kernel.org/doc/Documentation/devicetree/bindings/opp/ti-omap5-= opp-supply.txt And, if I understand the code ti_opp_supply_set_opp() correctly, we may = not have to rename cpu0-suppy to vdd-supply because that driver takes the first regulator as vdd and the second as vbb. Something like opp_supply_mpu_iva: opp_supply { compatible =3D "ti,omap-opp-supply"; ti,absolute-max-voltage-uv =3D <1375000>; }; But that is a quite wild guess... BR, Nikolaus=