mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bradley Morgan <include@grrlz.net>
To: Mete Durlu <meted@linux.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Petr Mladek <pmladek@suse.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	Andreas Larsson <andreas@gaisler.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
	sparclinux@vger.kernel.org
Subject: Re: [PATCH v5 2/3] s390: Implement arch_do_panic()
Date: Mon, 10 Aug 2026 13:01:53 +0100	[thread overview]
Message-ID: <F6A6B990-849D-4F95-B503-8DB33C493ADA@grrlz.net> (raw)
In-Reply-To: <20260810-arch_do_panic-v5-2-e86ae992c253@linux.ibm.com>

On 10 August 2026 12:35:57 BST, Mete Durlu <meted@linux.ibm.com> wrote:
>Implement s390 specific arch_do_panic() instead of using s390 specific
>ifdef sections in vpanic() code. disabled_wait() is now called after
>"end Kernel panic" marker.
>No functional changes.
>

Can't see anything wrong, code wise

Reviewed-by: Bradley Morgan <include@grrlz.net>



>Signed-off-by: Mete Durlu <meted@linux.ibm.com>
>---
> arch/s390/kernel/traps.c | 7 +++++++
> kernel/panic.c           | 3 ---
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
>diff --git a/arch/s390/kernel/traps.c b/arch/s390/kernel/traps.c
>index 564403496a7c..309d3d3e95fd 100644
>--- a/arch/s390/kernel/traps.c
>+++ b/arch/s390/kernel/traps.c
>@@ -24,6 +24,7 @@
> #include <linux/entry-common.h>
> #include <linux/kmsan.h>
> #include <linux/bug.h>
>+#include <linux/panic.h>
> #include <asm/entry-percpu.h>
> #include <asm/asm-extable.h>
> #include <asm/irqflags.h>
>@@ -31,6 +32,7 @@
> #include <asm/vtime.h>
> #include <asm/fpu.h>
> #include <asm/fault.h>
>+#include <asm/processor.h>
> #include "entry.h"
> 
> static inline void __user *get_trap_ip(struct pt_regs *regs)
>@@ -275,6 +277,11 @@ static void monitor_event_exception(struct pt_regs *regs)
> 	}
> }
> 

Comment? I mean, its a suggestion, but it's not strictly needed

>+void arch_do_panic(void)
>+{
>+	disabled_wait();
>+}
>+
> void kernel_stack_invalid(struct pt_regs *regs)
> {
> 	/*
>diff --git a/kernel/panic.c b/kernel/panic.c
>index 726a97842232..ee6e3f9e3900 100644
>--- a/kernel/panic.c
>+++ b/kernel/panic.c
>@@ -752,9 +752,6 @@ void vpanic(const char *fmt, va_list args)
> 		pr_emerg("Press Stop-A (L1-A) from sun keyboard or send break\n"
> 			 "twice on console to return to the boot prom\n");
> 	}
>-#endif
>-#if defined(CONFIG_S390)
>-	disabled_wait();
> #endif
> 	pr_emerg("---[ end Kernel panic - not syncing: %s ]---\n", buf);
> 
>
>

Thanks!

  reply	other threads:[~2026-08-10 12:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 11:35 [PATCH v5 0/3] Introduce arch_do_panic Mete Durlu
2026-08-10 11:35 ` [PATCH v5 1/3] panic: " Mete Durlu
2026-08-10 11:35 ` [PATCH v5 2/3] s390: Implement arch_do_panic() Mete Durlu
2026-08-10 12:01   ` Bradley Morgan [this message]
2026-08-10 12:35   ` Heiko Carstens
2026-08-10 11:35 ` [PATCH v5 3/3] sparc: Implement arch_do_panic Mete Durlu
2026-08-10 12:11   ` Bradley Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F6A6B990-849D-4F95-B503-8DB33C493ADA@grrlz.net \
    --to=include@grrlz.net \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreas@gaisler.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=davem@davemloft.net \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=meted@linux.ibm.com \
    --cc=pmladek@suse.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®