From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-95.mta1.migadu.com [95.215.58.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64E6F30D3FE for ; Fri, 14 Aug 2026 13:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.95 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786715650; cv=none; b=MgG3PzzbxnEZVcvkvumZfhGOP6qcbwbYMcDxUT5jyd+DJOhY3wjBnKKOqZ2S1Uf/8ZtXaaXUHnfPGYl6chgomXlVerTB0VrehfA2WRBa1WO+7lt9EovNgpTGE1jGNniFZNC3Klmi53uNImh80AyD+IiuVNIigFYN36BUZ6HrAw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786715650; c=relaxed/simple; bh=Uw1XdTbk5Kq6ysdI0CcZpaMs4SveoGhVuvQt1IuZqOA=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=ZuMThLhayXXTKRiCBp8Kn5ux2a+W+ARn8t1DlsuqxDeGRI3ldZwNdO3dTXeBB3Zo8DdSngjMt0p7FuZNP784T3tgnzRo2Z8eT/LRCVk80JVHhYyByfHzu9Y4bIt9HSkJRWLJ4VI68nng/RMsBoT8KO7idkd5jctzymoB+tEkh7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Yw/NZ9ti; arc=none smtp.client-ip=95.215.58.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Yw/NZ9ti" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=Uw1XdTbk5Kq6ysdI0CcZpaMs4SveoGhVuvQt1IuZqOA=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1786715637; v=1; x=1787320437; b=Yw/NZ9ti5Dm6HiOO9j9jK2DMCDNeFh/Qc8AIUtIehzi/6tb5oUDjbVKsFeK41DUYYWtmbdF5 /IYIJmja71WdQqtyt/u5Pcx+EzGCEglS4cct/3/06yXhm5+HEO7Tm6KijllFIUsLXAHOLK8XFT7 m3la3rluwUKuw9qaMZV7qW3c= X-Envelope-To: linux-kernel@vger.kernel.org Received: from smtpclient.apple (37.66.176.2) by mta10.migadu.com with ESMTPS id d654dc1ab1e3ac93; Fri, 14 Aug 2026 13:53:47 +0000 X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (1.0) Subject: Re: fixing sashiko failure to apply (was Re: [PATCH v5 00/16] mm/rmap: index MAP_PRIVATE file-backed folios by anonymous pgoff) From: Roman Gushchin In-Reply-To: Date: Fri, 14 Aug 2026 15:53:36 +0200 Cc: Matthew Brost , Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Message-Id: References: To: Lorenzo Stoakes X-Mailer: iPad Mail (23G71) > On Aug 14, 2026, at 11:30=E2=80=AFAM, Lorenzo Stoakes (ARM) wrote: >=20 > =EF=BB=BF[ trim cc list ] >=20 > +cc Roman >=20 >> On Fri, Aug 14, 2026 at 02:13:51AM -0700, Matthew Brost wrote: >>> On Fri, Aug 14, 2026 at 10:01:19AM +0100, Lorenzo Stoakes (ARM) wrote: >>> On Thu, Aug 13, 2026 at 11:53:46AM -0700, Andrew Morton wrote: >>>> You'll be mortified to hear that Sashiko wasn't able to find anything >>>> to which to apply this. >>>=20 >>> :)) >>>=20 >>> Well, when it's right it's useful, when it's wrong or suggesting unrelat= ed >>> what-nots it's less useful :>) >>>=20 >>=20 >> Questioning your assumptions is useful, even when they turn out to be wro= ng. >> Show more lines >>=20 >>> I do locally put things through claude + Chris Mason's prompts a lot, I >>> don't always invoke local sashiko as it's very slow and token-heavy or h= as >>> been so far, but am planning to do that more also in future. >>>=20 >>=20 >> Yes, it's kind of odd that Sashiko burns more tokens than a full day of >> breakfast, lunch, and dinner service. Running Sashiko is a bottleneck in >> my workflow, so I'll defer to others on this list. >=20 > Yup, not sure if there are recommended configs for something saner :) >=20 > Maybe Roman has some advice on that? Sorry, no magic way to save tokens without hurting the quality. But I am cur= ious what are your numbers? Can be model-dependent too. In prod on average it burns 3-4M tokens per patc= h with Gemini 3.1 Pro,=20 but maybe mm patches are more complex than average, Idk. One option is to run only some discovery stages (=E2=80=94stages), but this u= nlikely will save you that much. I=E2=80=99d say use a cheaper and faster model for the development, but it h= as it=E2=80=99s downsides too. If you have an example of a patch(set) which is particularly token-hungry, I= can take a look. >=20 >>=20 >>>>=20 >>>> Sashiko can be guided with a base-commit: tag but I'm not sure how to >>>> tell it what tree/branch to try, or even if that's necessary. Perhaps >>>> someone can figure this out sometime. >>>=20 >>> b4 gives a base commit, but I think because the trees are rebased it end= s >>> up being the incorrect one. >>>=20 >>> Not sure what the solution is! >>>=20 >>=20 >> We have seen this on the Xe list (our list is based on drm-tip), >> typically with cross-subsystem patches. Some cross-subsystem patches >> apply and run correctly, while others do not but public CI flows run >> based on drm-tip. I do not have a bisect or a clear understanding of >> what works and what doesn't, but I think it would be very useful if the >> community could better understand the root cause. >=20 > As Mike said, mm-unstable/mm-new is heavily rebased and also carries the o= ld > version of the series before the new one is applied, so it's super unclear= what > the base commit should be there. >=20 > But in general, I wonder if it's possible that we could tell sashiko > after-the-fact what base commit to look at once the series is in, or re-tr= igger > it somehow once it's in-tree? >=20 > Roman - any suggestions on what we could do to help sashiko find things? >=20 > (Once mm-next is in place everything with change again, but can address th= at > then :) I can implement any reasonable logic here, the problem is that my understand= ing is the current mm process is a bit vague here. Which likely will be also an iss= ue for the mm ci. I=E2=80=99ll merge a support for b4-like dependencies specification soon. Re re-starting with manual selection it=E2=80=99s on my todo list, but maybe= a bit lfurther away, as it requires an authorization, etc. Thanks=