From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932551AbdGKOAj (ORCPT ); Tue, 11 Jul 2017 10:00:39 -0400 Received: from mail-by2nam01on0100.outbound.protection.outlook.com ([104.47.34.100]:62151 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755310AbdGKOAg (ORCPT ); Tue, 11 Jul 2017 10:00:36 -0400 Authentication-Results: ah.jp.nec.com; dkim=none (message not signed) header.d=none;ah.jp.nec.com; dmarc=none action=none header.from=cs.rutgers.edu; From: "Zi Yan" To: "Naoya Horiguchi" Cc: "kirill.shutemov@linux.intel.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "minchan@kernel.org" , "vbabka@suse.cz" , "mgorman@techsingularity.net" , "mhocko@kernel.org" , "khandual@linux.vnet.ibm.com" , "dnellans@nvidia.com" , "dave.hansen@intel.com" Subject: Re: [PATCH v8 05/10] mm: thp: enable thp migration in generic path Date: Tue, 11 Jul 2017 10:00:30 -0400 Message-ID: In-Reply-To: <20170711064736.GB22052@hori1.linux.bs1.fc.nec.co.jp> References: <20170701134008.110579-1-zi.yan@sent.com> <20170701134008.110579-6-zi.yan@sent.com> <20170711064736.GB22052@hori1.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_8804FA40-CC25-4A55-BF3B-6B4A404F8436_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Mailer: MailMate (2.0BETAr6086) X-Originating-IP: [128.6.37.137] X-ClientProxiedBy: DM5PR22CA0018.namprd22.prod.outlook.com (10.172.192.156) To MWHPR14MB1661.namprd14.prod.outlook.com (10.171.146.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ffc1620-3445-41ae-3a93-08d4c8653284 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:MWHPR14MB1661; X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1661;3:7KWvN4aFZVbXqRicNQ2CVZ5mHeyxnm09jq5UY6cdBPLDB8dZfhiDX79cmWNDSjQ/XcI1Nt9q9UUk9qn7C3MglftuE4B7a0kP0lrZhFIlB4Tune7udI+Vl2rEL3TesdtJmanf1KQ/16BB/lYEtFsCHLpJSmYtgDIcUJoteZczfJ0CYE2TILGkveqv64QK+Nnh9Qd1uNLYUYZdFbdo+jvAQ2Kdwz1b9aM+a7fvmPZZsf1wh4m3vwdPJJVGOlFh/td7ZeUNFmM7iYdqHFhuyliKkAgt8x4Fk+SagqeM+9S0mAAftrmVUQcNx0r7ji/yqBLWOsZEk1GDXEutpkMlBNXrpwI2k6d6tf2rt5ybUG2ziFFOM+hCdu8rCRCBLRn0jlPsuMuCUZG5c8gh9ly+ndauMYY8gPjj5YkM4tCa/urlcxkWs6Mmxwu3m8x5BqPGx7UtJ8sviu+orlbv1Lsw0XMuUyc4TUgsMAirpxylAotFH6AHb5+227rtcUVbbq4WIkUu1X1yexCXxMCR/D8HnAJzkWJvwjLdWL1fgEjknXHz/olzHTWDVzfmjeskmErs9qNcftxCh8e2Lutkay2TdyowSWYFvlCB0i0m3Z5eTHfcF4GoWGOb9roS54LOi5zhgkY9IRWCH42nlrndfZfQUrtCvebtJM6uc++TicB5xU5wTliJilhSsIw4mh0RA+6J3lVozO9h4pyUq33sBz95ErBBCfDDdcxVMtnSFa8AWCdRYm0= X-MS-TrafficTypeDiagnostic: MWHPR14MB1661: X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1661;25:U7W53vMThSfiQsN/hq78WhTSbHDR0QbGwTrJTFWAA3CypOYL6K7UDHZVuzT6NLc2bstR8fzSw3/n/Fe+KgiUPzKduWBDuIOUUlj3WPyPCAZj/15PhszDgtrQSOuWNA0N24e3pxse3Qem/dYdjHYsYGunsPS8GMw3a40GvqNAikoPRUeVoRALqq5S/T17Rb+CPhLOe+1jCivdw+eTD7j2lgsf7u8hOWeNawrT9UU9d6IM3lC2k/pmQ5YF0e7O5EACgvwLf2bRfBwbvKui0RjMRrGoO/nUDMRzOYat/c/+NAyk+gn/DOPjOzaJU78GDLlEYgVLtzciZX4XUGUXdeTV+FLqv5TN5sEkZ5DGlIyyvqnPI7382xHnQuJEio8nd9QcgdCH5ypLQRw9PmP7iD6ngrPnuTqFru/3Vx+2mkBmKxjgT35b7+9/ckazwT+vfr44LyW7YEF4wxpFAthr8ko/h7CV2a3YtIM6GIjdkfdaa+GXGlXJDKgca7vqyqUCfvmx0frbbT9Z3+MlpRygTdluEZAtjlTxn1T3fxFQwJt+F3KWfg1z7bJw5pv63weQoTkY2HFV/EWbIWH8ucur1Utpi59Qw0R3Pxv+QUFKBiL5qg5pdGZoFmhAUE4KUwt9uxaaD98RdECsUwrXsvkfnzVWwYcj7LmBdFlbz5D43TIx44ErTf6vsxVQKLGohHPgyNYNfdWuywBP3JpS/LpyBwfTLnPIAH+Tng2nal/rLQvFR3h4k/qtA88bi6kyiOUhVhWDUnXcbmbytqlxnYH7U4hCAl+lPUZt05IGg1gnTrLg/98t3DoeVMcHzA7T0JNQBqnT1WjDTSFPWYBCdhyfq9k5lDyrpA+03PYLEcEjhc6vfnDOuuae/pee1WIrLmIRYaO7PU2BG1ib/B9C/3ICp3uAcAN11PZejWA1y6J6sQKf+Sc= X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1661;31:z7Uc5GUhSVLYlkVdNojlYP/FYTQi1wtjX87OpEHwvUz7S9/KBH8v+K6HkZrXVALF32kkMUl5lw2QMTsTtwWTOBo/g8l6sayjxkmgJcXk1sZT/n7/HdOQ70ZM9wEEnPaKn1aHrLn0F1NCBT5JE2irVEWUC6NcsGyxYm/o9M9B/oGzVpshaDPC4IeDf2ehLNAGngyELUME8ShJQA/4OWdc4cgScdQIhu40pSN8SYAFD89V48RbvU5GlcQSunZLq2r9psUEXC4tk13j3QYjS/tdLlkLYVAnOb1KiGgsgZ2A866KXXl7mbsGl0fEv2Gm/Gws9jMdCk1EXkUYbB0mAfKXmxYcbRMu6HEsbeZmweCh4/p80WgYMkZW+Kb1UpYVWZsJ41qCY19aD+ajfLUyv7FTd6FIcqeukE4igKLSVFnyzMnlFSmPfQgYu7oIHq/6bz/ykMkGD2mqzexFjcHOixMoUh33lmtS3SB5p8a1kfvHiV6DqC3tbL2O76WPv5Y2GdN07slq07r3umDcHNKU5w+lF4+vLcsEHjbPvkwySjetfN+8Ao7f3qSc19lQ3/qwVeItsICAQgN4dgBJdzxifSrBC336FDcuQB4Hh2FPRRIUoVukymY4A1x1di2JGe/cM1XMVT4f+BSznpimz1MwwJld2oV0bet0AiNW3eBCAqdlhu+FNdwNSm1QkqiVBqn37entrZuiUNFcHauv6Bx7kBJejA== X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1661;20:2MQuMEOkVq/2vQ3F3mvtExaVi/PJftkEQWRiX83N94NPQrzOy3lOC/xTpG6Oujt7pXjxbAwPS7zPCd+xRcn1ZHOtn0mbNMx56O76mR0Y+ljoO9XjSYkEkEri1RmIfrb/kbBwtcNb5YgOGMMNcwonoH8vYC+ADBOZcXnuVARF3ZcWMU8kGL67HXRP7D3gCbxIcVxlwpI/9WD6d1UdNJeByAUEQVwblNr/ErTzw67A/c7EhxUbbSoXA1jPmu4BVpyILyzJberYv9JSIaGh3xjs4cP4glpEmNKxz4Py8nefNrtysWVqhbHxVEs3GLRKAX00BBXWyY1vN9ReWaJy4ben3ngMcnl+C890vI1/81wVWzxXoWBs+3vwAE/QeJpaF31n/uooJDjYNYfROVOl4bcrPrPcbF1aRT3+FuEHPdJD/mxFtaVP9srTW1xpD7CC/TVtwm6yJEHZYNDOOz3PIcrh8B6Dzm8VoviUge7QRuEQ7V54XwWzZYtwCZRoXXYt3Kfm X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(133145235818549)(236129657087228)(48057245064654)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(601004)(2401047)(2017060910075)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6041248)(20161123558100)(201703131423075)(201702281529075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR14MB1661;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR14MB1661; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR14MB1661;4:QYQcEobyDP1Q1X2fsMQ6N6WHUj+8FZ7adPQQTVcCNv?= =?us-ascii?Q?I+wBPY/LlkWW0F8kRP6yshF8kVGoqSHZ6XCV9z4/u+RpDgyrllEwaaQO9qfD?= =?us-ascii?Q?rgjcsV15PPviCn631Kmy5B9lYJ6pgwkUr6VazZF+dXnaxDBuFAVbMnPlQtFe?= =?us-ascii?Q?EPymyAEtHeVe9SMFaCS6D26Zgo9HFjLTlUlH6G68W4jUggBUXqeqaWZUePcB?= =?us-ascii?Q?jEVvBv5L/so1/JMNEvy7lq7rUlrRFjpwm+S4bqaQHqjTU2gaWynHSrcPyNqk?= =?us-ascii?Q?E06WETKxQrlD5Qk0jiPyPh5b/F5jkhBLqeOZxkgoC4wqVLN5wV9aX1qaiWp7?= =?us-ascii?Q?rp/Sfq6ziBA2jhWrW/hjSa72ES7ZCwpNgBCnystdPf3OFCJccdbg2p0X85Hn?= =?us-ascii?Q?BV11IF7TWe8MeAD/bWWiAr16ziWaEtkf742P0TzaIlxRAATAVkla7Exg3Iqw?= =?us-ascii?Q?ociAz3GfYMUnO8DU9dZDVpEzf/Thav1WZA29G34nW1AkK9pKu1nPKWUTVnLo?= =?us-ascii?Q?1GKAPuA9HjQh60CFIFfF93927lLbDd+Jh2c/mCTimyM6eEWgrFkHnckny+Gr?= =?us-ascii?Q?raEur6eam4KRKOL9TEW0PRFn1LsefNwwdEW1qSr/nm5ASvo2wvANDeF67JQZ?= =?us-ascii?Q?cHCsdhRLBjAIBybO9Fz1fGhTydHBBJMlvbcaYpoCHMUXP1uDoUhplt/BtHD5?= =?us-ascii?Q?27sPDZip7lUBtIJxhNXUd42dI5bG2S3mC+ThnNb9E9cPAZ1RjjG39LGKv9et?= =?us-ascii?Q?fgyjcj5zbtdVYjmcRacEeVDFWtmi7dj9KNEvbtea7mJI69/j3PoBWf9XZk8u?= =?us-ascii?Q?vRvp/l3++geUIS2CC8qaHE7z77mtBgCjuRSkGPXlbQJlWurFT7eCI22Za42A?= =?us-ascii?Q?5qArBudboZEuGE8Er3ZZQL/pPChoANqW9GJ7sJxtBa3Tf07W8an5fIPd6mjq?= =?us-ascii?Q?qPoPhMgSVs9omZWaMLpwsjrwwgcNEyELkVV0cplNyQF/n3IYm+Y9xV+cU+o9?= =?us-ascii?Q?PLdmnOMRJlRxUem159rE144WdKR1I0VZuPWuj4E1h8LRclVohXBjGknFl0L0?= =?us-ascii?Q?N6rDTCY5+v9fwd/CgKXtbowyHspw6wDEv4XchbONXisvEM+XkG2lclyhNgGD?= =?us-ascii?Q?MXG3+zgrBhCzsEZYceCPzpxechx9mp1nfzvSReQDJVgeEeBp+wTPoyjsNHun?= =?us-ascii?Q?KgV4UyVymn9K2Ywoa0VxVC+sB/3g1LgfbmRyCCTeoqvJFUUpcJnTZqooJ+ih?= =?us-ascii?Q?h5Mf7Lz2FRignzD0zjamC/JmmLT5DCGcqIcLA/hVkZnedTQzvU+vXvt7jLNQ?= =?us-ascii?Q?wpMwHXFxnQRLiQ+O+qm2Pfz0GeTlqMSNp9+tdBhupZoiuaReAvD4VrZUZXlx?= =?us-ascii?Q?shE5xtZMTPZWe+sS2HFxNqV6SNiWEE4Y2K5IImGxfigwjt?= X-Forefront-PRVS: 0365C0E14B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(7370300001)(4630300001)(6009001)(6049001)(39840400002)(39850400002)(39400400002)(39450400003)(39410400002)(54534003)(24454002)(2906002)(50986999)(5890100001)(8676002)(33656002)(5660300001)(82746002)(83716003)(6246003)(53936002)(84326002)(88552002)(53546010)(54906002)(76176999)(7350300001)(75432002)(81166006)(7416002)(66066001)(42882006)(6916009)(2950100002)(478600001)(3846002)(77096006)(4326008)(6116002)(189998001)(6486002)(7736002)(229853002)(38730400002)(110136004)(86362001)(575784001)(50226002)(42186005)(25786009)(568964002)(305945005)(72826003);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR14MB1661;H:[172.27.35.170];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR14MB1661;23:5sY01bqGEhOFCHHhQGZAYPTqnXkJO4To2qQFomn4l?= =?us-ascii?Q?U0hEYM5vS1txsxx6p3OTxMHrc1cwsk5demifu4RxsZ3DDIjSXwmaluS+a42W?= =?us-ascii?Q?nvY+4cXclPtCMQcPGkb3w20dXLRHyGAuDte5Vt8JbnJ/ZpFdUO7YAs7tFask?= =?us-ascii?Q?bJbsrOnnAqAyaE9UAo3Ub7878lwgFwFctFimz1tjvVPxcpyTwTWsHug5I4QC?= =?us-ascii?Q?qwtg9mgh2raVC3siwXEjlE4UwM+IkUkyOql/qCn1z+pUFKlf8foWEPKuXpcW?= =?us-ascii?Q?LSru10SEfK12ve0K2dxJd76AqiuVgVQ33u31vzWVzvw16ENSvAPUme4COc02?= =?us-ascii?Q?ObbugOoG5sf69pK1QS3AGc3evpgKplcybZS3BKV1qTRETZ6NRGe8t8V/E79w?= =?us-ascii?Q?wcrGEUK9H/14tTo+khYKZQmudLCc9eDZpXct44yMjegPnEblRK1DeROTeLO0?= =?us-ascii?Q?tsAvktxDrPeyiFTJHYbAkYk7UCeaYGTYnPSzPohSBxwaisUYLslTO7X1aCGP?= =?us-ascii?Q?tk43Hlc7cn29DUcfIiiP+fY/oi7Ym7UctW8Rg3z5fTCfgeyUX2hkLBLxAPW8?= =?us-ascii?Q?0xkGaoiOPGAVFo7DAvU3XOLVE7VF3Pp/ihhh8YlpasYTdPD6IyZwqaiVU0aE?= =?us-ascii?Q?lm9YHVW99zKTj2xxjzKU2PxkFBYoAsG2TsvqOBCZx69zpUVfo34PdPjQAZv7?= =?us-ascii?Q?5RgSCgsHpXpEp72sX6ybu6yLRPd2L3ajo1pF21txyBFdSliW63h/c9pP8FHH?= =?us-ascii?Q?iSgT/W5vZ3HWQ/vEg2BaGaqWQgA7HXJTrwYBWP2r0S/SFfSUDsQf6X21/jIS?= =?us-ascii?Q?9rX8jUovUutCsCtSxS3p+fYA7BwqIrrMLEK8AVpaZSt/gUPJxM4vObYn/i3J?= =?us-ascii?Q?+F4OscowB2ZypShl+aiUYV2jr928K+SWQp8vJqhEXOB9aYUiUOuI5ILKovjp?= =?us-ascii?Q?lH2M7iN8eH4LBp4ytyABWQNFj8Crm/enySbRgUzFP+Stugf1U1tOQj4ldmTQ?= =?us-ascii?Q?gcsp1xM/s36bVzc4LYLClZDiibHjOddiWO6t0eojzhUls8kAuu2rPlW4dI84?= =?us-ascii?Q?sDlVE6iWPdH/ZXGuVgelqpGJCUGW2K2ajUIiDjdqXKg5Ebn3BIJpEWmBxlNN?= =?us-ascii?Q?FKeQ/e2ejmWdOAWN43i7p6J26OKde8YAKen0bz3tR7Dso0W5+JjCLD26Cx0N?= =?us-ascii?Q?zbPyvyeXB5RflHbsNThC0lU0/+bW5LYGESzvao9Zk7ASHYAP0N/SWPrw/4Im?= =?us-ascii?Q?Zng5HYo92HVngdDJ5Y/DICm5dcjMiWMKSy7uPCYIl0GzSTedR922OqdWo//q?= =?us-ascii?Q?HeTR+guhJBn2gOrVsodlu4=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR14MB1661;6:qZ8ZlVWz+LRDH2SXj/+F6BBWvKom7o/4fr6H+FiTKc?= =?us-ascii?Q?uLQVMMv+XeQEqjOub262OQ7weHEh8HyFfOnwQarMX/bX/fvz6esVpqWyYKJr?= =?us-ascii?Q?/MrJR6bJH3TnbV5fFiE5Yma1ImUz93PB2UEPAB7Q9xNDgzNwJMqT5iGRvxN3?= =?us-ascii?Q?4dqgQsQfJHG3v/aR6RWTYd9+09YOeNYYnFwBuu/hjrIa7NZ3tN3GNTedeJMW?= =?us-ascii?Q?xKcQem7FDWjn+D99QG4NLYadl6Czpd9/LFo/VUh/3zIgNRzztlDDshJG1znG?= =?us-ascii?Q?hPw/Neg9/qwQIQUCqS5HgZCZYcDIw0oDWxXXW9IiFKfHDwyNuLO430GBBvtN?= =?us-ascii?Q?pNx2zWwvy+m00F2MIpYQKyHkAWJpECr6j8KmCfiUR5DnmxSu/0v7kqnXhbBX?= =?us-ascii?Q?rUXaORqFNITC95A8iUihccmQ4R5d8yakvs+GL1UN1IU/sgzzC28aA9bWRfcr?= =?us-ascii?Q?eh0WrV2M+ptK4rTV6lQpy3LunQRTLtwrMDwVOvcnH6IsECmNpG6qo65Mct1J?= =?us-ascii?Q?yzELnenUEfSh7dYpPWjxc7ixp7Ihm6dbTKHbILrbDHMlP+G8d2jAT74s7dqL?= =?us-ascii?Q?4oJlCcGGmn32LmDFHwfmvaVtwFQzNnAkvO4pIz/VtwHPOfYOaSll9YcZJW/C?= =?us-ascii?Q?HjklVZ7u8e/ZTsQh6XCP9xiRY4guPKcvahAgdfNT/UbzlacfrbN82Osbj98v?= =?us-ascii?Q?+du1ewmH1RJPx1LpE0gxuunRIaxS9za/Cjly3ZkdDLitp8ZwMRHnPlWulN4X?= =?us-ascii?Q?hbFeo7OYAKy2wGvr2KauH2MIZBtS41S8zhkD0VtfGmoyGNnBa0k2CgNCJ7pf?= =?us-ascii?Q?OyrFy1TMzcfJ56aQo3ujYPpKfxnPx4MifTPscMK/F6DcT1eFNVX2O2bA5UKv?= =?us-ascii?Q?UnLx4GCFTIDD+ifN9glT6PL5K0LJ0c2N57bK473mjFbxA+HzrmvuqNlTiGd7?= =?us-ascii?Q?L/wKywMG0vWaKDmdSGfBeakMCFHODafLia88GH++5qlVZxYDh3zvPAtFYkSz?= =?us-ascii?Q?M=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1661;5:IHCHtwe3uvaEyIQMyEYp8D9f8aWdNu+7RChlhNVivSQaGadtVCi37yVy9ddgFtn8aWLu+qXU95WuqdYgdHg0BeyTwoGPmlr4XZHunT9o2Y9Hf9jf7uhE8533CbZddi0+Aw7vcvmbX4ngfTBjIU2c7We60d0Dsu+uyyguJXsERlEVPyY97akhWi5LVlhTQ+yom9A4jpJTI69sDbI6/nU7ZYeHYLi5S7KZmuTUENBdZjvsfA/SzUTclr+s4aPBc75hSG3pZZoOYy9WlpcqtaQfJPN7HBXtenlvK7agFAdPCftjPPf+ann5EITzK/2H0RblTd7INHmtMbNG5TC2jhTEqLBE1qi/k2LQfzWvZ0BJXs0Chb0s7X+Xtcd+saN239sLHeXtmZ9jB0hslxCjnrCqdrhqVecfqsAFq1eggoaPSAgYm5ch6jWhJql6YBcyldkGrDyue2aBrFX+03jao5hTJ55LNOnJj0IbQWMuf35FBvs6YBl7nH/kHQt1DT2PEm6x;24:4+TdMY1xAL4TshEw7PdfJ3Smly2xpIJ5wL9ZEnNKyp1AMgl3LnpMx4j3U9ofkvsefliH9TNQT/QiAS7YJ1lONNuHPXu/Iozd/7zjLzsOQi0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR14MB1661;7:VWqsyhIEosRhvhIRhyGWU0H9yyfobnBDh7oFevNytdIf0XldkoVC5bokOm5nYWra6S/A24OSy8sDCgG8pF5oNdqhdyyivOQO03RcHTvyHRvJ/WtwCHkZJESGuLeVGiOFkjemKb/wB4hwimqnd2awOOT1sa2pZYceO7L8US4Sf6ixGuFTpbolMoXKVIc75H+PTyEup52PTJmq594iS18dP/scWDwUxPeZi9LmjERmxU1urQ4BDBEaOebECyIk9B/diAsLC2gyPkCrQtUKTNJYezkfT00WLGq7vdb5UphWnLueenmAKbk/kS60CGHMkHycluH9QSgPkD1eLQ8879bkoAMGt+Gijc8jQM3LYAWkoNRFR6PtyMDjWDcB+kC5E+4CCK1cDyS05D7prf1qD5v6+VLPhOg4Vi7XrJSy3IYJ8dwjpOCYivGp3MNGjVGjxuJH7t4pqHPsI9oV2A+S/7Vky+oc9VvR+WTFCauP0a4MmlVffio6+WRSNFNw20u8GsROOgvXmqDcqkFbDZ1QKFFwlq/FzQHTcP+Z4eJaFF1QnHXkjecTSvU0jNh7wtpL9GU9b+pY1Js/NqewnpSMycocNjYm11qjKknAHZZbpCNd2cQMSJv+6rPzFKLGgXK8TWhE3t8CQIGLprebJ/Ip6EWCQr+eJDobTvLRsY4MaIUxxj2/yeEbhk1XMg6ydi338SPe9n2GsRXnyYXPB+uc4kI9MJLcOz5B+FX+8qFsMopkcPylO/xsCt4D373KpKWEUUroFTFopL6WjNC5QaWxGKcuH/tINQnopX6Xu4xY16CBVRc= X-OriginatorOrg: cs.rutgers.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2017 14:00:31.9298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR14MB1661 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 3156 and 4880). --=_MailMate_8804FA40-CC25-4A55-BF3B-6B4A404F8436_= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 11 Jul 2017, at 2:47, Naoya Horiguchi wrote: > On Sat, Jul 01, 2017 at 09:40:03AM -0400, Zi Yan wrote: >> From: Zi Yan >> >> This patch adds thp migration's core code, including conversions >> between a PMD entry and a swap entry, setting PMD migration entry, >> removing PMD migration entry, and waiting on PMD migration entries. >> >> This patch makes it possible to support thp migration. >> If you fail to allocate a destination page as a thp, you just split >> the source thp as we do now, and then enter the normal page migration.= >> If you succeed to allocate destination thp, you enter thp migration. >> Subsequent patches actually enable thp migration for each caller of >> page migration by allowing its get_new_page() callback to >> allocate thps. >> >> ChangeLog v1 -> v2: >> - support pte-mapped thp, doubly-mapped thp >> >> Signed-off-by: Naoya Horiguchi >> >> ChangeLog v2 -> v3: >> - use page_vma_mapped_walk() >> - use pmdp_huge_clear_flush() instead of pmdp_huge_get_and_clear() in >> set_pmd_migration_entry() >> >> ChangeLog v3 -> v4: >> - factor out the code of removing pte pgtable page in zap_huge_pmd() >> >> ChangeLog v4 -> v5: >> - remove unnecessary PTE-mapped THP code in remove_migration_pmd() >> and set_pmd_migration_entry() >> - restructure the code in zap_huge_pmd() to avoid factoring out >> the pte pgtable page code >> - in zap_huge_pmd(), check that PMD swap entries are migration entries= >> - change author information >> >> ChangeLog v5 -> v7 >> - use macro to disable the code when thp migration is not enabled >> >> ChangeLog v7 -> v8 >> - use IS_ENABLED instead of macro to make code look clean in >> zap_huge_pmd() and page_vma_mapped_walk() >> - remove BUILD_BUG() in pmd_to_swp_entry() and swp_entry_to_pmd() to >> avoid compilation error >> - rename variable 'migration' to 'flush_needed' and invert the logic i= n >> zap_huge_pmd() to make code more descriptive >> - use pmdp_invalidate() in set_pmd_migration_entry() to avoid race >> with MADV_DONTNEED >> - remove unnecessary tlb flush in remove_migration_pmd() >> - add the missing migration flag check in page_vma_mapped_walk() >> >> Signed-off-by: Zi Yan >> Cc: Kirill A. Shutemov >> --- >> arch/x86/include/asm/pgtable_64.h | 2 + >> include/linux/swapops.h | 67 ++++++++++++++++++++++++++++++= - >> mm/huge_memory.c | 84 ++++++++++++++++++++++++++++++= ++++++--- >> mm/migrate.c | 32 ++++++++++++++- >> mm/page_vma_mapped.c | 18 +++++++-- >> mm/pgtable-generic.c | 3 +- >> mm/rmap.c | 13 ++++++ >> 7 files changed, 207 insertions(+), 12 deletions(-) >> > ... > >> diff --git a/mm/rmap.c b/mm/rmap.c >> index 91948fbbb0bb..b28f633cd569 100644 >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -1302,6 +1302,7 @@ static bool try_to_unmap_one(struct page *page, = struct vm_area_struct *vma, >> bool ret =3D true; >> enum ttu_flags flags =3D (enum ttu_flags)arg; >> >> + >> /* munlock has nothing to gain from examining un-locked vmas */ >> if ((flags & TTU_MUNLOCK) && !(vma->vm_flags & VM_LOCKED)) >> return true; >> @@ -1312,6 +1313,18 @@ static bool try_to_unmap_one(struct page *page,= struct vm_area_struct *vma, >> } >> >> while (page_vma_mapped_walk(&pvmw)) { >> +#ifdef CONFIG_ARCH_ENABLE_THP_MIGRATION >> + /* PMD-mapped THP migration entry */ >> + if (flags & TTU_MIGRATION) { > > My testing based on mmotm-2017-07-06-16-18 showed that migrating shmem = thp > caused kernel crash. I don't think this is critical because that case i= s > just not-prepared yet. So in order to avoid the crash, please add > PageAnon(page) check here. This makes shmem thp migration just fail. > > + if (!PageAnon(page)) > + continue; > Thanks for your testing. I will add this check in my next version. >> + if (!pvmw.pte && page) { > > Just from curiosity, do we really need this page check? > try_to_unmap() always passes down the parameter 'page' to try_to_unmap_= one() > via rmap_walk_* family, so I think we can assume page is always non-NUL= L. You are right. Checking page is not necessary here. I will remove it in m= y next version. -- Best Regards Yan Zi --=_MailMate_8804FA40-CC25-4A55-BF3B-6B4A404F8436_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJZZNn+AAoJEEGLLxGcTqbMMv0IAJAb91WfGug4UFMxLmIs5rCV Wkq5adDVyRLYJ1MGqip/AfkPkT0aQjQD3xW40JxW1z3FrsJ6X5HZksh9kLCUvu9W OTjJ0Fj94n67sP7pt1gYUwTLZ3Rga5v9fBc7g0kKa58g2BPdaXZCLpqjV1X8mIW9 X5bAVPvoDZ903850ncykP3u08PKvtf4MEFtixK/TUe8XO+MDACR14g5CfPjYYoI0 DrhA9VDB7o2Eg/0GqNHDN36/Vs5e/mOOQ9UkuaV9ZQrKCMLhi1P9jVVEwBFBsZmi 2I03ke2KsLneK1dXrw41NndD4jvsmazCIpGP25/6KuCCI0mQ7MRp5D1ztplJBzc= =eW63 -----END PGP SIGNATURE----- --=_MailMate_8804FA40-CC25-4A55-BF3B-6B4A404F8436_=--