From: Zach Brown <zach.brown@oracle.com>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "'Andrew Morton'" <akpm@osdl.org>, <linux-aio@kvack.org>,
<linux-kernel@vger.kernel.org>,
"'Benjamin LaHaise'" <bcrl@kvack.org>, <suparna@in.ibm.com>
Subject: Re: [patch] aio: make aio_ring_info->nr_pages an unsigned int
Date: Tue, 2 Jan 2007 17:14:16 -0800 [thread overview]
Message-ID: <F7E6E752-C6CE-4A89-A716-3C7367EF1FF8@oracle.com> (raw)
In-Reply-To: <000501c72bc0$d286bff0$d634030a@amr.corp.intel.com>
> --- ./include/linux/aio.h.orig 2006-12-24 22:31:55.000000000 -0800
> +++ ./include/linux/aio.h 2006-12-24 22:41:28.000000000 -0800
> @@ -165,7 +165,7 @@ struct aio_ring_info {
>
> struct page **ring_pages;
> spinlock_t ring_lock;
> - long nr_pages;
> + unsigned nr_pages;
>
> unsigned nr, tail;
>
>
Hmm.
This seems so trivial as to not be worth it. It'd be more compelling
if it was more thorough -- doing things like updating the 'long i'
iterators that a feww have over ->nr_pages. That kind of thing.
Giving some confidence that the references of ->nr_pages were audited.
- z
next prev parent reply other threads:[~2007-01-03 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-30 3:15 Chen, Kenneth W
2007-01-03 1:14 ` Zach Brown [this message]
2007-01-03 1:23 ` Chen, Kenneth W
2007-01-03 1:25 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F7E6E752-C6CE-4A89-A716-3C7367EF1FF8@oracle.com \
--to=zach.brown@oracle.com \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®