From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752022AbdJ3AwY (ORCPT ); Sun, 29 Oct 2017 20:52:24 -0400 Received: from mail-bl2nam02on0137.outbound.protection.outlook.com ([104.47.38.137]:12911 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751935AbdJ3AwX (ORCPT ); Sun, 29 Oct 2017 20:52:23 -0400 From: "Stephen Bates" To: Daniel Mentz CC: Jonathan Corbet , Mathieu Desnoyers , Andrew Morton , Will Deacon , lkml , "logang@deltatee.com" Subject: Re: [PATCH v2] genalloc: Make the avail variable an atomic_long_t Thread-Topic: [PATCH v2] genalloc: Make the avail variable an atomic_long_t Thread-Index: AQHTTnQVRdFiLPp0YEWoaLHptbDT3KL4JpCAgANvNQA= Date: Mon, 30 Oct 2017 00:52:21 +0000 Message-ID: References: <1509033843-25667-1-git-send-email-sbates@raithlin.com> In-Reply-To: Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/f.27.0.171010 authentication-results: spf=none (sender IP is ) smtp.mailfrom=sbates@raithlin.com; x-originating-ip: [70.65.224.121] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;YTXPR0101MB2046;6:RYt+7tLJEW/J481sB5EKxd0ZfTiIN01NYAmzYZYunwD9m+EUhJBxXNvutmH3KlpeYIUPjwCoPpOih06smX4AaGcsFbzyFGPlx80Ibv4WNAd/6ua3w4JfyTKsWp91lV8wCuzFGDd+sZSRpNEyYfHXf915gaBE8Qj+Mz4H2WgtHsoDCNEgfZWGLMaSAHURT1v6nJgtcLVkhPsKW5XKLemD25OMfZR7FMWYlsHH3L6M6h57FGQidRuCFEhHCrQ3I+WbyIBAnPrYRuyNkvUgC8Uq96SoNHMI2mIoKteg0k9uuIrhgO+OMl0/c/JnRe0WP1opGhMdNJr4R8O+gmPLE3SgHqk3EQpI4Yskukxgw9h3mw0=;5:ynDq2g0jR2S3FbG/GHBwG1MKgAPcfU5Tka6h7DN43dBgHIgp1pJrWls+zbWNWWy+ONWFf+FTpWfixe9rACqF/urhwidCp7WvQjIypsxYZ1APlvGbeNnt6zh4vUSNtMHiW/C49FYZ/wAcNT4yM4cqQuYHOXC0lhN/KLY3MkeskFI=;24:CFe6foPBMzQpaT5shcuxjPmto86A/VSRCONiSdLFLFU5sXZ0IfJnDz49u9MbfkspO9Pc0LdcEgkKbxWKIyrOzErY0qAWuTQrE7lDQsiqBKk=;7:k4hAPSXyplv5GCzByvt/7fzoLElYGsW6o7I3WlARc7BByQ2ze+WzkLQp9LK0K/cbWK7mpnZ6cyYxLw6bko+xuNgsq8JGLzT5VuJYZraBkzRAvfiFibT58eAO7UknUtioDhBzkETpILQrmIxcdDa7HQ9CEmyXBD1zoywQe5ncJNzRgqbijWgtuarB8F++2K16VrPwY3CaK7+pPNeEhXJ9M6NcGGZoKyjHJAclwSW/zjF8Ukkj/viLGQCTu5ihqgTn x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: d0a1116c-fdba-4233-a7d5-08d51f307a4d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4603075)(2017052603199);SRVR:YTXPR0101MB2046; x-ms-traffictypediagnostic: YTXPR0101MB2046: x-exchange-antispam-report-test: UriScan:(211936372134217); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3231020)(3002001)(920507026)(6041248)(20161123555025)(20161123560025)(20161123558100)(20161123562025)(201703131423075)(201703061421075)(2016111802025)(20161123564025)(6043046)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:YTXPR0101MB2046;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:YTXPR0101MB2046; x-forefront-prvs: 0476D4AB88 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(189002)(199003)(51914003)(508600001)(3280700002)(3660700001)(83506002)(76176999)(54356999)(2950100002)(50986999)(2906002)(6916009)(53936002)(8676002)(81166006)(6512007)(6116002)(3846002)(25786009)(81156014)(6246003)(33656002)(102836003)(36756003)(105586002)(106356001)(14454004)(5660300001)(34040400001)(68736007)(4326008)(2900100001)(8936002)(6436002)(101416001)(82746002)(305945005)(66066001)(6506006)(83716003)(58126008)(54906003)(229853002)(86362001)(5250100002)(97736004)(189998001)(7736002)(6486002);DIR:OUT;SFP:1102;SCL:1;SRVR:YTXPR0101MB2046;H:YTXPR0101MB2045.CANPRD01.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: raithlin.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0a1116c-fdba-4233-a7d5-08d51f307a4d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2017 00:52:21.2656 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 18519031-7ff4-4cbb-bbcb-c3252d330f4b X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTXPR0101MB2046 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9U0qVdx019428 > Do we still need #include ? For me, it compiles without it. Yes we do. Kbuild reported a failure when I tried omitting it (arm-multi_v7_defconfig). > Reviewed-by: Daniel Mentz danielmentz@google.com Thanks for the review Andrew can you look at picking this up or do you want me to respin with that tags from Daniel and Mathieu applied? Stephen