mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
	Alex Lu <alex_lu@realsil.com.cn>,
	pkshih@realtek.com, linux-bluetooth@vger.kernel.or,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: btusb: Disable runtime suspend on Realtek devices
Date: Thu, 5 Dec 2019 10:32:19 +0100	[thread overview]
Message-ID: <F8377E2D-EB26-4AF4-83B2-A7903C4A4D2D@holtmann.org> (raw)
In-Reply-To: <20191205090701.12440-1-kai.heng.feng@canonical.com>

Hi Kai-Heng,

> After commit 9e45524a0111 ("Bluetooth: btusb: Fix suspend issue for
> Realtek devices") both WiFi and Bluetooth stop working after reboot:
> [   34.322617] usb 1-8: reset full-speed USB device number 3 using xhci_hcd
> [   34.450401] usb 1-8: device descriptor read/64, error -71
> [   34.694375] usb 1-8: device descriptor read/64, error -71
> ...
> [   44.599111] rtw_pci 0000:02:00.0: failed to poll offset=0x5 mask=0x3 value=0x0
> [   44.599113] rtw_pci 0000:02:00.0: mac power on failed
> [   44.599114] rtw_pci 0000:02:00.0: failed to power on mac
> [   44.599114] rtw_pci 0000:02:00.0: leave idle state failed
> [   44.599492] rtw_pci 0000:02:00.0: failed to leave ips state
> [   44.599493] rtw_pci 0000:02:00.0: failed to leave idle state
> 
> That commit removed USB_QUIRK_RESET_RESUME, which not only resets the USB
> device after resume, it also prevents the device from being runtime
> suspended by USB core. My experiment shows if the Realtek btusb device
> ever runtime suspends once, the entire wireless module becomes useless
> after reboot.
> 
> So let's explicitly disable runtime suspend on Realtek btusb device for
> now.
> 
> Fixes: 9e45524a0111 ("Bluetooth: btusb: Fix suspend issue for Realtek devices")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> drivers/bluetooth/btusb.c | 4 ++++
> 1 file changed, 4 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel


      reply	other threads:[~2019-12-05  9:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05  9:07 Kai-Heng Feng
2019-12-05  9:32 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F8377E2D-EB26-4AF4-83B2-A7903C4A4D2D@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=alex_lu@realsil.com.cn \
    --cc=johan.hedberg@gmail.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-bluetooth@vger.kernel.or \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®