From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C77D41C6A for ; Thu, 13 Feb 2025 10:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739443812; cv=none; b=hqkdNykfpK+1QzpO0qyDYygn5pPPhHew26Hl8bj7YMCrMS0JMc7+YxTBZvx3ly0ArGxWR5jQHxKFuBvHkAU47VabWdGRdAJWCgGJMdgr2/D67LZ2ma3r91ROuM4lXQj+NLgXT8V5/rltct/nv3C7XFIRTqaIL8lubN6g+ICP+Y0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739443812; c=relaxed/simple; bh=PZldEN6Abj+iXjTpspjBtDYDXPhcFFE2GIltlBfsO/w=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=KnHNFt2htpvy+w8fC5JZRAAsDGRPRtGKoz8P46p+ojVPer9iDYLVxpbTGVNeiII0mXU35tzLm5942U+wnfjp7tIo87B9ns2Nd0LWGz0Apv6RCleddfGkN0GslYjnUKqXZYG84bcwt2ZHRkPgOGWdQmrsfDlnM6PrT7LxltGS05Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=mjzdBwKX; arc=none smtp.client-ip=91.218.175.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="mjzdBwKX" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1739443798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PZldEN6Abj+iXjTpspjBtDYDXPhcFFE2GIltlBfsO/w=; b=mjzdBwKXjH97PHuJxlrFYl9NA4VqpM+GHmQl0XhlHLn82l4KtFXVZNKx1YkSpjao357yJN BdSs+mQcmyFRYpt7nyH5nlemg51obctsp+ED9ANbZo4kwWdVv/MMA1YTXmA/4OXjkAciDz bE7d2qjq+medOvjwao3I0MqwQNKws0A= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\)) Subject: Re: [PATCH net-next] sctp: Remove commented out code X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum In-Reply-To: <20250212195747.198419a3@kernel.org> Date: Thu, 13 Feb 2025 11:49:45 +0100 Cc: Mateusz Polchlopek , Marcelo Ricardo Leitner , Xin Long , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20250211102057.587182-1-thorsten.blum@linux.dev> <6F08E5F2-761F-4593-9FEB-173ECF18CC71@linux.dev> <2c8985fa-4378-4aa2-a56d-c3ca04e8c74c@intel.com> <20250212195747.198419a3@kernel.org> To: Jakub Kicinski X-Migadu-Flow: FLOW_OUT Hi Jakub, > On 13. Feb 2025, at 04:57, Jakub Kicinski wrote: > On Tue, 11 Feb 2025 12:33:57 +0100 Mateusz Polchlopek wrote: >>>> I don't think we want to remove that piece of code, please refer >>>> to the discussion under the link: >>>>=20 >>>> = https://lore.kernel.org/netdev/cover.1681917361.git.lucien.xin@gmail.com/ = =20 >>>=20 >>> Hm, the commit message (dbda0fba7a14) says payload was deleted = because >>> "the member is not even used anywhere," but it was just commented = out. >>> In the cover letter it then explains that "deleted" actually means >>> "commented out." >>>=20 >>> However, I can't follow the reasoning in the cover letter either: >>>=20 >>> "Note that instead of completely deleting it, we just leave it as a >>> comment in the struct, signalling to the reader that we do expect >>> such variable parameters over there, as Marcelo suggested." >>>=20 >>> Where do I find Marcelo's suggestion and the "variable parameters = over >>> there?" >>>=20 >>=20 >> That's good question, I can't find the Marcelo suggestion that author >> mention. It's hard to find without links to previous series or >> discussion :/ >>=20 >> I guess it should be also commented by maintainers, I see that in the >> Xin's thread Kuba also commented change with commenting out instead >> of removing code. Let's wait >=20 > In the linked thread the point was to document what struct will be = next > in memory. Here we'd be leaving an array of u8s which isn't very > informative. I see there's precedent in this file, but I vote we just > delete the line. This patch deletes the line and I'm wondering why the "cr"? Were you referring to this patch maybe? = https://lore.kernel.org/r/20250114215439.916207-3-thorsten.blum@linux.dev/= Should both payload fields just be deleted since they're not used? Thanks, Thorsten=