From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 488A5C4332E for ; Wed, 6 Jan 2021 07:51:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB65223105 for ; Wed, 6 Jan 2021 07:51:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbhAFHvC convert rfc822-to-8bit (ORCPT ); Wed, 6 Jan 2021 02:51:02 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:41965 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726516AbhAFHvC (ORCPT ); Wed, 6 Jan 2021 02:51:02 -0500 Received: from marcel-macbook.holtmann.net (p5b3d23d0.dip0.t-ipconnect.de [91.61.35.208]) by mail.holtmann.org (Postfix) with ESMTPSA id 9FFDECED13; Wed, 6 Jan 2021 08:57:40 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: [PATCH] Bluetooth: hci_qca: Fix memleak in qca_controller_memdump From: Marcel Holtmann In-Reply-To: <20210102054755.21069-1-dinghao.liu@zju.edu.cn> Date: Wed, 6 Jan 2021 08:50:19 +0100 Cc: kjlu@umn.edu, Johan Hedberg , Luiz Augusto von Dentz , Venkata Lakshmi Narayana Gubba , Balakrishna Godavarthi , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20210102054755.21069-1-dinghao.liu@zju.edu.cn> To: Dinghao Liu X-Mailer: Apple Mail (2.3654.40.0.2.32) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dinghao, > When __le32_to_cpu() fails, qca_memdump should be freed > just like when vmalloc() fails. > > Fixes: d841502c79e3f ("Bluetooth: hci_qca: Collect controller memory dump during SSR") > Signed-off-by: Dinghao Liu > --- > drivers/bluetooth/hci_qca.c | 2 ++ > 1 file changed, 2 insertions(+) patch has been to bluetooth-next tree. Regards Marcel