mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xinghui Li <korantwork@gmail.com>
To: kernel test robot <lkp@intel.com>, <axboe@kernel.dk>,
	Pavel Begunkov <asml.silence@gmail.com>
Cc: <llvm@lists.linux.dev>, <oe-kbuild-all@lists.linux.dev>,
	<io-uring@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] io_uring: fix two assignments in if conditions
Date: Wed, 02 Nov 2022 16:06:37 +0800	[thread overview]
Message-ID: <F8C3CD1A-A2C0-4772-8AB6-2F2ED04A9F76@gmail.com> (raw)
In-Reply-To: <202211012335.tCnMjA6q-lkp@intel.com>



在 2022/11/1 23:10,“kernel test robot”<lkp@intel.com> 写入:

>    Hi,
>
>    Thank you for the patch! Perhaps something to improve:
>
>	......
>    If you fix the issue, kindly add following tag where applicable
>    | Reported-by: kernel test robot <lkp@intel.com>
>
>    All warnings (new ones prefixed by >>):
>
>    >> io_uring/poll.c:601:7: warning: variable 'apoll' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>                       if (entry != NULL)
>                           ^~~~~~~~~~~~~
>       io_uring/poll.c:608:2: note: uninitialized use occurs here
>               apoll->double_poll = NULL;
>               ^~~~~
>       io_uring/poll.c:601:3: note: remove the 'if' if its condition is always true
>                       if (entry != NULL)
>                       ^~~~~~~~~~~~~~~~~~
>       io_uring/poll.c:594:26: note: initialize the variable 'apoll' to silence this warning
>               struct async_poll *apoll;
>                                       ^
>                                        = NULL
>       1 warning generated. 
>
>
>    vim +601 io_uring/poll.c
>
It is do a problem, I will sent v2.
Thanks a lot!
    -- 
    0-DAY CI Kernel Test Service
    https://01.org/lkp



      reply	other threads:[~2022-11-02  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01  7:29 korantwork
2022-11-01 15:09 ` kernel test robot
2022-11-02  8:06   ` Xinghui Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F8C3CD1A-A2C0-4772-8AB6-2F2ED04A9F76@gmail.com \
    --to=korantwork@gmail.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®