From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933304AbbFJHT2 (ORCPT ); Wed, 10 Jun 2015 03:19:28 -0400 Received: from linuxhacker.ru ([217.76.32.60]:41520 "EHLO fiona.linuxhacker.ru" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932075AbbFJHTX (ORCPT ); Wed, 10 Jun 2015 03:19:23 -0400 Subject: Re: [PATCH 1/2] staging/lustre/llite: remove LL_IOC_REMOVE_ENTRY handler Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Oleg Drokin In-Reply-To: <20150610070805.GC7035@sudip-PC> Date: Wed, 10 Jun 2015 03:19:10 -0400 Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List Content-Transfer-Encoding: 7bit Message-Id: References: <1433911283-24902-1-git-send-email-green@linuxhacker.ru> <1433911283-24902-2-git-send-email-green@linuxhacker.ru> <20150610070805.GC7035@sudip-PC> To: Sudip Mukherjee X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 10, 2015, at 3:08 AM, Sudip Mukherjee wrote: > On Wed, Jun 10, 2015 at 12:41:22AM -0400, green@linuxhacker.ru wrote: >> From: Oleg Drokin >> >> It uses getname in unsafe manner and since it's to deal with corrupted >> or inconsistent filesystem, we are probably better to deal with >> it from lfsck anyway. > I am not sure but will it not break the userspace? There may be some > application who is using this ioctl. This is an ioctl for a relatively new "distributed namespace" feature. Our lustre control tool uses it in order to get rid of presumed incorrect entries that don't point anywhere. But in fact that's pretty risky and I am of the opinion this is best left to fsck to decide, it's too easy to create nameless directories otherwise (and even if we only allow sysadmin to do this, it's still not all that great of an idea). > And I think you missed removing the #define LL_IOC_REMOVE_ENTRY from > lustre_user.h which will not be used anymore. Good point. Thanks. Bye, Oleg