From: Variksla <variksla@gmail.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: bjorn@mork.no, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, jikos@kernel.org,
linux-usb@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
balbi@ti.com, eu@felipetonello.com, k.opasiak@samsung.com
Subject: Re: f_hid.c conversion to the new function interface and crash due to race
Date: Wed, 9 Aug 2017 08:10:59 -0700 [thread overview]
Message-ID: <F9CD614C-2D81-4024-99EA-B3BD6F640916@gmail.com> (raw)
In-Reply-To: <87a8399i9b.fsf@linux.intel.com>
> On Aug 9, 2017, at 2:56 AM, Felipe Balbi <felipe.balbi@linux.intel.com> wrote:
Thanks for replying.
>
>
> Hi,
>
> noman pouigt <variksla@gmail.com> writes:
>> Hello,
>>
>> I am currently using 3.18 linux kernel and getting below
>
> return -EKERNELTOOOLD;
>
> Sorry, you're on your own. You should ask for support from whoever
> forces you to use 3.18 kernel.
I have updated f_hid.c file to latest kernel though as I knew it would be too much to ask to get support for old code.
I am just not sure about how to instantiate the function driver as earlier f_fs was instantiating the hid driver. However, after hid got converted to new function driver who is responsible for calling setup, bind and unbind functions in f_hid.c ?
Below is the glue code in android.c.
drivers/usb/gadget/android.c
static struct android_usb_function hid_function = {
.name = "hid",
.init = hid_function_init,
.cleanup = hid_function_cleanup,
.bind_config = hid_function_bind_config,
.attributes = hid_function_attributes,
};
Is there something similar in new function driver in upstream kernel?
>
> --
> balbi
next prev parent reply other threads:[~2017-08-09 15:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 8:40 noman pouigt
2017-08-09 9:56 ` Felipe Balbi
2017-08-09 15:10 ` Variksla [this message]
2017-08-10 9:02 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F9CD614C-2D81-4024-99EA-B3BD6F640916@gmail.com \
--to=variksla@gmail.com \
--cc=balbi@ti.com \
--cc=bjorn@mork.no \
--cc=eu@felipetonello.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=k.opasiak@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®