From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754517Ab0EPM7M (ORCPT ); Sun, 16 May 2010 08:59:12 -0400 Received: from ns1.co-raid.com ([12.51.113.4]:34893 "EHLO coraid.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754479Ab0EPM7H (ORCPT ); Sun, 16 May 2010 08:59:07 -0400 X-Greylist: delayed 965 seconds by postgrey-1.27 at vger.kernel.org; Sun, 16 May 2010 08:59:07 EDT Subject: Re: [PATCH 35/37] drivers/block/aoe: Use kmemdup Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Ed Cashin In-Reply-To: Date: Sun, 16 May 2010 08:42:59 -0400 Cc: kernel-janitors@vger.kernel.org, Julia Lawall Content-Transfer-Encoding: 7bit Message-Id: References: To: linux-kernel@vger.kernel.org X-Mailer: Apple Mail (2.1078) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 15, 2010, at 5:23 PM, Julia Lawall wrote: > From: Julia Lawall > > Use kmemdup when some other buffer is immediately copied into the > allocated region. I have seen this patch but have no comment about it specifically. (Because the argument about whether this kind of change adds value in general has already taken place. I'd say no, but that's based on a maybe faulty idea that if folks weren't doing this they'd have more time for reviewing patches, etc.) -- Ed Cashin ecashin@coraid.com