From: Kumar Gala <galak@codeaurora.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Rohit Vaswani <rvaswani@codeaurora.org>,
Olof Johansson <olof@lixom.net>,
David Brown <davidb@codeaurora.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ian.campbell@citrix.com>,
Russell King <linux@arm.linux.org.uk>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard
Date: Mon, 9 Sep 2013 14:48:08 -0500 [thread overview]
Message-ID: <FA33E8F4-3F85-4D8B-83E1-96F5A8F76CE6@codeaurora.org> (raw)
In-Reply-To: <522E21A8.4060408@wwwdotorg.org>
On Sep 9, 2013, at 2:29 PM, Stephen Warren wrote:
> On 09/09/2013 01:17 PM, Kumar Gala wrote:
>>
>> On Sep 9, 2013, at 12:48 PM, Rohit Vaswani wrote:
>>
>>> On 9/6/2013 2:50 PM, Olof Johansson wrote:
>>>> Hi,
>>>>
>>>> Some comments below.
>>>>
>>>> On Fri, Sep 06, 2013 at 12:32:22PM -0700, Rohit Vaswani wrote:
>>>>> This patch adds basic board support for APQ8074 Dragonboard
>>>>> <snip>
>>>>> dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
>>>>> - msm8960-cdp.dtb
>>>>> + msm8960-cdp.dtb \
>>>>> + apq8074-dragonboard.dtb
>>>> Please add boards alphabetically.
>>> Will do.
>>>>
>>>>> dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
>>>>> armada-370-mirabox.dtb \
>>>>> armada-370-rd.dtb \
>>>>> diff --git a/arch/arm/boot/dts/apq8074-dragonboard.dts b/arch/arm/boot/dts/apq8074-dragonboard.dts
>>>>> new file mode 100644
>>>>> index 0000000..5b7b6a0
>>>>> --- /dev/null
>>>>> +++ b/arch/arm/boot/dts/apq8074-dragonboard.dts
>>>> arch/arm/boot/dts/ is getting really crowded. It's been working best if the SoC
>>>> family or vendor is used as a prefix to keep things a bit more organized. In
>>>> that spirit, prefixing these with msm-<foo> makes sense. Can you please do so?
>>>
>>> Sure. But the board is called an APQ8074 and we wanted to keep the naming consistent with that.
>>
>> If we do this we should use qcom, not msm as the prefix. Match the device tree vendor prefix.
>
> Hmm. It'd be nice for the filenames to be ${soc}-${board} so that e.g.
> U-Boot can easily calculate the DTB filename based on its soc/board
> environment variables... Luckily in my case for Tegra, all the Tegra
> chip names start with "Tegra", so we already sort all our DTB filenames
> together in the directory listing:-)
u-boot's not supported on MSM platforms, so not sure what purpose this serves.
we might want to just introduce vendor dirs so its arch/arm/boot/dts/{vendor}/{soc}-{board}
Not sure if we want to argue about {vendor} vs {sub-arch}.
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2013-09-09 19:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 19:32 Rohit Vaswani
2013-09-06 19:53 ` Josh Cartwright
2013-09-06 20:31 ` [PATCH] ARM: msm: Remove irqs-*.h files for DT based targets Stephen Boyd
2013-09-06 20:50 ` Stephen Boyd
2013-09-06 20:55 ` Josh Cartwright
2013-09-06 21:50 ` [PATCHv3 1/2] ARM: msm: Add support for APQ8074 Dragonboard Olof Johansson
2013-09-09 17:48 ` Rohit Vaswani
2013-09-09 19:17 ` Kumar Gala
2013-09-09 19:29 ` Stephen Warren
2013-09-09 19:48 ` Kumar Gala [this message]
2013-09-09 21:21 ` Stephen Warren
2013-09-09 21:25 ` Kumar Gala
2013-09-09 21:42 ` Rohit Vaswani
2013-09-09 22:04 ` Kumar Gala
2013-09-09 22:30 ` Rohit Vaswani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FA33E8F4-3F85-4D8B-83E1-96F5A8F76CE6@codeaurora.org \
--to=galak@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dwalker@fifo99.com \
--cc=ian.campbell@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rvaswani@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®