From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012027.outbound.protection.outlook.com [52.101.43.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69AA3282F23; Tue, 7 Apr 2026 14:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.27 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775573094; cv=fail; b=rH9orv4/FBMq4wgj9ByJKi1QxBnGgbVzt9N1+nYRSSHLBI7yMutqpKsy7H7ApFni/YzjO0SrwJdkaSU1lQwzjej3Bhb6GW+DrwCft1FCCm8MtncJlJhrUJSGpmH0kOYYxyA6wX4PVe0y8Hx6I7ttRAKHi7W8LHZbTi9MfIlDSQI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775573094; c=relaxed/simple; bh=X4BETYS1P12w+qgWDmHZdSDA3LoBCwhROTb0Nocy/iY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=WrWkNrLs6wq0i2MjQo4pwM9+JdrkujyE9QbYp6Ka8sMhALA5rPWtdvtYE6f2iH3xu/Hn8hHjqqsSYgNf//HCQdploL/Yy0qcWzBC0popAOrKLTfhifYeqH+OqUjV3m6gLEvUKlv1z8iNKBgBe0yT7jMByqwdzsL4mIlCmvLvJeg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=pZ5gg2ri; arc=fail smtp.client-ip=52.101.43.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="pZ5gg2ri" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pf1gSbAJfcNsMUqMRyJwKvyIp3zd4/3PKwXglvgkMJxBlz5as42HeWzAVJIN+S9pifgfLz5BcJbjhnVrZIuMjy6+nycaw/E5RaCdeU3mGte2PsJrEgnx8s9BEtsAa/klyxyWOK//NtQxH587d3Wr+bfN6NwTv0vavuKChH4cruenOLWD/iwqm965kpnQkIIMbjrzAeS20zckQ1QFBgpv4O6MuzkVi0pW9CsyeZ5jw+xnAm2/mvgWUhmR54yKYBV8FFWfFFlmYiXbLoK9pSGx23uZpdHEyrboeHvGF7CyU27NOJ4tXzSnB/F6Jn7NdzzmShyqcjQReBQDkSZtfyuEdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0AyxYpaTmDQUl5fMruHff6ifX3Oan0fPaFJ4TlPicfQ=; b=eeH8dqqTquMkViBW6vKMw4RJBYrdcDUp3YiCvseMlJYRILbXm5twhp8GBu8a2oz+9Infg7722WrfjDEOV9gG9s/PyDv/r/bAdBTCSV0fzg7d+I7DlDV5sAlqB2I998Kzw95xSUrhp1QC8Ks/lanKIHZMfZOMRuXLSB+xCKtdkMEqYySvQPWXTWb3D0siSLMFT/hjj6AqSISJDRXVS3WqRJwT2DPcUUS7Yj+Myz3kKNbsn9nkSp6moQnkDNBW600x1A9ZB9R23/sRo7tH6v/RGKrRclXG7r5Ug+6WYSHpDNrsMqtwmNLmjlt8+Lzxnm/R+2BOUppD1QMAuGd/7zAH7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0AyxYpaTmDQUl5fMruHff6ifX3Oan0fPaFJ4TlPicfQ=; b=pZ5gg2riVF/gFRTi1MeawKtW19uoJqZkH0ueiUEF2IW+aDHGGlqiqI+rhock/U/TVbbYgnI9MFZUSBuzm2j5gcOmxfx7XXNYAVS8oBJzdPIM9cThXsQqAl+JTvQI2LMltbTsPzXi0ht6jd/4YsdcEaXdGpV/I/Fz4PmlcFUusTyXraoGZCF9HHb+u9b2uY0NP66DT1tcyU+MALebMtOohBnJPuDHxQwh1NY+CTq+gc2EbpP7/4R0R2/eh70tfIZGkOVKUQQoVeID+EBCnAEZYdxJUPhicUipKaUYMNLeVpzbyLhCg2h8MNkvHBsuRaWT0A11ahYKSNAGr1sDE+9BuA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by MN0PR12MB6055.namprd12.prod.outlook.com (2603:10b6:208:3cd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Tue, 7 Apr 2026 14:44:47 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9769.014; Tue, 7 Apr 2026 14:44:47 +0000 From: Zi Yan To: Sayali Patil Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Ritesh Harjani , David Hildenbrand , Michal Hocko , Oscar Salvador , Lorenzo Stoakes , Dev Jain , Liam.Howlett@oracle.com, linuxppc-dev@lists.ozlabs.org, Miaohe Lin , Venkat Rao Bagalkote Subject: Re: [PATCH v4 07/15] selftests/mm: free dynamically allocated PMD-sized buffers in split_huge_page_test Date: Tue, 07 Apr 2026 10:44:25 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL0PR02CA0129.namprd02.prod.outlook.com (2603:10b6:208:35::34) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|MN0PR12MB6055:EE_ X-MS-Office365-Filtering-Correlation-Id: e5aade34-07b6-4ec1-0d2c-08de94b42bb9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: aEY5j8AzzwLKbBFsupHGHY2iumiipxF6OXYws6e0GuH926pPSk8UCAUD3/JciPvdz3/vjJBy8n6nmao9C4PMsfZQXtH8RaSUPKgcXG16Bbb+NC+KmlmeSp8wBrkVFCog0Mvw2cmVQpgfAIVWIhbdduTq6ZjfSv8PnpPLl2k1Ys//Q1ezp0ZKnGiJGrSxeZoOBlRejRAJuCHZVpBkbyrEBgNhfj2pvAxIjmhwFZ/ev4Fw6F2qOmGfvDWlTxXCObsxMTawPCwV2PWSCIa4GeP+hAqnDrmpr7prMS7ztGufSegRuMZcl6xXvkheUU4ivkORH1KThpYZ9XU5EGEaZdwLmgUn/WTr8BHOfQEkXqaDVsKEdjQzEDDk9RUO/Z5xujygyZwXCcr8pTexC/ZFoKzHIye7M+n3FfOQbmEq26IVyJ8VcNxhvpVJMfip27A31NVMsuESJxOHmSegNuBvMAlMi9Z9/9ErgkQBKCPPsLmmV5xo1JrlAlo2LfMxeut5NSXuUWmtStgfw0w2ELScHV+g3AYh8LpYzxm2YvU/mZEUUDihQIhAFkZnkqQQxlQaiIZTvMOEoJ+3YRGxg2XJKLa261crHTM37TQEiO1MlaPXF0m+/RcxluXywgdns8wG9WMQGsIVTmEOmbR8egp+2/cZoTo1Oy1kNzOFS3sS/lh/15ubm2TJbONVZFJ/+qEvfmV4/DBUDuNXsa4c+meCk9502uRoKeVXcAl5ScW6hLPmzQE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?obe+T0kh1n4MxRF9jOfUDDyNBO1s8Wfl5j5a13g1TRxKPV0VmHWQFiqYRZeA?= =?us-ascii?Q?40I4JHxdF/0PGIYMIEMR6dQdSYM0zfpvLkSX+O7IHcSxlW0+A6P1t+vLQcJx?= =?us-ascii?Q?U675alGGBRCiOI5s0kKpvUuhxhwzZbb2fZnHLiKENJMF9mJOEBpiKqojLJiD?= =?us-ascii?Q?CW4jOSfV4M2vslwe4VrhpwoLaqoiN3Dfo6Et7JPuULFKVfqbd4Z2qP1pB21N?= =?us-ascii?Q?C/KNwjq27cmRPIqBLh8NIIzUbdZN5qLa7HqT/umetb7Ani3QEBfYL8hsDvGM?= =?us-ascii?Q?8utgdFMZIOItD76Wt6si2SaTQYWbHwlr9tJTkS47dVz6aawsygTtWCc1zbIt?= =?us-ascii?Q?3ZW0YgaEVEq908zXb3LoUCjGEFTN4IlahCcaOQ9d4a3yyO1Bt9NZwj4GwzXh?= =?us-ascii?Q?xPcfiWvj+FDW3JYMQ9EfTecXWFhTfuyFbs+j4ytRs9dM50wsL6FgVX+V/V0t?= =?us-ascii?Q?3pDs03pEMvzIOHO21/THhmjQsEumchr4DXoJu9drSxZZTKZbt8qDh/vy17kC?= =?us-ascii?Q?BxxBQGxMpMPh3Q3y+KikNzZP7aYaanKZo1GhFgmomlmzGsUxYRyHts7hns+t?= =?us-ascii?Q?h0J8++CiNcTDvCttjSRaPmQP99ayeoTqsT2c07mtHshOmWE+W0olbIAvUvaO?= =?us-ascii?Q?rd4jR+sjEXEHvJvQEXGfv5obcKU3OYNPDvp2SrIRHm4ZzJCcElpUk+uWoVBB?= =?us-ascii?Q?8AewvqVoVtNa+vMbl5V+xJcr+W1fMK5GhjX82uTdF/AfoUfBVmhGfOz6w7Xv?= =?us-ascii?Q?Vhc8PcY+VixmX95UO6D9Woz9N1IKvMH/Z6usMjkB6qGPcT4AI1Y21qEEqFTH?= =?us-ascii?Q?l4I10ayaIW8FYOTDQqY3Cq59a3BDIDnEAqMgCjJyFJ26nx0TKOV11EChJovA?= =?us-ascii?Q?22yiTqzVCFKQFmkdfu15rK0Ne40KU/u/GZeZ/o6XklbIwkkKDYjrhr5lo42x?= =?us-ascii?Q?5e10i/ERr1VQElVCvvYByO/98ZwwaPry/1ywstItIpDpv6xtknbg9vsRsE6r?= =?us-ascii?Q?/44HAb/UCbfp2aeexh/nGfuK3s7wMpVc0vz0rG5wP9iUxw9zty/HUFSbozYy?= =?us-ascii?Q?rZNWQRMioHssbktl7iUbskHAqD+nxMfK34Ul5S/e/7d7VKy3bWrOgHcQEBDE?= =?us-ascii?Q?FLdqp769Lmb055zaAPl06KtMnZNBrRMERfRlzlXN+d34rspq7mxA+8OZYbAA?= =?us-ascii?Q?lkmlakOaTwzOlR5s0ESfLJ/Sbjx2HHPuNsVGqRGaoMYJM9zBPUsvpSBp9DeY?= =?us-ascii?Q?nO8VjKPPWTkwCsRApuQxWBJzwzhntruKQg97cjuaY8k/CUaRzWFSbaupI0oS?= =?us-ascii?Q?xSvcXfH/LHnnr5IMwKidgrfjk+3qMJJDdiBG9SYbIY/J+sAzwQ/KWTIz93Qh?= =?us-ascii?Q?IWJL1MHbAG9th6vEPqvFsODrrSOIFbKmKpIvuwSkk2OCygagHoA7iz5TKKeX?= =?us-ascii?Q?6HgNVZ4niFgkR6EiUZVvgC1H97bMvFSnRpzrSfVboWUgNe9V8TKvS1/RZrXU?= =?us-ascii?Q?2Q4o5vDGbT7pHRbCo4F3vNWlbQnlkge1sdLw0LBJ9xB2MbQJxktl3k7y6lZM?= =?us-ascii?Q?op66yavjBUvU/np2wShp9nXWYt5v9BDxQ0BtcxnaoR4x7X+A79lPhzBoQLAT?= =?us-ascii?Q?HQp44DlOU7NpN7vbT6jCxVVLGnkyuHyXdWcvT6X9wOFPVNcyCpS3X98cnEV6?= =?us-ascii?Q?xbkdMj0y2ggUr7S/7SNgXHODiWa08w82NcNeEKQW0m2m5L7R?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5aade34-07b6-4ec1-0d2c-08de94b42bb9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2026 14:44:28.3022 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: edku6T+V8zr+Ly4Tp+2Nl+wx5mKlegeBMcpUyQUy0tf51lVXAm9FeppT+sdlbRB2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6055 On 6 Apr 2026, at 5:19, Sayali Patil wrote: > Dynamically allocated buffers of PMD size for file-backed > THP operations (file_buf1 and file_buf2) were not freed on > the success path and some failure paths. Since the > function is called repeatedly in a loop for each split order, > this can cause significant memory leaks. > > On architectures with large PMD sizes, repeated leaks > could exhaust system memory and trigger the OOM killer > during test execution. > > Ensure all allocated buffers are freed to maintain > stable repeated test runs. > > Fixes: 035a112e5fd5 ("selftests/mm: make file-backed THP split work by = writing PMD size data") > Signed-off-by: Sayali Patil > --- > .../selftests/mm/split_huge_page_test.c | 22 ++++++++++++++-----= > 1 file changed, 16 insertions(+), 6 deletions(-) > Thank you for fixing it. Reviewed-by: Zi Yan Best Regards, Yan, Zi