Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'

[Daniel Tang <dt.tangr@gmail.com>]

Hi,

On 05/12/2013, at 7:49 PM, Peter Chen <Peter.Chen@freescale.com> wrote:

> On Thu, Dec 05, 2013 at 04:44:13PM +1100, Daniel Tang wrote:
>> Hi,
>> 
>> On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen@freescale.com> wrote:
>> 
>>> 
>>> lsi is vendor name, what are zevio and nspire?
>>> Usually, the compatible string should be "vendor_name,soc_name-module_name"
>>> 
>> 
>> Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire.
>> 
> 
> Please wrap the line to 80 characters.
> 
> The driver is written for the TI-Nspire, and you port this driver for
> SoC Zevio platform?

The TI-Nspire runs on the Zevio SoC.

> Since you use chipidea ip, we don't care the usb
> module name at your platform, we only care the soc name which you are
> running, it can detect the SoC platform at runtime.
> 

Yep, that's why the latest patch I sent in renames the device tree 
binding to "lsi,zevio-usb" since zevio is the name of the SoC that the 
TI-Nspire uses.

> At your dts patch, it still uses nspire-usb.
> http://marc.info/?l=linux-usb&m=138614886720024&w=2

I'll send a new one in right now.

> 
> Peter

Cheers,
Daniel Tang