From: Bradley Morgan <include@grrlz.net>
To: Joel Granados <joel.granados@kernel.org>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
jackmanb@google.com, kees@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com, shijianlin11@foxmail.com, shuah@kernel.org,
surenb@google.com, vbabka@kernel.org, ziy@nvidia.com
Subject: Re: [PATCH v2 3/4] sysctl: Disallow partial updates for erroneous sysctl vectors
Date: Mon, 17 Aug 2026 14:44:29 +0100 [thread overview]
Message-ID: <FB1BAD61-3BC2-4CF0-9345-6CC2E9EC548A@grrlz.net> (raw)
In-Reply-To: <cwfpl5h47km6f35m5k7wa2pj3elciaax6i3nmetxcgws66qewq@fzygztolxed4>
On 17 August 2026 14:43:44 BST, Joel Granados <joel.granados@kernel.org>
wrote:
>On Sat, Aug 15, 2026 at 05:05:26PM +0100, Bradley Morgan wrote:
>> commit_conv_vec() writes the elements one by one, so a reader can
>> still see a mix of old and new values while the loop runs. Same as
>> before this series, so no regression, but the changelog could say
>> this doesn't make the write atomic either. Otherwise someone later
>> will expect the vector to change all at once.
>
>Seems reasonable: here is what I added to the commit message:
>
>
>"
>... This (The staging vector) does **not** make the write atomic as a
>reader
>can still see a partially updated vector.
>
Good enough.
>...
>"
>
>Best
>
>Joel
>
>>
>> The copy is limited by table->maxlen and only vectors pay for it.
>>
>> Fine by me.
>>
>> Reviewed-by: Bradley Morgan <include@grrlz.net>
>> Thanks!
>
Thanks!
next prev parent reply other threads:[~2026-08-17 13:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 10:41 [PATCH v2 0/4] sysctl: Disallow partial updates of miss-formatted " Joel Granados
2026-08-14 10:41 ` [PATCH v2 1/4] sysctl: Split data conversion and file position handling Joel Granados
2026-08-15 16:04 ` Bradley Morgan
2026-08-17 13:34 ` Joel Granados
2026-08-14 10:41 ` [PATCH v2 2/4] sysctl: Reject uint arrays before calling the general proc_vec Joel Granados
2026-08-15 16:04 ` Bradley Morgan
2026-08-14 10:41 ` [PATCH v2 3/4] sysctl: Disallow partial updates for erroneous sysctl vectors Joel Granados
2026-08-15 16:05 ` Bradley Morgan
2026-08-17 13:43 ` Joel Granados
2026-08-17 13:44 ` Bradley Morgan [this message]
2026-08-17 13:46 ` Bradley Morgan
2026-08-14 10:41 ` [PATCH v2 4/4] sysctl: Add 0013 to test partially updated vectors Joel Granados
2026-08-15 16:05 ` Bradley Morgan
2026-08-17 13:54 ` Joel Granados
2026-08-17 14:05 ` Bradley Morgan
2026-08-14 19:36 ` [PATCH v2 0/4] sysctl: Disallow partial updates of miss-formatted sysctl vectors Andrew Morton
2026-08-17 13:24 ` Joel Granados
2026-08-15 16:09 ` Bradley Morgan
2026-08-18 12:46 ` Joel Granados
2026-08-18 13:07 ` Bradley Morgan
2026-08-17 14:02 ` Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FB1BAD61-3BC2-4CF0-9345-6CC2E9EC548A@grrlz.net \
--to=include@grrlz.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=joel.granados@kernel.org \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=shijianlin11@foxmail.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®