From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751384Ab1AEAkj (ORCPT ); Tue, 4 Jan 2011 19:40:39 -0500 Received: from ns2.cypress.com ([157.95.67.5]:47411 "EHLO ns2.cypress.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750875Ab1AEAkh (ORCPT ); Tue, 4 Jan 2011 19:40:37 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Subject: RE: [v3 1/3] 1/3 Touchscreen: Cypress TTSP G3 MTDEV Core Driver Date: Tue, 4 Jan 2011 16:38:31 -0800 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [v3 1/3] 1/3 Touchscreen: Cypress TTSP G3 MTDEV Core Driver Thread-Index: AcursU6e2be7y6FgSGmrrlqq9MFwEAAv3dYw References: <1293650268-1561-1-git-send-email-kev@cypress.com> <1294105814.2570.17.camel@hongdev> From: "Kevin McNeely" To: "Hong Liu" Cc: "Dmitry Torokhov" , "David Brown" , "Trilok Soni" , "Henrik Rydberg" , "Samuel Ortiz" , "Eric Miao" , "Mike Frysinger" , "Alan Cox" , , X-OriginalArrivalTime: 05 Jan 2011 00:39:32.0063 (UTC) FILETIME=[04B7D6F0:01CBAC71] X-Brightmail-Tracker: AAAAAA== X-MailScanner: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id p050esGA014448 Hello Hong, The uninitialized use of ts->dev will be fixed in v4. Thank you, Kevin > -----Original Message----- > From: Hong Liu [mailto:hong.liu@intel.com] > Sent: Monday, January 03, 2011 5:50 PM > To: Kevin McNeely > Cc: Dmitry Torokhov; David Brown; Trilok Soni; Henrik Rydberg; Samuel > Ortiz; Eric Miao; Mike Frysinger; Alan Cox; linux- > input@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [v3 1/3] 1/3 Touchscreen: Cypress TTSP G3 MTDEV Core > Driver > > On Thu, 2010-12-30 at 03:17 +0800, Kevin McNeely wrote: > [...] > > > + > > +void *cyttsp_core_init(struct cyttsp_bus_ops *bus_ops, struct device > *dev) > > +{ > > + struct input_dev *input_device; > > + > > + struct cyttsp *ts = kzalloc(sizeof(*ts), GFP_KERNEL); > > + > > + if (!ts) { > > + dev_dbg(ts->dev, "%s: Error, kzalloc\n", __func__); > > + goto error_alloc_data; > > + } > > ts->dev is not assigned yet. > > Thanks, > Hong > > > + > > + if (dev == NULL || bus_ops == NULL) { > > + kfree(ts); > > + goto error_alloc_data; > > + } > > + > > + mutex_init(&ts->mutex); > > + ts->dev = dev; > > + ts->platform_data = dev->platform_data; > > + ts->bus_ops = bus_ops; > > + init_completion(&ts->bl_ready); > > + > > + if (ts->platform_data->init) { > > + if (ts->platform_data->init()) { > > + dev_dbg(ts->dev, "%s: Error, platform init > failed!\n", > > + __func__); > > + goto error_init; > > + } > > + } > > + > > + ts->irq = gpio_to_irq(ts->platform_data->irq_gpio); > > + if (ts->irq <= 0) { > > + dev_dbg(ts->dev, "%s: Error, failed to allocate > irq\n", > > + __func__); > > + goto error_init; > > + } > > + > > + /* Create the input device and register it. */ > > + input_device = input_allocate_device(); > > + if (!input_device) { > > + dev_dbg(ts->dev, "%s: Error, failed to allocate input > device\n", > > + __func__); > > + goto error_input_allocate_device; > > + } > > + > > + ts->input = input_device; > > + input_device->name = ts->platform_data->name; > > + snprintf(ts->phys, sizeof(ts->phys), "%s", dev_name(dev)); > > + input_device->phys = ts->phys; > > + input_device->dev.parent = ts->dev; > > + ts->bus_type = bus_ops->dev->bus; > > + input_device->open = cyttsp_open; > > + input_device->close = cyttsp_close; > > + input_set_drvdata(input_device, ts); > > + > > + __set_bit(EV_SYN, input_device->evbit); > > + __set_bit(EV_KEY, input_device->evbit); > > + __set_bit(EV_ABS, input_device->evbit); > > + > > + input_set_abs_params(input_device, ABS_MT_POSITION_X, > > + 0, ts->platform_data->maxx, 0, 0); > > + input_set_abs_params(input_device, ABS_MT_POSITION_Y, > > + 0, ts->platform_data->maxy, 0, 0); > > + input_set_abs_params(input_device, ABS_MT_TOUCH_MAJOR, > > + 0, CY_MAXZ, 0, 0); > > + > > + if (input_register_device(input_device)) { > > + dev_dbg(ts->dev, "%s: Error, failed to register input > device\n", > > + __func__); > > + goto error_input_register_device; > > + } > > + > > + goto no_error; > > + > > +error_input_register_device: > > + input_unregister_device(input_device); > > +error_input_allocate_device: > > + if (ts->platform_data->exit) > > + ts->platform_data->exit(); > > +error_init: > > + mutex_destroy(&ts->mutex); > > + kfree(ts); > > +error_alloc_data: > > +no_error: > > + return ts; > > +} > > +EXPORT_SYMBOL_GPL(cyttsp_core_init); > > + > > +MODULE_LICENSE("GPL"); > > +MODULE_DESCRIPTION("Cypress TrueTouch(R) Standard touchscreen driver > core"); > > +MODULE_AUTHOR("Cypress"); > --------------------------------------------------------------- This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message. --------------------------------------------------------------- {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I