From: Kyle Moffett <mrmacman_g4@mac.com>
To: Andrey Panin <pazke@donpac.ru>
Cc: Russell King <rmk+serial@arm.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [2.6] Clean up useless 8250 siig functions and header
Date: Fri, 14 Jan 2005 07:22:40 -0500 [thread overview]
Message-ID: <FBD27F98-6626-11D9-A56D-000393ACC76E@mac.com> (raw)
In-Reply-To: <20050114120101.GA29859@pazke>
On Jan 14, 2005, at 07:01, Andrey Panin wrote:
> On 005, 01 05, 2005 at 05:52:14PM -0500, Kyle Moffett wrote:
>> This removes two simple siig functions that should just be integrated
>> into the calling code.
>
> Good idea, wrong patch. You deleted wrapper code, but actual init
> functions left not exported for use by parport_serial module.
> Even worse, they are left static, so monilithic kernel build will
> not work too :/
Oops, sorry!
> Did you compiled the kernel with your patch applied ?
Yes, but I think I managed to lose some changes somewhere in the
process of managing my patchset.
> Please use attached patch instead.
Thanks,
Kyle Moffett
-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCM/CS/IT/U d- s++: a18 C++++>$ UB/L/X/*++++(+)>$ P+++(++++)>$
L++++(+++) E W++(+) N+++(++) o? K? w--- O? M++ V? PS+() PE+(-) Y+
PGP+++ t+(+++) 5 X R? tv-(--) b++++(++) DI+ D+ G e->++++$ h!*()>++$ r
!y?(-)
------END GEEK CODE BLOCK------
prev parent reply other threads:[~2005-01-14 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-05 22:52 Kyle Moffett
2005-01-14 12:01 ` Andrey Panin
2005-01-14 12:22 ` Kyle Moffett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FBD27F98-6626-11D9-A56D-000393ACC76E@mac.com \
--to=mrmacman_g4@mac.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@donpac.ru \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®