From: "Drokin, Oleg" <oleg.drokin@intel.com>
To: Srikrishan Malik <srikrishanmalik@gmail.com>
Cc: "<greg@kroah.com>" <greg@kroah.com>,
"Dilger, Andreas" <andreas.dilger@intel.com>,
"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 08/13] staging: lustre: fix multi line strings
Date: Tue, 12 Aug 2014 02:17:07 +0000 [thread overview]
Message-ID: <FBE0C2BE-D82B-40E6-93B2-929E66130883@intel.com> (raw)
In-Reply-To: <1407781659-728-8-git-send-email-srikrishanmalik@gmail.com>
On Aug 11, 2014, at 2:27 PM, Srikrishan Malik wrote:
> Fixes the following checkpatch warning:
>
> WARNING: quoted string split across lines
> diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c b/drivers/staging/lustre/lustre/mdc/mdc_request.c
> index 57d903156917..6c691a4763b5 100644
> --- a/drivers/staging/lustre/lustre/mdc/mdc_request.c
> +++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c
> @@ -2055,8 +2055,8 @@ static int mdc_hsm_copytool_send(int len, void *val)
> return -EPROTO;
> }
>
> - CDEBUG(D_HSM, " Received message mg=%x t=%d m=%d l=%d actions=%d "
> - "on %s\n",
> + CDEBUG(D_HSM,
> + " Received message mg=%x t=%d m=%d l=%d actions=%d on %s\n",
> lh->kuc_magic, lh->kuc_transport, lh->kuc_msgtype,
> lh->kuc_msglen, hal->hal_count, hal->hal_fsname);
I imagine we can drop the leading space here as well.
Thanks.
Bye,
Oleg
next prev parent reply other threads:[~2014-08-12 2:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 18:27 [PATCH v2 01/13] staging: lustre: remove space between function name and and open parenthesis Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 02/13] staging: lustre: remove spaces from start of line Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 03/13] staging: lustre: move open brace to next line after functions Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 04/13] staging: lustre: fix lines over 80 chars Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 05/13] staging: lustre: Add missing spaces around operators and braces Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 06/13] staging: lustre: replace c99 style comments with C89 Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 07/13] staging: lustre: add blank lines after declarations Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 08/13] staging: lustre: fix multi line strings Srikrishan Malik
2014-08-12 2:17 ` Drokin, Oleg [this message]
2014-08-12 17:42 ` Srikrishan Malik
2014-08-13 14:01 ` [PATCH v3 08/13]] " Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 09/13] staging: lustre: Added space between type name and * Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 10/13] staging: lustre: Fix misplaced opening brace warnings Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 11/13] staging: lustre: move else on the same line as closing brace Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 12/13] staging: lustre: remove parentheses usage with return Srikrishan Malik
2014-08-11 18:27 ` [PATCH v2 13/13] staging: lustre: Cleanup variable declarations in mdc_enqueue() Srikrishan Malik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FBE0C2BE-D82B-40E6-93B2-929E66130883@intel.com \
--to=oleg.drokin@intel.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srikrishanmalik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®