From: Daniel Almeida <daniel.almeida@collabora.com>
To: Mary Guillemard <mary@mary.zone>
Cc: Lyude Paul <lyude@redhat.com>, Danilo Krummrich <dakr@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Mary Guillemard <mary@mary.zone>
Subject: Re: [PATCH] drm/nouveau: Skip the Turing CE workaround object for non-GR channels
Date: Thu, 8 Oct 2026 19:03:43 -0300 [thread overview]
Message-ID: <FDA5DD6C-28C2-4A88-AF4B-366856512515@collabora.com> (raw)
In-Reply-To: <20261007-turing-async-ce-fix-v1-1-12ee6ccd1a3c@mary.zone>
> On 7 Oct 2026, at 11:36, Mary Guillemard <mary@mary.zone> wrote:
>
> This workaround is here for the old Gallium driver and predate async CE
> and NVDEC. Instead of only skipping it for NVDEC, let's only apply it
> in case of GR channels.
>
> This should make async CE work properly on Turing by stopping the assign
> of a GRCE. (here CE0)
>
> Signed-off-by: Mary Guillemard <mary@mary.zone>
> ---
> drivers/gpu/drm/nouveau/nouveau_abi16.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c
> index e907c1d07887..e876f154963d 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c
> @@ -488,7 +488,7 @@ nouveau_abi16_ioctl_channel_alloc(ABI16_IOCTL_ARGS)
> goto done;
> break;
> case NV_DEVICE_INFO_V0_TURING:
> - if (engine != NV_DEVICE_HOST_RUNLIST_ENGINES_NVDEC) {
> + if (engine == NV_DEVICE_HOST_RUNLIST_ENGINES_GR) {
> ret = nvif_object_ctor(&chan->chan->user, "abi16CeWar",
> 0, TURING_DMA_COPY_A, NULL, 0,
> &chan->ce);
>
> ---
> base-commit: 70456f05d4b6396b22048c4b8cd3cb98ecf9f9e3
> change-id: 20261007-turing-async-ce-fix-42e179e27d4a
>
> Best regards,
> --
> Mary Guillemard <mary@mary.zone>
>
Sorry, it didn’t occur to me to do this instead of the NVDEC only fix.
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
prev parent reply other threads:[~2026-10-08 22:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 14:30 Mary Guillemard
2026-10-08 21:50 ` lyude
2026-10-08 22:03 ` Daniel Almeida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FDA5DD6C-28C2-4A88-AF4B-366856512515@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=airlied@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mary@mary.zone \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®