From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2006DEB64DD for ; Fri, 21 Jul 2023 06:43:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229688AbjGUGnG (ORCPT ); Fri, 21 Jul 2023 02:43:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjGUGnC (ORCPT ); Fri, 21 Jul 2023 02:43:02 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36F4EE44; Thu, 20 Jul 2023 23:42:59 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3fbc5d5742eso13965055e9.3; Thu, 20 Jul 2023 23:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689921777; x=1690526577; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=5nZ2UjtJkJatqkl69pOrJuBy1CF5MniKXwLw/NTDggw=; b=JPudhTqrkma+6DrU2mBTAIjKltl7VwyWyIdTjCrSLqpYo1uNrTaI0EKwF7BxrvTtim knRkn68kKGmOlO+CxZf9tFM/EKk1cH1TRez68fCPz0v7gY5BvRTDlY6gznNCEIZsVjo1 xYkaln6qYKDpKnERZCEfeIp6gRHk1jUtjEOdY2i7NqaDaanc/YdwhIKcqdHBLIJyyXp0 aC4nf2ZJSkHzU/7B1JMLXl3zUDMJpuSoaeRVCRf7Jhrx9wSn8T6TM/hfsBYqjn0iIdKR XtJso2ZI+uMpgwRPwOR4xxs7wyYOS41HgTc+OkWl11eM2YMJdNyRCOwKHLtFqrNNHLCm myWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689921777; x=1690526577; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5nZ2UjtJkJatqkl69pOrJuBy1CF5MniKXwLw/NTDggw=; b=Rzc3NFX8B11V5zQCIbcOWhb8AHx5hVeWQarDSRRWyWvfDCDEqwI0LAGHjCXuej5u6O ONi7rvwF0jDvlJNQtjAuMTJGfLwPx5FFyVLq9TgRg65XOfiVTsxNG+eGX2CWVPxuYaNC WJsLl4DNmy3DJl/u5oqa9eB437hVL6x75YpAZOk/NeH5Rc5R2SJQAYY8bDd95pR5YMQJ pBfUO5S/+G6uFF9RMbuhUX6513zqcEJ5MmX6HIf2LW/RjkoqCFUDX4nYLl0e8Ga4boh9 iKrbzaut21Fj2yipmRU1oHqA7ppw0HOvbv5u0yzEzwzrYIgQT9xkpkrIPVS4KcJxn7Y7 L4Bw== X-Gm-Message-State: ABy/qLbVAumlyCcOFrKPzIHuTPDEa7D+0YMloXHdf6BeKhIvOcEGO7f+ Vs0lE4DL3oMJ0W9LQ7ZWBbU= X-Google-Smtp-Source: APBJJlFEnQe43nLu/D7LH9v9SV9nG1WKz+uvgZ8xZePV2QZj91PxIrCNwbdfC1vCgKGnFacLOir6Hw== X-Received: by 2002:a05:600c:b58:b0:3fb:b1fd:4183 with SMTP id k24-20020a05600c0b5800b003fbb1fd4183mr726368wmr.12.1689921777366; Thu, 20 Jul 2023 23:42:57 -0700 (PDT) Received: from smtpclient.apple ([2a02:c7c:aa7e:f200:f068:3acd:7e6c:5221]) by smtp.gmail.com with ESMTPSA id s13-20020a7bc38d000000b003fbd0c50ba2sm5498355wmj.32.2023.07.20.23.42.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jul 2023 23:42:56 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Kirsten Bromilow Mime-Version: 1.0 (1.0) Subject: Re: [syzbot] [hfs?] WARNING in hfs_write_inode Date: Fri, 21 Jul 2023 07:42:46 +0100 Message-Id: References: Cc: Finn Thain , Dave Chinner , Jeff Layton , John Paul Adrian Glaubitz , Dmitry Vyukov , Viacheslav Dubeyko , Arnd Bergmann , Linus Torvalds , syzbot , Andrew Morton , christian.brauner@ubuntu.com, Damien Le Moal , Linux FS Devel , LKML , syzkaller-bugs@googlegroups.com, ZhangPeng , linux-m68k@lists.linux-m68k.org, debian-ports In-Reply-To: To: Matthew Wilcox X-Mailer: iPhone Mail (20D67) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please stop sending these emails to me and remove me from the recipient list= ? ! Sent from my iPhone > On 21 Jul 2023, at 02:27, Matthew Wilcox wrote: >=20 > =EF=BB=BFOn Fri, Jul 21, 2023 at 11:03:28AM +1000, Finn Thain wrote: >> On Fri, 21 Jul 2023, Dave Chinner wrote: >>=20 >>>> I suspect that this is one of those catch-22 situations: distros are=20= >>>> going to enable every feature under the sun. That doesn't mean that=20 >>>> anyone is actually _using_ them these days. >>=20 >> I think the value of filesystem code is not just a question of how often=20= >> it gets executed -- it's also about retaining access to the data collecte= d=20 >> in archives, museums, galleries etc. that is inevitably held in old=20 >> formats. >=20 > That's an argument for adding support to tar, not for maintaining > read/write support. >=20 >>> We need to much more proactive about dropping support for unmaintained=20= >>> filesystems that nobody is ever fixing despite the constant stream of=20= >>> corruption- and deadlock- related bugs reported against them. >>=20 >> IMO, a stream of bug reports is not a reason to remove code (it's a reaso= n=20 >> to revert some commits). >>=20 >> Anyway, that stream of bugs presumably flows from the unstable kernel API= ,=20 >> which is inherently high-maintenance. It seems that a stable API could be= =20 >> more appropriate for any filesystem for which the on-disk format is fixed= =20 >> (by old media, by unmaintained FLOSS implementations or abandoned=20 >> proprietary implementations). >=20 > You've misunderstood. Google have decided to subject the entire kernel > (including obsolete unmaintained filesystems) to stress tests that it's > never had before. IOW these bugs have been there since the code was > merged. There's nothing to back out. There's no API change to blame. > It's always been buggy and it's never mattered before. >=20 > It wouldn't be so bad if Google had also decided to fund people to fix > those bugs, but no, they've decided to dump them on public mailing lists > and berate developers into fixing them. >=20