From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753696AbdC1BwJ (ORCPT ); Mon, 27 Mar 2017 21:52:09 -0400 Received: from mga14.intel.com ([192.55.52.115]:3710 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbdC1BwH (ORCPT ); Mon, 27 Mar 2017 21:52:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,234,1486454400"; d="scan'208";a="81675087" From: "Liu, Changpeng" To: Paolo Bonzini , "virtio-dev@lists.oasis-open.org" , "virtualization@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "hch@lst.de" CC: "qemu-devel@nongnu.org" Subject: RE: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver Thread-Topic: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver Thread-Index: AQHSptO7M0MdsNi4a0GFyWOy1cnHNqGoCF6AgAF00bA= Date: Tue, 28 Mar 2017 01:52:02 +0000 Message-ID: References: <1490690365-21109-1-git-send-email-changpeng.liu@intel.com> <00d28fcc-446b-eff6-a5a3-6675216802b9@redhat.com> In-Reply-To: <00d28fcc-446b-eff6-a5a3-6675216802b9@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2QwNzI1YWItODk5YS00YjQzLWFjNWYtNWM4NjVmNmZmYjA5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IllmQWFzSmRscEY1bnlCRHVqS0w4Y3dKWUxqa1VTRFFRZTBmMGF4ZzM2OFE9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v2S1qXFK023271 > -----Original Message----- > From: virtio-dev@lists.oasis-open.org [mailto:virtio-dev@lists.oasis-open.org] On > Behalf Of Paolo Bonzini > Sent: Monday, March 27, 2017 7:34 PM > To: Liu, Changpeng ; virtio-dev@lists.oasis-open.org; > virtualization@lists.linux-foundation.org; linux-kernel@vger.kernel.org; hch@lst.de > Cc: qemu-devel@nongnu.org > Subject: Re: [virtio-dev] [PATCH] virtio-blk: add DISCARD support to virtio-blk driver > > > > On 28/03/2017 10:39, Changpeng Liu wrote: > > + if (virtio_has_feature(vdev, VIRTIO_BLK_F_DISCARD)) { > > + q->limits.discard_zeroes_data = 0; > > Maybe you could use another feature bit to populate discard_zeroes_data. > > Paolo > Sounds good to me, Christoph Hellwig mentioned this field will be removed in next release, just removed this line makes clear. > > + q->limits.discard_alignment = blk_size; > > + q->limits.discard_granularity = blk_size; > > + blk_queue_max_discard_sectors(q, UINT_MAX); > > + blk_queue_max_discard_segments(q, 1); > > + queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, q); > > + } > > + > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org