From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753421AbdEIN7t (ORCPT <rfc822;w@1wt.eu>);
        Tue, 9 May 2017 09:59:49 -0400
Received: from mail-lf0-f41.google.com ([209.85.215.41]:33939 "EHLO
        mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752586AbdEIN7s (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 May 2017 09:59:48 -0400
From: =?utf-8?Q?Javier_Gonz=C3=A1lez?= <jg@lightnvm.io>
Message-Id: <FFAA9DA2-8A84-4C03-AFED-82F4BE10985B@lightnvm.io>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_74F23F4A-FA04-4E58-B363-8A8A1917A272";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH] nvme: lightnvm: fix memory leak
Date: Tue, 9 May 2017 15:59:43 +0200
In-Reply-To: <20170509135506.GA22624@dhcp-216.srv.tuxera.com>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        =?utf-8?Q?Matias_Bj=C3=B8rling?= <matias@cnexlabs.com>,
        Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>
To: Rakesh Pandit <rakesh@tuxera.com>
References: <20170509135506.GA22624@dhcp-216.srv.tuxera.com>
X-Mailer: Apple Mail (2.3273)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--Apple-Mail=_74F23F4A-FA04-4E58-B363-8A8A1917A272
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On 9 May 2017, at 15.55, Rakesh Pandit <rakesh@tuxera.com> wrote:
>=20
> Free up kmalloc allocated memory if failure happens while handling L2P
> table transfer in nvme_nvm_get_l2p_tbl.
>=20
> Fixes: 8e79b5cb ("lightnvm: move block provisioning to targets")
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> ---
> drivers/nvme/host/lightnvm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/nvme/host/lightnvm.c =
b/drivers/nvme/host/lightnvm.c
> index 206bfdb..f5df78e 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -367,7 +367,8 @@ static int nvme_nvm_get_l2p_tbl(struct nvm_dev =
*nvmdev, u64 slba, u32 nlb,
>=20
> 		if (unlikely(elba > nvmdev->total_secs)) {
> 			pr_err("nvm: L2P data from device is out of =
bounds!\n");
> -			return -EINVAL;
> +			ret =3D -EINVAL;
> +			goto out;
> 		}
>=20
> 		/* Transform physical address to target address space */
> --
> 2.5.5

Looks good. Thanks Rakesh.

Reviewed-by: Javier Gonz=C3=A1lez <javier@cnexlabs.com>


--Apple-Mail=_74F23F4A-FA04-4E58-B363-8A8A1917A272
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJZEctQAAoJEGMfBTt1mRjKXOUQAN0JaxZCReZJrb8owpeH7g7F
iGuxCwsZaCNda/P21o4Z6aNz3Ywyh28L3YdFfHyI9QJo8NKmd04aUe/YeKtdnG+0
NlzkVVU/ItYUic//i0gYOBh28JayqnfWKCplV1qfWFk6hFocr2jBsgrtDqhNWeO3
d8c3lUPtskctJN7dMdEBDd23SEIFcSZ0FCN5hP+qeysb75C9T33n0vuxo/BgXv8r
NI7zwqOtohka6nAUcCC1QsBfJccXsJNzzCKb0xEOcgk04oPQx7TBf3javWxVrTzY
cK52P3uo1eGcmg3XwelmIP4JXHbaIhVCWOl2Ntwm5hkpfo3Td4uN9X98XfT8nG4O
mL1XxCXvCO78kPnVRFAN3TwlLHkY2c6CqzChk2oZcLyoXkcZIq7YNTiPTZVrC06N
nRvFXXHPfbnN7blbTTV+tV3z2CN0LQPZlcOxKBuEozyyh0RrCsLzx5sM1hrNeh08
0DsN64IQG0TnCQr9VPMaMqxB+BWKx1HtN8YyVMbQn2/iv4J44VoSKKvyKrMY6rXo
tQ7VZ752C5utbAizxXZZqh8Ji9ux28oFQq/XpIvTVbhxInsjtrw1hRH/eNwjH/c0
K24hHiNYV1XPAoh1zl/iMXvPJuEPNCPsJKfncZrT964Je2U/v8X4qNtsi2iJFmKO
qsl68Z9lIet6d37dBDdu
=6oxl
-----END PGP SIGNATURE-----

--Apple-Mail=_74F23F4A-FA04-4E58-B363-8A8A1917A272--