From: "Arinzon, David" <darinzon@amazon.com>
To: "mmyangfl@gmail.com" <mmyangfl@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "mmyangfl@gmail.com" <mmyangfl@gmail.com>,
"Allen, Neil" <shayagr@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"hawk@kernel.org" <hawk@kernel.org>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"sdf@fomichev.me" <sdf@fomichev.me>,
"Bernstein, Amit" <amitbern@amazon.com>,
"horms@kernel.org" <horms@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"leitao@debian.org" <leitao@debian.org>,
"Enju, Kohei" <enjuk@amazon.co.jp>,
"ahmed.zaki@intel.com" <ahmed.zaki@intel.com>,
"mingo@kernel.org" <mingo@kernel.org>,
"tglx@kernel.org" <tglx@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: RE: [RFC net-next] net: ena: Use u64_stats_t with u64_stats_sync properly
Date: Tue, 27 Jan 2026 06:40:34 +0000 [thread overview]
Message-ID: <FFDD6CD9-5100-49E6-B3B8-F38099043E87@amazon.com> (raw)
Hi David,
Thank you for submitting the patch.
> On 64bit arches, struct u64_stats_sync is empty and provides no help
> against load/store tearing. Convert to u64_stats_t to ensure atomic
> operations.
>
We would like to run some quick performance tests internally before signing off.
> Signed-off-by: David Yang <mmyangfl@gmail.com>
> ---
> RFC Comment:
>
> The write side of u64_stats should ensure mutual exclusion, however I couldn't
> find the synchronization mechanism in use (for example, ena_up / ena_io_poll /
> ena_start_xmit). Should this be considered an issue?
We reviewed other drivers and it looks like none add extra synchronization on the write side.
Adding extra synchronization would degrade datapath performance to fix extremely rare missed counts.
You've submitted similar patches for other drivers but only commented on write-side
synchronization for ENA. Is there something specific to ENA that differs from other drivers?
next reply other threads:[~2026-01-27 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 6:40 Arinzon, David [this message]
2026-01-28 13:21 ` Arinzon, David
2026-01-28 22:34 ` David Yang
-- strict thread matches above, loose matches on Subject: below --
2026-01-22 19:24 David Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FFDD6CD9-5100-49E6-B3B8-F38099043E87@amazon.com \
--to=darinzon@amazon.com \
--cc=ahmed.zaki@intel.com \
--cc=akiyano@amazon.com \
--cc=amitbern@amazon.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bhelgaas@google.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enjuk@amazon.co.jp \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedb@amazon.com \
--cc=sdf@fomichev.me \
--cc=shayagr@amazon.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®