From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754858Ab1F0Vww (ORCPT ); Mon, 27 Jun 2011 17:52:52 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:42786 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754478Ab1F0Vwq convert rfc822-to-8bit (ORCPT ); Mon, 27 Jun 2011 17:52:46 -0400 From: "Grosen, Mark" To: Grant Likely , Ohad Ben-Cohen CC: davinci-linux-open-source , Arnd Bergmann , Brian Swetland , Rusty Russell , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [RFC 1/8] drivers: add generic remoteproc framework Thread-Topic: [RFC 1/8] drivers: add generic remoteproc framework Thread-Index: AQHML+SIQi02E6+wtECtfcP+kXbIPpTSC5UA//+3jZA= Date: Mon, 27 Jun 2011 21:52:30 +0000 Message-ID: References: <1308640714-17961-1-git-send-email-ohad@wizery.com> <1308640714-17961-2-git-send-email-ohad@wizery.com> <20110627204958.GB20865@ponder.secretlab.ca> In-Reply-To: <20110627204958.GB20865@ponder.secretlab.ca> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.247.5.50] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Grant Likely > Sent: Monday, June 27, 2011 1:50 PM Grant, thanks for the feedback. I'll try to answer one of your questions below and leave the rest for Ohad. Mark > > +Every remoteproc implementation must provide these handlers: > > + > > +struct rproc_ops { > > + int (*start)(struct rproc *rproc, u64 bootaddr); > > + int (*stop)(struct rproc *rproc); > > +}; > > + > > +The ->start() handler takes a rproc handle and an optional bootaddr > argument, > > +and should power on the device and boot it (using the bootaddr > argument > > +if the hardware requires one). > > Naive question: Why is bootaddr an argument? Wouldn't rproc drivers > keep track of the boot address in their driver private data? Our AMPs (remote processors) have a variety of boot mechanisms that vary across the different SoCs (yes, TI likes HW diversity). In some cases, the boot address is more like an entry point and that comes from the firmware, so it is not a static attribute of a driver. Correct me if I misunderstood your question. Mark