From: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lee Chun-Yi <jlee@suse.com>, Borislav Petkov <bp@alien8.de>,
"Luck, Tony" <tony.luck@intel.com>,
Will Deacon <will.deacon@arm.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
Naresh Bhat <naresh.bhat@linaro.org>,
"Neri, Ricardo" <ricardo.neri@intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
"Matt Fleming" <matt@codeblueprint.co.uk>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: RE: [PATCH V3 2/3] efi: Introduce efi_queue_work() to queue any efi_runtime_service() on efi_rts_wq
Date: Tue, 22 May 2018 22:44:46 +0000 [thread overview]
Message-ID: <FFF73D592F13FD46B8700F0A279B802F392AE61C@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20180522073618.GN12198@hirez.programming.kicks-ass.net>
> On Mon, May 21, 2018 at 08:13:03PM -0700, Sai Praneeth Prakhya wrote:
> > + /* \
> > + * queue_work() returns 0 if work was already on queue, \
> > + * _ideally_ this should never happen. \
> > + */ \
> > + if (queue_work(efi_rts_wq, &efi_rts_work.work))
> \
> > + flush_work(&efi_rts_work.work);
> \
>
> Since you're _always_ going to wait for it, it is _much_ cheaper to put a
> completion in your actual work and wait for that.
Sure! I will change it.
I also noticed that flush_work() in turn calls wait_for_completion().
Will also wait for a couple of days before posting V4.
Regards,
Sai
next prev parent reply other threads:[~2018-05-22 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 3:13 [PATCH V3 0/3] Use efi_rts_wq to invoke EFI Runtime Services Sai Praneeth Prakhya
2018-05-22 3:13 ` [PATCH V3 1/3] x86/efi: Call efi_delete_dummy_variable() after creating efi_rts_wq Sai Praneeth Prakhya
2018-05-22 3:13 ` [PATCH V3 2/3] efi: Introduce efi_queue_work() to queue any efi_runtime_service() on efi_rts_wq Sai Praneeth Prakhya
2018-05-22 7:36 ` Peter Zijlstra
2018-05-22 22:44 ` Prakhya, Sai Praneeth [this message]
2018-05-22 3:13 ` [PATCH V3 3/3] efi: Use efi_rts_wq to invoke EFI Runtime Services Sai Praneeth Prakhya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FFF73D592F13FD46B8700F0A279B802F392AE61C@ORSMSX114.amr.corp.intel.com \
--to=sai.praneeth.prakhya@intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bhsharma@redhat.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=naresh.bhat@linaro.org \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri@intel.com \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®