From: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-efi <linux-efi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lee Chun-Yi <jlee@suse.com>, Borislav Petkov <bp@alien8.de>,
"Luck, Tony" <tony.luck@intel.com>,
Will Deacon <will.deacon@arm.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
Naresh Bhat <naresh.bhat@linaro.org>,
"Neri, Ricardo" <ricardo.neri@intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: RE: [PATCH V5 3/3] efi: Use efi_rts_wq to invoke EFI Runtime Services
Date: Tue, 5 Jun 2018 20:15:20 +0000 [thread overview]
Message-ID: <FFF73D592F13FD46B8700F0A279B802F3B818BE7@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu_Y3Lt1FpymS00AMD4ZJ3AFSV1m7ggxuRFCa4PROeX8XA@mail.gmail.com>
> >> I noticed that -unsurprisingly- reboot no longer works with these changes.
> >>
> >> I will fix up the patch, and revert the efi_reset_system() change,
> >> both here and below.
> >
> > Could you please let me know what the bug is here? I am unable to see
> > it right away :( I have tested reboot on qemu x86_64 by passing
> > "reboot=efi" as command line arg and saw that reboot is working fine.
> >
>
> My arm64 hangs at reboot or power off, unless i revert the ResetSystem() part.
>
That's interesting. Not sure how the behavior could be different between x86 and arm64.
Maybe worth debugging further?
As you said, reverting ResetSystem() part makes things work, we cannot suspect a
buggy efi_reset_system() (I came across buggy efi_reset_system() implementations
on some x86 systems).
> But given that it is both risky (relying on a kthread running a workqueue in the
> shutdown path) and unnecessary (ResetSystem() is not supposed to return, and is
> only called by the kernel when the whole system has already been torn down), I
> think the main reason is simply that there is no reason to add it.
Makes sense.
I think, before calling firmware ResetSystem() kernel has already shut down all other parts
and hence as the control will not transfer back to kernel (other than ResetSystem() failure),
we could safely assume that no kernel code would access user space while in
efi_reset_system() and hence we don't need to take the work queue path.
Regards,
Sai
next prev parent reply other threads:[~2018-06-05 20:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 2:21 [PATCH V5 0/3] " Sai Praneeth Prakhya
2018-05-29 2:21 ` [PATCH V5 1/3] x86/efi: Make efi_delete_dummy_variable() use set_variable_nonblocking() instead of set_variable() Sai Praneeth Prakhya
2018-05-29 2:21 ` [PATCH V5 2/3] efi: Create efi_rts_wq and efi_queue_work() to invoke all efi_runtime_services() Sai Praneeth Prakhya
2018-05-29 2:21 ` [PATCH V5 3/3] efi: Use efi_rts_wq to invoke EFI Runtime Services Sai Praneeth Prakhya
2018-06-05 19:03 ` Ard Biesheuvel
2018-06-05 19:29 ` Prakhya, Sai Praneeth
2018-06-05 19:55 ` Ard Biesheuvel
2018-06-05 20:15 ` Prakhya, Sai Praneeth [this message]
2018-05-29 11:09 ` [PATCH V5 0/3] " Ard Biesheuvel
2018-06-01 19:01 ` Bhupesh Sharma
2018-06-01 19:38 ` Prakhya, Sai Praneeth
2018-06-02 2:02 ` Naresh Bhat
2018-06-04 4:27 ` Prakhya, Sai Praneeth
2018-06-06 8:42 ` Naresh Bhat
2018-06-06 17:24 ` Prakhya, Sai Praneeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FFF73D592F13FD46B8700F0A279B802F3B818BE7@ORSMSX114.amr.corp.intel.com \
--to=sai.praneeth.prakhya@intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bhsharma@redhat.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=naresh.bhat@linaro.org \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri@intel.com \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®