RE: [PATCH 1/6] efi: Introduce efi_memmap_free() to free memory allocated by efi_memmap_alloc()

["Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>]

> > Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
> > Suggested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Lee Chun-Yi <jlee@suse.com>
> > Cc: Dave Young <dyoung@redhat.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Jan Kiszka <jan.kiszka@siemens.com>
> > Cc: Dave Hansen <dave.hansen@intel.com>
> > Cc: Bhupesh Sharma <bhsharma@redhat.com>
> > Cc: Nicolai Stange <nicstange@gmail.com>
> > Cc: Naresh Bhat <naresh.bhat@linaro.org>
> > Cc: Ricardo Neri <ricardo.neri@intel.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Taku Izumi <izumi.taku@jp.fujitsu.com>
> > Cc: Ravi Shankar <ravi.v.shankar@intel.com>
> > Cc: Matt Fleming <matt@codeblueprint.co.uk>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> Do you really think you should cc all these people?
> 

Sorry! I get that..

> > ---
> >  drivers/firmware/efi/memmap.c | 28 ++++++++++++++++++++++++++++
> >  include/linux/efi.h           |  8 ++++++++
> >  2 files changed, 36 insertions(+)
> >

[snip]

> I am now thinking we should perhaps hide the allocation type from the callers
> rather than passing around implementation details of the allocator, and have
> explicit alloc/free operations.
> 
> Could we instead have a single 'efi_realloc_memmap()' function that takes care
> of all of this?

Sure! I will give it a try.

Regards,
Sai