From: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>, Borislav Petkov <bp@alien8.de>,
"Andy Lutomirski" <luto@kernel.org>,
"Hansen, Dave" <dave.hansen@intel.com>,
"Bhupesh Sharma" <bhsharma@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: RE: [PATCH] x86/efi: Don't unmap EFI boot services code/data regions for EFI_OLD_MEMMAP and EFI_MIXED_MODE
Date: Sat, 22 Dec 2018 19:05:39 +0000 [thread overview]
Message-ID: <FFF73D592F13FD46B8700F0A279B802F48607FBC@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20181222105410.GA130780@gmail.com>
>
> * Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com> wrote:
>
> > Commit d5052a7130a6 ("x86/efi: Unmap EFI boot services code/data
> > regions from efi_pgd") forgets to take two EFI modes into
> > consideration namely EFI_OLD_MEMMAP and EFI_MIXED_MODE.
>
> So the commit sha1 ended up being this one in tip:efi/core:
>
> 08cfb38f3ef4: x86/efi: Unmap EFI boot services code/data regions from
> efi_pgd
Ya.. sorry! I took the sha1 from efi tree.
>
> > EFI_OLD_MEMMAP is a legacy way of mapping EFI regions into
> > swapper_pg_dir using ioremap() and init_memory_mapping(). This feature
> > can be enabled by passing "efi=old_map" as kernel command line
> > argument. But,
> > efi_unmap_pages() unmaps EFI boot services code/data regions *only*
> > from efi_pgd and hence cannot be used for unmapping EFI boot services
> > code/data regions from swapper_pg_dir.
[.........]
> > + /*
> > + * EFI mixed mode has all RAM mapped to access arguments while
> making
> > + * EFI runtime calls, hence don't unmap EFI boot services code/data
> > + * regions.
> > + */
> > + if (!efi_is_native() && IS_ENABLED(CONFIG_EFI_MIXED))
> > + return;
>
> I suppose old_mmap and mixed mode stopped working altogether after the
> unmapping changes?
Yes.. that's true.
> What are the symptoms, instant reboots, crasher, or some
> more benign behavior like non-working runtime EFI functionality?
I noticed a kernel panic due to page fault.
AFAIK, it happens because efi_pgd is not defined for old_map and mixed mode.
Hence efi_unmap_pages() which calls __change_page_attr() unmaps mappings
from swapper_pg_dir (please note that this my theory but I haven't checked if
this is really true).
>
> If Ard acks this I'll apply it immediately, as these bugs look like show-stoppers for
> merging the EFI tree into v4.21.
>
> Thanks,
>
> Ingo
next prev parent reply other threads:[~2018-12-22 19:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-22 2:22 Sai Praneeth Prakhya
2018-12-22 10:54 ` Ingo Molnar
2018-12-22 11:04 ` Ard Biesheuvel
2018-12-24 9:38 ` Ard Biesheuvel
2018-12-28 21:27 ` Prakhya, Sai Praneeth
[not found] ` <FFF73D592F13FD46B8700F0A279B802F4860813C@ORSMSX114.amr.corp.intel.com>
2018-12-25 9:51 ` Ingo Molnar
2018-12-22 19:05 ` Prakhya, Sai Praneeth [this message]
2018-12-22 21:03 ` [tip:efi/core] " tip-bot for Sai Praneeth Prakhya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FFF73D592F13FD46B8700F0A279B802F48607FBC@ORSMSX114.amr.corp.intel.com \
--to=sai.praneeth.prakhya@intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bhsharma@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®