From: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>
To: gyeyoung <gye976@gmail.com>, Jonathan Cameron <jic23@kernel.org>
Cc: "lars@metafoo.de" <lars@metafoo.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: Remove duplicate code between labels
Date: Mon, 2 Sep 2024 09:51:49 +0000 [thread overview]
Message-ID: <FR3P281MB17577DB7CBA7F68A3DB2D4B4CE922@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAKbEzntnDGXFCgpscGSg-E-1VraE9J+kTwOsCocmu9N5Agxt-Q@mail.gmail.com>
Hello,
thanks for the patch, but beware that this modification is breaking the code!
You are deleting the normal function path return IRQ_HANDLED (without the goto end_session). With this patch, the reset fifo function code inv_reset_fifo() will be called even if the IRQ handler is functioning correctly.
This is a no go for me, I don't think we can easily change these 2 labels anyway.
Best regards,
JB
________________________________________
From: gyeyoung <gye976@gmail.com>
Sent: Monday, September 2, 2024 03:53
To: Jonathan Cameron <jic23@kernel.org>
Cc: lars@metafoo.de <lars@metafoo.de>; Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: Remove duplicate code between labels
This Message Is From an Untrusted Sender
You have not previously corresponded with this sender.
On Sun, Sep 1, 2024 at 11:11 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sun, 1 Sep 2024 21:08:39 +0900
> Gyeyoung Baek <gye976@gmail.com> wrote:
>
> > 'flush_fifo' label performs same task as 'endsession' label
> > immediately after calling 'env_reset_fifo' function.
> > So i remove that duplication.
> >
> > Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
>
> Ok. This doesn't greatly affect readability and the code
> ends up a bit shorter.
>
> Applied
>
> Jonathan
>
Thank you for approving it.
-Gyeyoung
next prev parent reply other threads:[~2024-09-02 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 12:08 Gyeyoung Baek
2024-09-01 14:11 ` Jonathan Cameron
2024-09-02 1:53 ` gyeyoung
2024-09-02 9:51 ` Jean-Baptiste Maneyrol [this message]
2024-09-02 13:35 ` Markus Elfring
2024-09-03 23:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FR3P281MB17577DB7CBA7F68A3DB2D4B4CE922@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM \
--to=jean-baptiste.maneyrol@tdk.com \
--cc=gye976@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®