mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Rob Herring <robh@kernel.org>
Cc: Stephen Warren <swarren@nvidia.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	~okias/devicetree@lists.sr.ht
Subject: Re: [PATCH] WIP: dt-bindings: arm: firmware: tlm,trusted-foundations: Convert txt bindings to yaml
Date: Wed, 20 Oct 2021 00:24:52 +0200	[thread overview]
Message-ID: <GXW81R.AUXV3AJ9VUDL@ixit.cz> (raw)
In-Reply-To: <YW86yrhJBTunU121@robh.at.kernel.org>




On Tue, Oct 19 2021 at 16:38:18 -0500, Rob Herring <robh@kernel.org> 
wrote:
> On Sat, Oct 09, 2021 at 12:45:18PM +0200, David Heidelberg wrote:
>>  Convert Trusted Foundation binding to the YAML syntax.
> 
> Looks fine. Why WIP?
> 

Can you drop the WIP prefix I forgot or should I resend?


> If version number ranges are known, you could add constraints on 
> those.

from driver:
         * we are not using version information for now since currently
         * supported SMCs are compatible with all TF releases
so I guess at least driver currently doesn't care and know any enums.

David

> 
>> 
>>  Signed-off-by: David Heidelberg <david@ixit.cz>
>>  ---
>>   .../arm/firmware/tlm,trusted-foundations.txt  | 20 --------
>>   .../arm/firmware/tlm,trusted-foundations.yaml | 46 
>> +++++++++++++++++++
>>   2 files changed, 46 insertions(+), 20 deletions(-)
>>   delete mode 100644 
>> Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt
>>   create mode 100644 
>> Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.yaml
>> 
>>  diff --git 
>> a/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt 
>> b/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt
>>  deleted file mode 100644
>>  index 780d0392a66b..000000000000
>>  --- 
>> a/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.txt
>>  +++ /dev/null
>>  @@ -1,20 +0,0 @@
>>  -Trusted Foundations
>>  --------------------
>>  -
>>  -Boards that use the Trusted Foundations secure monitor can signal 
>> its
>>  -presence by declaring a node compatible with 
>> "tlm,trusted-foundations"
>>  -under the /firmware/ node
>>  -
>>  -Required properties:
>>  -- compatible: "tlm,trusted-foundations"
>>  -- tlm,version-major: major version number of Trusted Foundations 
>> firmware
>>  -- tlm,version-minor: minor version number of Trusted Foundations 
>> firmware
>>  -
>>  -Example:
>>  -	firmware {
>>  -		trusted-foundations {
>>  -			compatible = "tlm,trusted-foundations";
>>  -			tlm,version-major = <2>;
>>  -			tlm,version-minor = <8>;
>>  -		};
>>  -	};
>>  diff --git 
>> a/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.yaml 
>> b/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.yaml
>>  new file mode 100644
>>  index 000000000000..9d1857c0aa07
>>  --- /dev/null
>>  +++ 
>> b/Documentation/devicetree/bindings/arm/firmware/tlm,trusted-foundations.yaml
>>  @@ -0,0 +1,46 @@
>>  +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>  +%YAML 1.2
>>  +---
>>  +$id: 
>> "http://devicetree.org/schemas/arm/firmware/tlm,trusted-foundations.yaml#"
>>  +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>  +
>>  +title: Trusted Foundations
>>  +
>>  +description: |
>>  +  Boards that use the Trusted Foundations secure monitor can 
>> signal its
>>  +  presence by declaring a node compatible under the /firmware/ node
>>  +
>>  +maintainers:
>>  +  - Stephen Warren <swarren@nvidia.com>
>>  +
>>  +properties:
>>  +  $nodename:
>>  +    const: trusted-foundations
>>  +
>>  +  compatible:
>>  +    const: tlm,trusted-foundations
>>  +
>>  +  tlm,version-major:
>>  +    $ref: /schemas/types.yaml#/definitions/uint32
>>  +    description: major version number of Trusted Foundations 
>> firmware
>>  +
>>  +  tlm,version-minor:
>>  +    $ref: /schemas/types.yaml#/definitions/uint32
>>  +    description: minor version number of Trusted Foundations 
>> firmware
>>  +
>>  +required:
>>  +  - compatible
>>  +  - tlm,version-major
>>  +  - tlm,version-minor
>>  +
>>  +additionalProperties: false
>>  +
>>  +examples:
>>  +  - |
>>  +    firmware {
>>  +      trusted-foundations {
>>  +        compatible = "tlm,trusted-foundations";
>>  +        tlm,version-major = <2>;
>>  +        tlm,version-minor = <8>;
>>  +      };
>>  +    };
>>  --
>>  2.33.0
>> 
>> 



  reply	other threads:[~2021-10-19 22:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 10:45 David Heidelberg
2021-10-19 21:38 ` Rob Herring
2021-10-19 22:24   ` David Heidelberg [this message]
2021-10-22 14:16     ` Rob Herring
2021-10-22 23:21       ` David Heidelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GXW81R.AUXV3AJ9VUDL@ixit.cz \
    --to=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=swarren@nvidia.com \
    --cc=~okias/devicetree@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®