mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikko Perttunen <mperttunen@nvidia.com>
To: Thierry Reding <thierry.reding@kernel.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-tegra@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, Joshua Crofts <crofts@kernel.org>,
	Joshua Crofts <crofts@kernel.org>
Subject: Re: [PATCH] drm/tegra: remove redundant pm_runtime_dont_use_autosuspend() calls
Date: Thu, 19 Nov 2026 16:13:07 +0900	[thread overview]
Message-ID: <GqcGePzkRVaM7zcZlGfZHQ@nvidia.com> (raw)
In-Reply-To: <20261110-tegra-remove-dont-use-autosuspend-v1-1-f37453d0e441@kernel.org>

On Wednesday, November 11, 2026 12:19 AM Joshua Crofts wrote:
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
> 
> Remove the redundant function calls.
> 
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
> ---
>  drivers/gpu/drm/tegra/nvdec.c | 1 -
>  drivers/gpu/drm/tegra/nvjpg.c | 1 -
>  drivers/gpu/drm/tegra/vic.c   | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/tegra/nvdec.c
> index 18a8f6e4ced083ee94cf1611223b7ef507e0b7f6..98a94423b0e2099b9f8330f73dee8f534564078f 100644
> --- a/drivers/gpu/drm/tegra/nvdec.c
> +++ b/drivers/gpu/drm/tegra/nvdec.c
> @@ -212,7 +212,6 @@ static int nvdec_exit(struct host1x_client *client)
>  	if (err < 0)
>  		return err;
>  
> -	pm_runtime_dont_use_autosuspend(client->dev);
>  	pm_runtime_force_suspend(client->dev);
>  
>  	host1x_syncpt_put(client->syncpts[0]);
> diff --git a/drivers/gpu/drm/tegra/nvjpg.c b/drivers/gpu/drm/tegra/nvjpg.c
> index e302a8d1f6e7fdbcd7f14881525b4a2e1a422361..09679bb0c75767ff1471134a478b5985b2c0ee5c 100644
> --- a/drivers/gpu/drm/tegra/nvjpg.c
> +++ b/drivers/gpu/drm/tegra/nvjpg.c
> @@ -82,7 +82,6 @@ static int nvjpg_exit(struct host1x_client *client)
>  	if (err < 0)
>  		return err;
>  
> -	pm_runtime_dont_use_autosuspend(client->dev);
>  	pm_runtime_force_suspend(client->dev);
>  
>  	host1x_client_iommu_detach(client);
> diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
> index 3c2b1ff55deb7f407d2a5995a5dff302cf37f7d5..9648c3d0176bbfd9efbb3c49c8bd9c74e3df9d0e 100644
> --- a/drivers/gpu/drm/tegra/vic.c
> +++ b/drivers/gpu/drm/tegra/vic.c
> @@ -205,7 +205,6 @@ static int vic_exit(struct host1x_client *client)
>  	if (err < 0)
>  		return err;
>  
> -	pm_runtime_dont_use_autosuspend(client->dev);
>  	pm_runtime_force_suspend(client->dev);
>  
>  	host1x_syncpt_put(client->syncpts[0]);
> 
> ---
> base-commit: b3dfbde62cf1981c4638939c159dfd087b7a72e9
> change-id: 20261110-tegra-remove-dont-use-autosuspend-caaf082f8c2f
> 
> Best regards,
> -- 
> Joshua Crofts <crofts@kernel.org>
> 
> 

Nice cleanup, thank you!

Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>




      reply	other threads:[~2026-11-19  7:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 15:19 Joshua Crofts
2026-11-19  7:13 ` Mikko Perttunen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GqcGePzkRVaM7zcZlGfZHQ@nvidia.com \
    --to=mperttunen@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=crofts@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=thierry.reding@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®