From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9EC1C07E9C for ; Sat, 10 Jul 2021 09:43:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D4E1613C3 for ; Sat, 10 Jul 2021 09:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232469AbhGJJpt convert rfc822-to-8bit (ORCPT ); Sat, 10 Jul 2021 05:45:49 -0400 Received: from aposti.net ([89.234.176.197]:56276 "EHLO aposti.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230134AbhGJJps (ORCPT ); Sat, 10 Jul 2021 05:45:48 -0400 Date: Sat, 10 Jul 2021 10:42:53 +0100 From: Paul Cercueil Subject: Re: [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA To: Sam Ravnborg Cc: Thierry Reding , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, list@opendingux.net, Christophe Branchereau Message-Id: In-Reply-To: References: <20210625121045.81711-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, thanks for the review. Le sam., juil. 10 2021 at 08:14:43 +0200, Sam Ravnborg a écrit : > Hi Paul, > > On Fri, Jun 25, 2021 at 01:10:44PM +0100, Paul Cercueil wrote: >> Add binding for the Innolux EJ030NA panel, which is a 320x480 3.0" >> 4:3 >> 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit >> interface. >> >> Signed-off-by: Paul Cercueil >> --- >> .../display/panel/innolux,ej030na.yaml | 62 >> +++++++++++++++++++ >> 1 file changed, 62 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml >> >> diff --git >> a/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml >> b/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml >> new file mode 100644 >> index 000000000000..cda36c04e85c >> --- /dev/null >> +++ >> b/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml >> @@ -0,0 +1,62 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: >> http://devicetree.org/schemas/display/panel/innolux,ej030na.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Innolux EJ030NA 3.0" (320x480 pixels) 24-bit TFT LCD panel >> + >> +description: | >> + The panel must obey the rules for a SPI slave device as >> specified in >> + spi/spi-controller.yaml >> + >> +maintainers: >> + - Paul Cercueil >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + >> +properties: >> + compatible: >> + const: innolux,ej030na >> + >> + backlight: true >> + port: true >> + power-supply: true >> + reg: true >> + reset-gpios: true >> + >> +required: >> + - compatible >> + - reg >> + - power-supply >> + - reset-gpios >> + >> +unevaluatedProperties: false > I had expected: > additionalProperties: false > > With this fixed: > Reviewed-by: Sam Ravnborg I am not sure; the doc states that this (additionalProperties: false) "can't be used in case where another schema is referenced", which is the case here, as we include "panel-common.yaml". Cheers, -Paul >> + >> +examples: >> + - | >> + #include >> + >> + spi { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + panel@0 { >> + compatible = "innolux,ej030na"; >> + reg = <0>; >> + >> + spi-max-frequency = <10000000>; >> + >> + reset-gpios = <&gpe 4 GPIO_ACTIVE_LOW>; >> + power-supply = <&lcd_power>; >> + >> + backlight = <&backlight>; >> + >> + port { >> + panel_input: endpoint { >> + remote-endpoint = <&panel_output>; >> + }; >> + }; >> + }; >> + }; >> -- >> 2.30.2