From: "Heiko Stübner" <heiko@sntech.de>
To: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sandy Huang <hjc@rock-chips.com>, ZhuXiangyu <1194781887@qq.com>
Cc: Andy Yan <andyshrk@163.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
ZhuXiangyu <1194781887@qq.com>
Subject: Re: [PATCH] drm/phy: rockchip: fix RK3506 DSI low-power command handling
Date: Sat, 21 Nov 2026 14:33:23 +0100 [thread overview]
Message-ID: <I1iUkWzgR2mQ2vL4ooyigA@sntech.de> (raw)
In-Reply-To: <tencent_F495CC22423581B98A12990F93C04F33CB06@qq.com>
Am Samstag, 21. November 2026, 09:05:55 Mitteleuropäische Normalzeit schrieb ZhuXiangyu:
> Two bugs keep the RK3506 MIPI-DSI link from initialising a panel: the
> DPHY programs the wrong high-speed timing entry, and the PHY data lanes
> are never enabled in the GRF.
>
> 1. phy-rockchip-inno-dsidphy picks the wrong HS timing entry
>
> The 1.5 GHz inno DSI PHY timing table stores its rates in Mbps while
> the other tables and the lookup use Hz. The mode enable code compares
> inno->pll.rate in Hz (e.g. 372000000) against timings[].rate in Mbps
> (e.g. 400), so the comparison never matches. The loop runs to the end
> and the last, fastest entry is used, which programs a TLPX/LPX
> counter that is far too large. The panel then cannot decode the
> low-power DCS commands and stays in sleep mode, so the display stays
> black even though the LP packets are visible on the data lane.
>
> Convert the 1.5 GHz timing table rates to Hz so that the lookup
> selects the correct entry.
>
> 2. The RK3506 DSI GRF lane enable bits are never written
>
> rk3506_chip_data only clears the turnaround / force-stop fields, so
> the PHY data lanes stay disabled unless the boot loader happens to
> enable them. Program RK3506_DSI_PHY_ENABLE_LANE0/1 as well.
>
> Tested on the RK3506B JerryTech board: the panel now receives the init
> sequence over LP and the framebuffer console is visible.
>
> Fixes: 785a9d5bb145 ("phy: rockchip: inno-dsidphy: Add support for rk3506")
> Fixes: cabeacc7eadc ("drm/rockchip: dsi: Add support for rk3506")
> Signed-off-by: ZhuXiangyu <1194781887@qq.com>
don't mix subsystems in patch submission please.
All the process issues, Krzysztof pointed out in another thread still
apply too.
Heiko
next prev parent reply other threads:[~2026-11-21 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 8:05 ZhuXiangyu
2026-11-21 13:33 ` Heiko Stübner [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-21 7:58 ZhuXiangyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=I1iUkWzgR2mQ2vL4ooyigA@sntech.de \
--to=heiko@sntech.de \
--cc=1194781887@qq.com \
--cc=airlied@gmail.com \
--cc=andyshrk@163.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mani@kernel.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®