From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02olkn2044.outbound.protection.outlook.com [40.92.44.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 788721474A2 for ; Tue, 14 Jan 2025 14:37:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.92.44.44 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736865475; cv=fail; b=Mbeqamvn3TRFTaE3E+6jeLqfoZvZLAAFK2SMoIAtiA4C3/lENg74EEVfOPov3o3BXM9dAvk5OXwaKccoqMMMUPfNYcgypCYkdoiL98ByEgCGvqnzu3f3QgBGrwj7TGh++760fKwgabw3N86GHKsE+MnBXoP97WzQXVvJQ/9QxH8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736865475; c=relaxed/simple; bh=BRl+RClhxzos+mcm+SgJULGq1c34v0popDliRotOwBU=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=SYugsCtfEQmz8xVEAevFwcV/7UoHmW9AokYbnut3ZsmlqLELf+0zZ4hrtInXS189Ydi4jkN3UksJrSrHakRwVOgZDhhT13W7ZTwfbDbssMUwh0JHwxViQa9ZT8YHLOMzQemfB0iRNuLrME/+GL8tbSHo5e36ruCcVTcZZZo5WMY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hotmail.com; spf=pass smtp.mailfrom=hotmail.com; dkim=pass (2048-bit key) header.d=hotmail.com header.i=@hotmail.com header.b=kyRIknnP; arc=fail smtp.client-ip=40.92.44.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=hotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hotmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hotmail.com header.i=@hotmail.com header.b="kyRIknnP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vKSswwnfZhnWdke390W80GPpdo2Eq5gl+orpgqLfaqQbFiQoJhQG/M6VmHtVn8os62N/+LQk4uBbXoA/KePUVBad8o1sRYwOfFL8TcNLbrLe5iO/9wnFv++eWBpmORoQdQJopjWvt+H7bkPQjoDITF9/Rs3kQuT6Q83eGpParL3/TIrQnc61clGbR7WFv51PC3AKLTvqfcBdtU9UH4PLqNT5nNxoGZSn6kZDEjKeNxma1PzfjItQ9ZnFLLopai0R74YWOqUSbOdDfCO8vqGt10sElRZ3hM3s+zRMgoJPPUxYeGGfyPh+hGLW+Q3p1lVqHHUoBM8mILUxR7e0Gshmeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vGpVNCDmYpXhHvZYR/+qXzC678pUWxm2QCkzbvIBSpA=; b=f8vPr14VVxYET5Hxx1+u2zbDTN3FPfjkK1TjA2bDstFuOAURcipRYXaErGbdRdGwAyhaV/sQdg9YMeaXvJLZeuJdw4fnLPrlASB9IEQ0USFzno7gzZ4On3rFwu76rMdPPd24vDdwQU0nOmtTEMyyzbUl9fhSMgst5hyVdZlG9CX6CH8+ayL/jfSq+jx/c4+Owq4r1vaibHdC/mHxEVp4FxxMI1qrVn/F0Jtzg4Iz8YYBNOC4gvhs40DGhsXflv8edtjzZ1Ep/dv2/eaYiLlODzrUfZAJLzK3XalvL2VTwedUtjVK6YdbUC1F5WWmEUa3UCZyq+lc7CTrb3qoMprMmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vGpVNCDmYpXhHvZYR/+qXzC678pUWxm2QCkzbvIBSpA=; b=kyRIknnPPhi6uIqGgPWKU4RCg0TgiWz+x0iMNiFgew8ZJJhnRAk3RgTHAncmndAWyZ07gzpMEe8CuAquEdz43S2YFu04LVjBlvkKoJYAhuBhLrl0AegMbFrLRZRqNpTab2BQUG7yu8S56PJZudl+LICJMxoXAKhAOZZPnMS9RtNP4/IYP+kTUgOLesVY9n8gjiPZ6ECA4LId0mGR/DdCzybAU/4kQOWvXGrSrwqJbh/c0E06oafZPsgQnHNOYKJvQiwd9vSGoLfuUhWqlWcDCjmOjde0RR7oy9mPgCnNHw26tN1+qd6MseHxvv+OjDyK9uaN9Aa2KXAOD9lqjQBGGA== Received: from IA2PR20MB7206.namprd20.prod.outlook.com (2603:10b6:208:4b4::17) by IA1PR20MB6296.namprd20.prod.outlook.com (2603:10b6:208:3db::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.11; Tue, 14 Jan 2025 14:37:52 +0000 Received: from IA2PR20MB7206.namprd20.prod.outlook.com ([fe80::1b5b:814d:7452:6dfe]) by IA2PR20MB7206.namprd20.prod.outlook.com ([fe80::1b5b:814d:7452:6dfe%4]) with mapi id 15.20.8356.010; Tue, 14 Jan 2025 14:37:52 +0000 From: Nir Lichtman To: Peter Zijlstra , Borislav Petkov CC: "dave.hansen@linux.intel.com" , "luto@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , "m.younesbadr@gmail.com" , Nir Lichtman Subject: RE: [PATCH v2 RESEND] x86/kaslr: Ingest nokaslr to avoid passing it to init process Thread-Topic: [PATCH v2 RESEND] x86/kaslr: Ingest nokaslr to avoid passing it to init process Thread-Index: AdtkMyzUrRI03hgHSm2cbmOTt2PbdACNKVCAAAYcegAAA235AAAAsFCg Date: Tue, 14 Jan 2025 14:37:52 +0000 Message-ID: References: <20250114093643.GK5388@noisy.programming.kicks-ass.net> <20250114123142.GCZ4ZZLiIBm2cMg9ny@fat_crate.local> <20250114140954.GR5388@noisy.programming.kicks-ass.net> In-Reply-To: <20250114140954.GR5388@noisy.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA2PR20MB7206:EE_|IA1PR20MB6296:EE_ x-ms-office365-filtering-correlation-id: 3c28296d-7140-4473-d38e-08dd34a906dc x-ms-exchange-slblob-mailprops: Cq7lScuPrnpFX5gNBgVui9nZ6J+Gucr/oPGYlpwWfLhqi9yS+REMwhqqHxs6W1szz0XBfFRUWkb1eUjSRW3EwbRcQSiZ3CTBjoQlIYs5QxTL7Iqqhnf8uNk4r2O02CkDcOQztdXNl3JXuv89NotOcPdf8kQj/8bof2olgWRxOjWA+tZ8+p80AMylhAoGIwsb6z9mLkK4gU4rI+22ve6+5InqQxPZyZ3OgQSRBypkZfNlU5imOHNFVQm2O+Wto0X5hZp/7u5N7nTV+UTD3PdsACoMa1IDJ0u+MtfRspm2ehy6Do4CgAWzlgWV/IbW88GIpGQ9aSwYFKr4jCv8h2iN6ku99k4RGfXSgoG7hbUuzvi4KIKKeHAN2Kq6LrLYvgbAaCetR/aX2+vmPjbciOoFO0Xt8gR8S1EjCvLCArekmQq5ObJL9iVCeS3JOWADNkF5CqSA/UZHAnofkBCvkaCW4kkhY5E0I0onwwJPbbviFIOfgbW9T4UlYee84BkiY3qyWnsqMzkhYjIEN9hNzolzRuGl2mdhi0g7w2oFu70DNSZyBlI+L9PKrr5XyWY2BS30i5LXkMauAh8ZxaC8FbFKyggjHsg4y/ADtYtKVlt8VsQalewFqey/TslvoWJzrHOj1l5ai1bIbQQ02kNlsbqhxv1A9+1XoRC+0drUc+75x2XVvd0eLjEctx2S3hXJovowEfNqrgiirGEkWdj31SvKBKribPZb5ED1XlRE4HddXkZ8/c/f+hnEUZMLfJqOyFRKJYpstWQLO+w= x-microsoft-antispam: BCL:0;ARA:14566002|15080799006|8062599003|461199028|8060799006|7092599003|19110799003|56899033|102099032|440099028|3412199025; x-microsoft-antispam-message-info: =?us-ascii?Q?EvNsAoXlb3xfMUZixZZqg+/uKcnCxxJt/Gx2m5GOBpkVAqg48hyK+3La27ZH?= =?us-ascii?Q?QYen1lY3PXMbWZ1wcIazx3p7t+3fCeIeGVl2LwM0o1RFuqnu2EiAIx+AMrg5?= =?us-ascii?Q?yAoXyVrwVvADm2x7ow1bEJ0K544tVzd7boB74xUa25YVX5US3ioiJdm0/u1x?= =?us-ascii?Q?VsecBfZ8bga+kum04J+e0DIu6p0s28nEKH1mP77xQV8AeDFOS2SqBsKwqrFy?= =?us-ascii?Q?u/7rfRFsHJS/pUplxUjLNBNu1MxNkKGI05eibVAk1ABTtXaqjeb/Yp/hF67w?= =?us-ascii?Q?58L/5s/xcB7m9ZHH7aT/70ypbNcTkJjs8EzLBAVe5XKs7v6Uwa00q4NNKjK6?= =?us-ascii?Q?Vu181/IefiJPkZQ548hKZMX7AChV7/kgRKfQE5Qn8gFkGfkqfA9LGF5UVZ29?= =?us-ascii?Q?J1udNQ7SicjYbF89yMrz6Ak6HeLrZFjM31qvOvAm2Na7U7XlV55/URV+Xuwd?= =?us-ascii?Q?m2ZwIB9CBCwmTjlWQfW9xdWdhgKbwQoaErRFUrHqd5yEAExIc0H98R4q2soE?= =?us-ascii?Q?pJ7ehOjASQnAx2XyCvAzDCTMF+4+jT8dTgKgSy+WLB8DkQRz3rIB5Y3XSvsn?= =?us-ascii?Q?lX5COshws1Y3pkwLpY8Ambmekn+quGYtG/ZQ0FVqxLcOLG9JBU9dNI6yc9hF?= =?us-ascii?Q?l+Ihahu/m4rYD1poNKoTz5olL/YgIBvtwVksSeipgedg9ZsipgJ1Eu4nsFgO?= =?us-ascii?Q?KOPFL6LZGmVft9LY5bpeTSyAxHwUY2tZqkRLT40/Z3W3OfgxyMLvTwsmQ0Gw?= =?us-ascii?Q?D0txv1gOSRUFXsxFGeBnHu+y2VwP52cIztLildWxSKmOjRc6UuYUeVz5Yj00?= =?us-ascii?Q?+KHfYeXsrVDuK2Slb2CnruBuGQFlwWdx3II0CgK6r2/encdHoNmEG1EjnYSM?= =?us-ascii?Q?5SeleuA8xIkMVlrEuqBpRDD2Imp9t9V1cPEGvse0wGJojwG8p1CPfsSPmcbD?= =?us-ascii?Q?1vQbdEVV4lM7jh05F9ppnE0KdaLrN6zHyi6vRQkNLUo+yI6JHzc9basU/SMi?= =?us-ascii?Q?31u/A5lH9w/GDmbWTEkTYwBCzrXLK0N8V3mYBCUJS2H096tC+XauiftlgroR?= =?us-ascii?Q?zyVySSJO0pS0ecpw+vvGnJeusLJPrg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S/sWkEr44xsdomBsFpkymNVEvfGMfk5FDw05L4+SQALRCKrV8FAMQbVI0eZm?= =?us-ascii?Q?JAfnxAaH+KCHLxcUH3kUlvqGKlz0LChPv60y/SbD1CkxuRCvGiMWdSWUQxKH?= =?us-ascii?Q?MvFKhdwMOdRvALfdt4FXwQoERxTYdvjzi+7u5fWgCfkvoHA74+EiSKpk3tHI?= =?us-ascii?Q?u2F6tC1BMhrEkElwFQzzH211X8H9JfJggNqjW5fDGMy1lKuvKK1Fownd1qq5?= =?us-ascii?Q?doAKHl22hwxF7Az40wW0upBkCN8e8Bi9RHpCrWbta8UHgVtQHU6zkQBO8+r1?= =?us-ascii?Q?aWOjgROhvz8RaTRkOP13+p4eWSbmlkbkUh1+oORcT0E+PJWpWjtWhFbarQzN?= =?us-ascii?Q?GU5lvaPW+F54FlpIfNK94FAPdca2Co8znvjsOQioZ5aAMNAmkB6S2s1ph+Cg?= =?us-ascii?Q?2OiKPUx9xjINL2kUWooO6bXAOLFYD1kWrhovN0vxwu9MqO9Kkx1ush72a3Nc?= =?us-ascii?Q?eDIbpV4BvRgf5X6ZO4pFP9bgTO3UlQkh9jJCYN1RAyNdXiqihzJdPrkLXeXl?= =?us-ascii?Q?AL12wqZvzIdlj2wYV5oIeMGMmEnME3f1g/JLkJ6t5ufJGZB6gurVFSK10iil?= =?us-ascii?Q?UJCjxf1caqw9ffgU//r70HoZjtY9YE4U8JtHlFNUnKatUGp+MsZ2GcLsI06/?= =?us-ascii?Q?lI9x96J3NwRosVU+5hBTlO4ZKFj1T6UQa/gTtDGf3FeVByKQSRkUYlW42rP8?= =?us-ascii?Q?trxkLi+VLs//m5/b3coiNGXicBzvM0Vz+FyU6L2EhrVDZIb78YNbVeSDDjtP?= =?us-ascii?Q?JX/Kd5RMNAOIttOGhObsoGz/jW7TDKXAgGlX53DxfloYlhZnAlux8KoWpwYI?= =?us-ascii?Q?XJkNNHLxkO5ntOL5mNXmCVUqN4qZf8Up/qLGjQyz6ae3HkyUTKiZXW0gr8w+?= =?us-ascii?Q?GBSHjCBVqw21LrhU27TFBF931mjjMrdCTp41q1xJiNkYmsKsM7lTiSCjiOoG?= =?us-ascii?Q?1M7qaBmXrg7wORLI9ZAqDgncC5NTaZg3Sw7aH5ZWNDhrCtwi1p8timr604PZ?= =?us-ascii?Q?xIAP5GnSvkaG7rNLepmdKFMgkqQbe/6ESJDaJfla/MiAkVs7aZ6aqy99I0eb?= =?us-ascii?Q?r1seeB5yfiSk+EpRSqmmqLo+/HX506irtN2PX7Bd6cxgdhBdU8M0lRdLIkww?= =?us-ascii?Q?mNnfSMFoXJ9NifLE7PyUWBynEjRTD2XWpLxLwuqVq6FwUpEWeP0eNIXW+oAB?= =?us-ascii?Q?X+ohYajC9F2R3xgKOuRDIWhwhOiiw0lRcpaaZKt03T2pTNBYIK5L0Z7hPRM?= =?us-ascii?Q?=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-0b924.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA2PR20MB7206.namprd20.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 3c28296d-7140-4473-d38e-08dd34a906dc X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2025 14:37:52.5486 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR20MB6296 > On Tue, Jan 14, 2025 at 01:31:42PM +0100, Borislav Petkov wrote: > > On Tue, Jan 14, 2025 at 10:36:43AM +0100, Peter Zijlstra wrote: > > > On Sat, Jan 11, 2025 at 02:17:43PM +0000, Nir Lichtman wrote: > > > > Problem: Currently booting the kernel with "nokaslr" on x86 > > > > incorrectly doesn't recognize this parameter and passes it on to > > > > the init process > > > > > > What now? I'm pretty sure nokaslr works, it's in all my test > > > machines and qemu scripts. Without it faddr2line wouldn't work, > > > which I would notice in a hurry. > > > > Yeah, the param itself works - he doesn't want to pass it on to the > > init process because then it says: > > > > [ 0.073613] Unknown kernel command line parameters "nokaslr", will b= e > passed to user space. > > > > due to our detection of which parameters got eaten and which didn't. >=20 > I had never noticed; random machine of mine says: >=20 > [ 0.591565] Unknown kernel command line parameters "force_early_printk > nokaslr kgdboc=3DttyS0", will be passed to user space. >=20 > *shrug*, who cares. I agree that the warning is not a big deal, thing is the kernel has a fallb= ack behavior in which unrecognized boot parameters are passed to the init process, this = causes the nokaslr to be passed to the init process, you probably haven't stumbled= upon this since it may be swallowed in your system, but when I made an initramfs= with bash as the init process, bash got the nokaslr as an argument and crashed since = it treated it as a file. Borslav, print_unknown_bootoptions is an interesting alternative idea, I could amend this patch to swallow the early parameters over there, Thing is this, from what I understand it would require the code to keep a list of possible early parameters and check if one of them arrived into t= he print_unknown_bootoptions function and if so swallow in that function, what do you think about this idea, to implement this? Thanks, Nir