mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Song, Yoong Siang" <yoong.siang.song@intel.com>
To: Brett Creeley <bcreeley@amd.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Richard Cochran <richardcochran@gmail.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	"Gomes, Vinicius" <vinicius.gomes@intel.com>,
	Jonathan Corbet <corbet@lwn.net>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
	Shinas Rasheed <srasheed@marvell.com>,
	"Tian, Kevin" <kevin.tian@intel.com>,
	Brett Creeley <brett.creeley@amd.com>,
	"Blanco Alcaine, Hector" <hector.blanco.alcaine@intel.com>,
	"Hay, Joshua A" <joshua.a.hay@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"Keller, Jacob E" <jacob.e.keller@intel.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	"Marcin Szycik" <marcin.szycik@linux.intel.com>
Cc: "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH iwl-next,v2 1/1] igc: Add wildcard rule support to ethtool NFC using Default Queue
Date: Fri, 20 Jun 2025 08:30:47 +0000	[thread overview]
Message-ID: <IA3PR11MB925440EB3352EC0E164DBB06D87CA@IA3PR11MB9254.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5b77d33a-5668-42bc-802d-d2c5d95c1e7e@amd.com>

On Thursday, June 19, 2025 11:49 PM, Brett Creeley <bcreeley@amd.com> wrote:
>On 6/19/2025 8:37 AM, Song Yoong Siang wrote:
>> diff --git a/drivers/net/ethernet/intel/igc/igc.h
>b/drivers/net/ethernet/intel/igc/igc.h
>> index 1525ae25fd3e..c580ecc954be 100644
>> --- a/drivers/net/ethernet/intel/igc/igc.h
>> +++ b/drivers/net/ethernet/intel/igc/igc.h
>> @@ -406,10 +406,6 @@ extern char igc_driver_name[];
>>   #define IGC_FLAG_RSS_FIELD_IPV4_UDP    BIT(6)
>>   #define IGC_FLAG_RSS_FIELD_IPV6_UDP    BIT(7)
>>
>> -#define IGC_MRQC_ENABLE_RSS_MQ         0x00000002
>> -#define IGC_MRQC_RSS_FIELD_IPV4_UDP    0x00400000
>> -#define IGC_MRQC_RSS_FIELD_IPV6_UDP    0x00800000
>> -
>
>Small nit, but moving these fields seems like a separate patch since
>moving them isn't part of the wildcard rule changes.
>
>Thanks,
>
>Brett

Hi Brett,

Thanks for reviewing the patch.
No problem, I can split the patch into two and submit v3.

Thanks & Regards
Siang

  reply	other threads:[~2025-06-20  8:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-19 15:37 Song Yoong Siang
2025-06-19 15:49 ` Brett Creeley
2025-06-20  8:30   ` Song, Yoong Siang [this message]
2025-06-20  7:45 ` Kurt Kanzenbach
2025-06-20  8:23   ` Song, Yoong Siang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=IA3PR11MB925440EB3352EC0E164DBB06D87CA@IA3PR11MB9254.namprd11.prod.outlook.com \
    --to=yoong.siang.song@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=bcreeley@amd.com \
    --cc=brett.creeley@amd.com \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=hector.blanco.alcaine@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=john.fastabend@gmail.com \
    --cc=joshua.a.hay@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.szycik@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=richardcochran@gmail.com \
    --cc=srasheed@marvell.com \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®