From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50AAFC433F5 for ; Tue, 26 Oct 2021 17:02:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3486F60E08 for ; Tue, 26 Oct 2021 17:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237679AbhJZREn (ORCPT ); Tue, 26 Oct 2021 13:04:43 -0400 Received: from ixit.cz ([94.230.151.217]:43048 "EHLO ixit.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237663AbhJZREl (ORCPT ); Tue, 26 Oct 2021 13:04:41 -0400 Received: from [192.168.1.138] (ip-89-176-96-70.net.upcbroadband.cz [89.176.96.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ixit.cz (Postfix) with ESMTPSA id 7153320064; Tue, 26 Oct 2021 19:02:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixit.cz; s=dkim; t=1635267734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yr9uhClX24/LPzr3j28xMSkldVyzrS/jPB9TXwItW/Q=; b=Yh5h1/PdyDWYWMmGnNH2FK2FhyIlEnkwGw/C5a4HremTpgkN5mF+shIUq80pTLKyljAKVi 0rbvXGc7e4SnG0rbRzaZlDW1ksWR91fy6mltEPxmWSeL0mi77v4wuRJgqzz9y47YhsqY74 FYU1fCsxFsOBNdo6eg+N3BR5FASsJJs= Date: Tue, 26 Oct 2021 19:02:07 +0200 From: David Heidelberg Subject: Re: [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus To: Alex Elder Cc: Andy Gross , Bjorn Andersson , "David S. Miller" , Jakub Kicinski , Rob Herring , Alex Elder , ~okias/devicetree@lists.sr.ht, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <2de53575-af6e-5bb9-e7ad-5d924656867d@ieee.org> References: <20211026163240.131052-1-david@ixit.cz> <2de53575-af6e-5bb9-e7ad-5d924656867d@ieee.org> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org thanks, I'll try to work on my commit messages :) David On Tue, Oct 26 2021 at 11:47:46 -0500, Alex Elder wrote: > On 10/26/21 11:32 AM, David Heidelberg wrote: >> Fix warnings as: >> arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml: ipa@1e40000: iommus: [[21, >> 1504, 0], [21, 1506, 0]] is too long >> From schema: Documentation/devicetree/bindings/net/qcom,ipa.yaml >> >> Signed-off-by: David Heidelberg > > Looks good to me. I'm not sure why the minItems is required, > unless it's to indicate that it must be at least 1 and can't > be missing. But iommus is also stated to be required elsewhere > in the binding. > > In the future, it's helpful to indicate the command you > used to produce the warning in your commit message. And > furthermore, describing the problem (and not just including > the error message) is even more helpful. > > Reviewed-by: Alex Elder > >> --- >> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml >> b/Documentation/devicetree/bindings/net/qcom,ipa.yaml >> index b8a0b392b24e..b86edf67ce62 100644 >> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml >> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml >> @@ -64,7 +64,8 @@ properties: >> - const: gsi >>  iommus: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 2 >>  clocks: >> maxItems: 1 >> >