From: James Morris <jmorris@namei.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] selinux: don't enable minimum mmap checking by default
Date: Thu, 28 Jun 2007 11:40:39 -0400 (EDT) [thread overview]
Message-ID: <Line.LNX.4.64.0706281139010.13114@localhost.localdomain> (raw)
In-Reply-To: <20070628012749.caf450f6.akpm@linux-foundation.org>
Don't enable minimum mmap checking by default in SELinux, as it may break
existing applications which do not have updated policy.
We will be able to enable it by default later, once we have code to handle
new permissions which are not present in the user's policy.
Signed-off-by: James Morris <jmorris@namei.org>
---
This is an updated version of the patch, essentially a reverting an
earlier patch which I'll drop once this are settles down.
security/selinux/hooks.c | 16 ----------------
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 4b0ecfd..8575555 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -112,9 +112,6 @@ int selinux_enabled = 1;
/* Original (dummy) security module. */
static struct security_operations *original_ops = NULL;
-/* Did we enable minimum mmap address checking? */
-static int enabled_mmap_min_addr;
-
/* Minimal support for a secondary security module,
just to allow the use of the dummy or capability modules.
The owlsm module can alternatively be used as a secondary
@@ -4917,15 +4914,6 @@ static __init int selinux_init(void)
sizeof(struct inode_security_struct),
0, SLAB_PANIC, NULL, NULL);
- /*
- * Tasks cannot mmap below this without the mmap_zero permission.
- * If not enabled already, do so by setting it to 64KB.
- */
- if (mmap_min_addr == 0) {
- enabled_mmap_min_addr = 1;
- mmap_min_addr = 65536;
- }
-
avc_init();
original_ops = secondary_ops = security_ops;
@@ -5076,10 +5064,6 @@ int selinux_disable(void)
selinux_disabled = 1;
selinux_enabled = 0;
- /* Disable minimum mmap address check only if we enabled it */
- if (enabled_mmap_min_addr)
- mmap_min_addr = 0;
-
/* Reset security_ops to the secondary module, dummy or capability. */
security_ops = secondary_ops;
--
1.5.0.6
next prev parent reply other threads:[~2007-06-28 15:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 20:38 [PATCH 1/7] ICH Force HPET: Make generic time capable of switching broadcast timer Venki Pallipadi
2007-06-23 16:52 ` Andrew Morton
2007-06-23 23:17 ` Thomas Gleixner
2007-06-28 7:12 ` Andrew Morton
2007-06-28 8:27 ` Andrew Morton
2007-06-28 12:12 ` James Morris
2007-06-28 17:56 ` Andrew Morton
2007-06-28 12:45 ` Eric Paris
2007-06-28 18:02 ` Andrew Morton
2007-06-28 18:55 ` James Morris
2007-06-28 15:40 ` James Morris [this message]
2007-06-28 15:41 ` [PATCH 2/2] security: move mmap_min_addr sysctl to /proc/sys/vm James Morris
2007-06-28 19:05 ` Alexey Dobriyan
2007-06-28 19:12 ` James Morris
2007-06-28 15:45 ` [PATCH 1/2] selinux: don't enable minimum mmap checking by default Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Line.LNX.4.64.0706281139010.13114@localhost.localdomain \
--to=jmorris@namei.org \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome