mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Morris <jmorris@namei.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/11] security: Protection for exploiting null dereference using mmap
Date: Tue, 10 Jul 2007 09:10:48 -0400 (EDT)	[thread overview]
Message-ID: <Line.LNX.4.64.0707100910270.14361@d.namei> (raw)
In-Reply-To: <Pine.LNX.4.64.0707100951140.11053@fbirervta.pbzchgretzou.qr>

On Tue, 10 Jul 2007, Jan Engelhardt wrote:

> 
> On Jul 8 2007 22:59, James Morris wrote:
> >@@ -420,8 +420,12 @@ static int dummy_file_ioctl (struct file *file, unsigned int command,
> > 
> > static int dummy_file_mmap (struct file *file, unsigned long reqprot,
> > 			    unsigned long prot,
> >-			    unsigned long flags)
> >+			    unsigned long flags,
> >+			    unsigned long addr,
> >+			    unsigned long addr_only)
> > {
> >+	if (addr < mmap_min_addr)
> >+		return -EACCES;
> > 	return 0;
> > }
> > 
> 
> Not -EPERM?

No, EACCES is what's used.


-- 
James Morris
<jmorris@namei.org>

  reply	other threads:[~2007-07-10 13:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-09  2:54 [PATCH 0/11] SELinux patches for 2.6.23 James Morris
2007-07-09  2:55 ` [PATCH 01/11] selinux: add support for querying object classes and permissions from the running policy James Morris
2007-07-09  2:56 ` [PATCH 02/11] selinux: rename sel_remove_bools() for more general usage James Morris
2007-07-09  2:56 ` [PATCH 03/11] selinux: change sel_make_dir() to specify inode counter James Morris
2007-07-09  2:57 ` [PATCH 04/11] selinux: add selinuxfs structure for object class discovery James Morris
2007-07-09  2:58 ` [PATCH 05/11] security: revalidate rw permissions for sys_splice and sys_vmsplice James Morris
2007-07-12  2:04   ` James Morris
2007-07-12  6:13     ` Jens Axboe
2007-07-09  2:58 ` [PATCH 06/11] selinux: introduce schedule points in policydb_destroy() James Morris
2007-07-09  2:59 ` [PATCH 08/11] SELinux: Use %lu for inode->i_no when printing avc James Morris
2007-07-09  2:59 ` [PATCH 09/11] security: Protection for exploiting null dereference using mmap James Morris
2007-07-10  7:52   ` Jan Engelhardt
2007-07-10 13:10     ` James Morris [this message]
2007-07-09  3:00 ` [PATCH 10/11] SELinux: use SECINITSID_NETMSG instead of SECINITSID_UNLABELED for NetLabel James Morris
2007-07-09  3:01 ` [PATCH 11/11] security: unexport mmap_min_addr James Morris
2007-07-09  3:02 ` [PATCH 07/11] SELinux: allow preemption between transition permission checks James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Line.LNX.4.64.0707100910270.14361@d.namei \
    --to=jmorris@namei.org \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome