Hi,

Am Samstag, 10. Oktober 2026, 14:59:38 Mitteleuropäische Sommerzeit schrieb 
Navid Ghahremani:
> This series introduces mainline Linux support for the Sanechips (ZTE)
> ZX279128S SoC and the ZTE ZXHN H3600 Wi-Fi 6 router.
> 
> The ZX279128S is a dual-core ARM Cortex-A9 network SoC with an ARM PL310 /
> L2C-310 outer cache controller, dual PCIe interfaces, a 5-port Gigabit
> Ethernet switch with hardware packet classification and flow offload,
> SPI-NAND flash controller, and DWC3 USB 2.0 host.

First of all it is nice to see more interest in the ZTE zx hardware and it 
looks like there is a considerable driver reuse potential between zx27 and 
zx29.

I replied to individual patches with technical points. For the PCIe and 
Ethernet/MDIO parts I can't say much as I don't have experience with these 
buses.

My overarching concern with the series is that it largely looks like an LLM 
translation of ZTE's downstream sources. I don't see a problem with LLM use 
per se, but the question is how well Navid understands the hardware and can 
handle cases where ZTE's code is wrong or misleading (I certainly ran into 
this on zx29) and make independent judgement calls.

What I'd like to see is an improved clock driver that fills some of the 
hardware understanding gaps I pointed out in patch 7 and a pinmux driver that 
goes beyond a few hardcoded values.

Cheers,
Stefan