mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen Wang <unicorn_wang@outlook.com>
To: Rob Herring <robh@kernel.org>, Chen Wang <unicornxw@gmail.com>
Cc: guoren@kernel.org, robh+dt@kernel.org, samuel.holland@sifive.com,
	jszhang@kernel.org, linux-kernel@vger.kernel.org,
	mturquette@baylibre.com, richardcochran@gmail.com,
	paul.walmsley@sifive.com, conor@kernel.org,
	inochiama@outlook.com, linux-clk@vger.kernel.org,
	palmer@dabbelt.com, sboyd@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, xiaoguang.xing@sophgo.com,
	devicetree@vger.kernel.org, chao.wei@sophgo.com,
	aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
	haijiao.liu@sophgo.com
Subject: Re: [PATCH v3 1/4] dt-bindings: soc: sophgo: Add Sophgo system control module
Date: Tue, 5 Dec 2023 07:39:49 +0800	[thread overview]
Message-ID: <MA0P287MB033232CAFAC0C3D638C3AC57FE86A@MA0P287MB0332.INDP287.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <170169991797.1225669.8378193409195638634.robh@kernel.org>


On 2023/12/4 22:25, Rob Herring wrote:
> On Mon, 04 Dec 2023 20:54:53 +0800, Chen Wang wrote:
>> From: Chen Wang <unicorn_wang@outlook.com>
>>
>> Add documentation to describe Sophgo System Controller for SG2042.
>>
>> Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
>> ---
>>   .../soc/sophgo/sophgo,sg2042-sysctrl.yaml     | 35 +++++++++++++++++++
>>   1 file changed, 35 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml
>>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.example.dtb: /example-0/system-controller@30010000: failed to match any schema with compatible: ['sophgo,sg2042-sysctl']
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/14616bce163d689a4e640ab7b372421ca8306a92.1701691923.git.unicorn_wang@outlook.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.

Thanks, Rob.

My fault and I wrote the compatible string in example incorrectly.

"DT_CHECKER_FLAGS=-m" is very good and do help efficiently catching this 
misspell issue not easy to find. Learned and thanks again. I will 
correct this.


  reply	other threads:[~2023-12-04 23:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04 12:54 [PATCH v3 0/4] riscv: sophgo: add clock support for sg2042 Chen Wang
2023-12-04 12:54 ` [PATCH v3 1/4] dt-bindings: soc: sophgo: Add Sophgo system control module Chen Wang
2023-12-04 14:25   ` Rob Herring
2023-12-04 23:39     ` Chen Wang [this message]
2023-12-04 12:55 ` [PATCH v3 2/4] dt-bindings: clock: sophgo: Add SG2042 bindings Chen Wang
2023-12-04 12:56 ` [PATCH v3 3/4] clk: sophgo: Add SG2042 clock generator driver Chen Wang
2023-12-04 12:56 ` [PATCH v3 4/4] riscv: dts: add clock generator for Sophgo SG2042 SoC Chen Wang
2023-12-04 23:58 ` [PATCH v3 0/4] riscv: sophgo: add clock support for sg2042 Chen Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MA0P287MB033232CAFAC0C3D638C3AC57FE86A@MA0P287MB0332.INDP287.PROD.OUTLOOK.COM \
    --to=unicorn_wang@outlook.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=chao.wei@sophgo.com \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=guoren@kernel.org \
    --cc=haijiao.liu@sophgo.com \
    --cc=inochiama@outlook.com \
    --cc=jszhang@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=sboyd@kernel.org \
    --cc=unicornxw@gmail.com \
    --cc=xiaoguang.xing@sophgo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®