mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen Wang <unicorn_wang@outlook.com>
To: xiaopeitux@foxmail.com, Pei Xiao <xiaopei01@kylinos.cn>
Cc: sboyd@kernel.org, mturquette@baylibre.com, inochiama@gmail.com,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: sophgo: Fixes Coccinelle/coccicheck warnings reported by do_div.cocci.
Date: Mon, 7 Apr 2025 17:01:08 +0800	[thread overview]
Message-ID: <MA0P287MB226200F09E78C592897C8FFFFEAA2@MA0P287MB2262.INDP287.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <tencent_D5D35C992B70843CF70F5533E49717D24906@qq.com>


On 2025/4/7 11:21, xiaopeitux@foxmail.com wrote:
> From: Pei Xiao <xiaopei01@kylinos.cn>
>
> cocci warnings:
>      drivers/clk/sophgo/clk-sg2042-pll.c:217:1-7: WARNING:
>      do_div() does a 64-by-32 division, please consider using div64_ul
>      instead.
>
>      drivers/clk/sophgo/clk-sg2042-pll.c:160:1-7: WARNING:
>      do_div() does a 64-by-32 division, please consider using div64_u64
>      instead.
>
> replace do_div() with div64_*() which doesn't implicitly cast the divisor.

hi Pei,I'm not sure if you discovered this issue via the test robot, see 
this: https://lore.kernel.org/lkml/202504051456.niworhgJ-lkp@intel.com/. 
If so, please add its Reported-by signature in the commit as required. 
Otherwise please ignore my input.

As per this patch itself, LGTM.

Reviewed-by: Chen Wang <wangchen20@iscas.ac.cn>


>
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> ---
>   drivers/clk/sophgo/clk-sg2042-pll.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/sophgo/clk-sg2042-pll.c b/drivers/clk/sophgo/clk-sg2042-pll.c
> index 1537f4f05860..e5fb0bb7ac4f 100644
> --- a/drivers/clk/sophgo/clk-sg2042-pll.c
> +++ b/drivers/clk/sophgo/clk-sg2042-pll.c
> @@ -155,7 +155,7 @@ static unsigned long sg2042_pll_recalc_rate(unsigned int reg_value,
>   
>   	numerator = (u64)parent_rate * ctrl_table.fbdiv;
>   	denominator = ctrl_table.refdiv * ctrl_table.postdiv1 * ctrl_table.postdiv2;
> -	do_div(numerator, denominator);
> +	numerator =  div64_u64(numerator, denominator);
>   	return numerator;
>   }
>   
> @@ -212,7 +212,7 @@ static int sg2042_pll_get_postdiv_1_2(unsigned long rate,
>   	tmp0 *= fbdiv;
>   
>   	/* ((prate/REFDIV) x FBDIV)/rate and result save to tmp0 */
> -	do_div(tmp0, rate);
> +	tmp0 = div64_ul(tmp0, rate);
>   
>   	/* tmp0 is POSTDIV1*POSTDIV2, now we calculate div1 and div2 value */
>   	if (tmp0 <= 7) {

  parent reply	other threads:[~2025-04-07  9:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07  3:21 xiaopeitux
2025-04-07  3:55 ` Inochi Amaoto
2025-04-07  9:01 ` Chen Wang [this message]
2025-04-25 13:06 ` Chen Wang
2025-06-19 23:50 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MA0P287MB226200F09E78C592897C8FFFFEAA2@MA0P287MB2262.INDP287.PROD.OUTLOOK.COM \
    --to=unicorn_wang@outlook.com \
    --cc=inochiama@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=xiaopei01@kylinos.cn \
    --cc=xiaopeitux@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®