From: Chen Wang <unicorn_wang@outlook.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Chen Wang <unicornxw@gmail.com>,
aou@eecs.berkeley.edu, conor+dt@kernel.org, guoren@kernel.org,
inochiama@outlook.com, jszhang@kernel.org,
krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com,
paul.walmsley@sifive.com, robh@kernel.org,
ulf.hansson@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-riscv@lists.infradead.org, chao.wei@sophgo.com,
haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com,
tingzhu.wang@sophgo.com
Subject: Re: [PATCH v3 2/4] mmc: sdhci-of-dwcmshc: unify the naming of soc helper functions
Date: Tue, 18 Jun 2024 08:13:09 +0800 [thread overview]
Message-ID: <MA0P287MB2822987797BDC01D4FFBF8C6FECE2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <aff10a8c-bac8-49ba-af0b-3681961eff80@intel.com>
On 2024/6/14 18:18, Adrian Hunter wrote:
> On 13/06/24 04:42, Chen Wang wrote:
>> From: Chen Wang <unicorn_wang@outlook.com>
>>
>> Continue another patch: "mmc: sdhci-of-dwcmshc: adjust positions
>> of helper routines".
>>
>> The helper functions at the dwcmshc level are all prefixed with
>> "dwcmshc_", which is easier to identify, while the functions at
>> the soc level are more confusing. Now they are uniformly prefixed
>> with the soc type string, such as "rk35xx_", "th1520_", etc.
> This does not seem to be necessary.
>
> Unnecessarily churning the code makes backports more difficult and
> complicates the code history, so it should be avoided in general.
Accepted.
[......]
next prev parent reply other threads:[~2024-06-18 0:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 1:42 [PATCH v3 0/4] mmc: sdhci-of-dwcmshc: enhance framework Chen Wang
2024-06-13 1:42 ` [PATCH v3 1/4] mmc: sdhci-of-dwcmshc: adjust positions of helper routines Chen Wang
2024-06-14 10:16 ` Adrian Hunter
2024-06-18 0:13 ` Chen Wang
2024-06-13 1:42 ` [PATCH v3 2/4] mmc: sdhci-of-dwcmshc: unify the naming of soc helper functions Chen Wang
2024-06-14 10:18 ` Adrian Hunter
2024-06-18 0:13 ` Chen Wang [this message]
2024-06-13 1:43 ` [PATCH v3 3/4] mmc: sdhci-of-dwcmshc: extract init function for rk35xx/th1520 Chen Wang
2024-06-14 10:33 ` Adrian Hunter
2024-06-18 0:04 ` Chen Wang
2024-06-13 1:43 ` [PATCH v3 4/4] mmc: sdhci-of-dwcmshc: add callback functions for dwcmshc Chen Wang
2024-06-14 10:52 ` Adrian Hunter
2024-06-18 0:07 ` Chen Wang
2024-06-16 2:30 ` [PATCH v3 0/4] mmc: sdhci-of-dwcmshc: enhance framework Drew Fustini
2024-06-18 0:12 ` Chen Wang
2024-06-17 14:18 ` Jisheng Zhang
2024-06-18 0:08 ` Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MA0P287MB2822987797BDC01D4FFBF8C6FECE2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM \
--to=unicorn_wang@outlook.com \
--cc=adrian.hunter@intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=haijiao.liu@sophgo.com \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=tingzhu.wang@sophgo.com \
--cc=ulf.hansson@linaro.org \
--cc=unicornxw@gmail.com \
--cc=xiaoguang.xing@sophgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®