From: Chen Wang <unicorn_wang@outlook.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Chen Wang <unicornxw@gmail.com>,
aou@eecs.berkeley.edu, chao.wei@sophgo.com, conor@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
palmer@dabbelt.com, paul.walmsley@sifive.com,
richardcochran@gmail.com, robh+dt@kernel.org, sboyd@kernel.org,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com,
guoren@kernel.org, jszhang@kernel.org, inochiama@outlook.com,
samuel.holland@sifive.com
Subject: Re: [PATCH v8 2/5] dt-bindings: soc: sophgo: Add Sophgo system control module
Date: Thu, 18 Jan 2024 13:29:09 +0800 [thread overview]
Message-ID: <MA0P287MB2822FBA18674540BA85035BDFE712@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <MA0P287MB282232DC6DF6290F5520BA89FE732@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
On 2024/1/16 19:37, Chen Wang wrote:
>
> On 2024/1/16 18:06, Krzysztof Kozlowski wrote:
>> On 16/01/2024 08:21, Chen Wang wrote:
>>> From: Chen Wang <unicorn_wang@outlook.com>
>>>
>>> Add documentation to describe Sophgo System Control for SG2042.
>>>
>>> Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
>>> ---
>>> .../soc/sophgo/sophgo,sg2042-sysctrl.yaml | 46
>>> +++++++++++++++++++
>>> 1 file changed, 46 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml
>>> b/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml
>>>
>>> new file mode 100644
>>> index 000000000000..7b50bb56b4cf
>>> --- /dev/null
>>> +++
>>> b/Documentation/devicetree/bindings/soc/sophgo/sophgo,sg2042-sysctrl.yaml
>>> @@ -0,0 +1,46 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id:
>>> http://devicetree.org/schemas/soc/sophgo/sophgo,sg2042-sysctrl.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Sophgo SG2042 SoC system control
>>> +
>>> +maintainers:
>>> + - Chen Wang <unicorn_wang@outlook.com>
>>> +
>>> +description:
>>> + The Sophgo system control is a registers block (SYS_CTRL),
>>> providing multiple
>>> + low level platform functions like chip configuration, clock
>>> control, etc.
>>> +
>>> +properties:
>>> + compatible:
>>> + const: sophgo,sg2042-sysctrl
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + clock-controller:
>>> + # Child node
>> Drop the comment, it is obvious. It cannot be anything else.
>>
>>> + $ref: /schemas/clock/sophgo,sg2042-sysclk.yaml#
>>> + type: object
>> Why isn't this merged here? You do not need the child node really...
>> unless the clock inputs are specific to that clock controller and you
>> will have here more devices? But where are they in such case?
> I don't see more devices will be included later. It should be ok to
> merge them into one.
hi, Krzysztof,
After some double check, I find we will have more devices in
system-control. For example, in the SYS_CTRL area, there is also a
section of registers used to control the "General Purpose Interrupt".
The pcie controller of sg2042 will use this interrupt controller which
is defined in SYS_CTRL, we will add it in later work.
Specifically, the distribution (offset) of registers in SYS_CTRL is as
follows:
- 0x0C0 ~ 0x0FC: for some PLL clocks :
- ......
- 0x2E0 ~ 0x30C: for General Purpose Interrupt:
- ......
- 0x368 ~ 0x3FC: For some gate clocks
So it seems that it is still necessary to keep the current child node
method, and it will also facilitate future expansion.
What do you think, please feel free let me know.
Thanks,
Chen
next prev parent reply other threads:[~2024-01-18 5:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 7:20 [PATCH v8 0/5] riscv: sophgo: add clock support for sg2042 Chen Wang
2024-01-16 7:20 ` [PATCH v8 1/5] dt-bindings: clock: sophgo: add sysclk for SG2042 Chen Wang
2024-01-16 10:09 ` Krzysztof Kozlowski
2024-01-16 7:21 ` [PATCH v8 2/5] dt-bindings: soc: sophgo: Add Sophgo system control module Chen Wang
2024-01-16 10:06 ` Krzysztof Kozlowski
2024-01-16 11:37 ` Chen Wang
2024-01-16 12:15 ` Krzysztof Kozlowski
2024-01-18 5:29 ` Chen Wang [this message]
2024-01-22 3:41 ` Chen Wang
2024-01-22 8:10 ` Krzysztof Kozlowski
2024-01-22 10:11 ` Chen Wang
2024-01-22 12:56 ` Krzysztof Kozlowski
2024-01-23 9:28 ` Chen Wang
2024-01-16 7:21 ` [PATCH v8 3/5] dt-bindings: clock: sophgo: add clkgen for SG2042 Chen Wang
2024-01-16 7:22 ` [PATCH v8 4/5] clk: sophgo: Add SG2042 clock generator driver Chen Wang
2024-01-16 7:22 ` [PATCH v8 5/5] riscv: dts: add clock generator for Sophgo SG2042 SoC Chen Wang
2024-01-16 9:47 ` [PATCH v8 0/5] riscv: sophgo: add clock support for sg2042 Krzysztof Kozlowski
2024-01-16 11:39 ` Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MA0P287MB2822FBA18674540BA85035BDFE712@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM \
--to=unicorn_wang@outlook.com \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=haijiao.liu@sophgo.com \
--cc=inochiama@outlook.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=sboyd@kernel.org \
--cc=unicornxw@gmail.com \
--cc=xiaoguang.xing@sophgo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®