From: Paul Cercueil <paul@crapouillou.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: ingenic: correct unit node address
Date: Thu, 17 Mar 2022 14:53:10 +0000 [thread overview]
Message-ID: <MC9W8R.BUBMZ3NYL78N2@crapouillou.net> (raw)
In-Reply-To: <20220317115259.448868-1-krzysztof.kozlowski@canonical.com>
Hi,
Le jeu., mars 17 2022 at 12:52:59 +0100, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> a écrit :
> Unit node addresses should not have leading 0x:
>
> Warning (unit_address_format):
> /nemc@13410000/efuse@d0/eth-mac-addr@0x22: unit name should not have
> leading "0x"
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index 3f9ea47a10cd..b998301f179c 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -510,7 +510,7 @@ efuse: efuse@d0 {
> #address-cells = <1>;
> #size-cells = <1>;
>
> - eth0_addr: eth-mac-addr@0x22 {
> + eth0_addr: eth-mac-addr@22 {
> reg = <0x22 0x6>;
> };
> };
> --
> 2.32.0
>
next prev parent reply other threads:[~2022-03-17 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 11:52 Krzysztof Kozlowski
2022-03-17 14:53 ` Paul Cercueil [this message]
2022-03-18 8:42 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MC9W8R.BUBMZ3NYL78N2@crapouillou.net \
--to=paul@crapouillou.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®