mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xu Roland <mu001999@outlook.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "ojeda@kernel.org" <ojeda@kernel.org>,
	"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
	"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 回复: [PATCH] rust: kernel: make impl_has_work compatible with more complex generics
Date: Wed, 22 May 2024 13:24:47 +0000	[thread overview]
Message-ID: <ME0P282MB4890C545F827111FCE2D2AA0CCEB2@ME0P282MB4890.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAH5fLgiL7EdnzRL79x4zX0pXrtb8OjVkRib+qkoi=TyzHzEc4A@mail.gmail.com>

Alice Ryhl Wrote:
> Please provide a more complete commit description. What user motivates
> this change?

I sent two new emails but I thought I made something wrong cause It seems not consequent with this.
And I found this issue at https://github.com/Rust-for-Linux/linux/issues/1077

________________________________________
发件人: Alice Ryhl <aliceryhl@google.com>
发送时间: 2024年5月22日 20:37
收件人: mu001999
抄送: ojeda@kernel.org; boqun.feng@gmail.com; rust-for-linux@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH] rust: kernel: make impl_has_work compatible with more complex generics

On Wed, May 22, 2024 at 2:27 PM mu001999 <mu001999@outlook.com> wrote:
>
> Signed-off-by: mu001999 <mu001999@outlook.com>

Please provide a more complete commit description. What user motivates
this change?

>  impl_has_work! {
> -    impl<T> HasWork<Self> for ClosureWork<T> { self.work }
> +    impl{T} HasWork<Self> for ClosureWork<T> { self.work }
>  }

I ended up doing something similar for the generics in some of the
linked list patches. Does anyone know if it's possible to support this
without giving up the <T> syntax?

Alice

  reply	other threads:[~2024-05-22 13:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 12:27 mu001999
2024-05-22 12:37 ` Alice Ryhl
2024-05-22 13:24   ` Xu Roland [this message]
2024-05-27  9:05   ` Benno Lossin
2024-05-22 12:38 ` Miguel Ojeda
2024-05-22 13:24   ` 回复: " Xu Roland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ME0P282MB4890C545F827111FCE2D2AA0CCEB2@ME0P282MB4890.AUSP282.PROD.OUTLOOK.COM \
    --to=mu001999@outlook.com \
    --cc=aliceryhl@google.com \
    --cc=boqun.feng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®